Commit graph

192 commits

Author SHA1 Message Date
Justin Kim
756bd269e1 ges-launch: unref GApplication properly
Differential Revision: https://phabricator.freedesktop.org/D380
2016-06-29 09:02:10 -04:00
Justin Kim
61c25a312f ges-launcher: don't leak sanitized_timeline string
Summary:
sanitized_timeline is created when parsing command line,
but it isn't free'd.

Reviewers: thiblahute

Differential Revision: https://phabricator.freedesktop.org/D382
2016-03-09 10:42:14 +01:00
Thibault Saunier
0045cce6fa launcher: Make sure to not activate validate twice when simply loading a scenario 2015-11-04 18:37:34 +01:00
Vineeth TM
fd29e28c71 editing-services: Fix memory leaks when context parse fails
When g_option_context_parse fails, context and error variables are not getting free'd
which results in memory leaks. Free'ing the same.

And replacing g_error_free with g_clear_error, which checks if the error being passed
is not NULL and sets the variable to NULL on free'ing.

https://bugzilla.gnome.org/show_bug.cgi?id=753864
2015-09-30 12:16:15 +02:00
Justin Kim
04bac06fad ges-launcher: don't leak GError
https://bugzilla.gnome.org/show_bug.cgi?id=754858
2015-09-11 11:26:35 +02:00
Justin Kim
32c694cc00 ges-launcher: fix double free when argument is invalid
https://bugzilla.gnome.org/show_bug.cgi?id=754783
2015-09-09 16:42:48 +02:00
Thibault Saunier
321d2c2edd ges: Raise an error when the discoverer returns != RESULT_OK
And do not try to run the pipeline when that happens
2015-06-10 08:35:45 +02:00
Tim-Philipp Müller
967bb50814 ges-launch: don't print random position/duration values at startup 2015-06-09 12:23:59 +01:00
Thibault Saunier
fee018b358 tools: Exit the app as it is a simgle instance app
And force exiting GstValidate when wanted
2015-06-05 22:49:46 +02:00
Tim-Philipp Müller
bb40668ff9 Remove obsolete Android build cruft
This is not needed any longer.
2015-04-26 18:23:14 +01:00
Edward Hervey
e651c43914 tools: Fix string leak
Only allocate the return string when we know we are going to return
it.

Coverity CID #1292292
2015-04-22 15:07:58 +02:00
Thibault Saunier
4aaee7d5f5 tools:launch: Print out the timeline description as an INFO not an ERROR 2015-04-16 10:28:46 +02:00
Thibault Saunier
de256fcf13 tools:launch: clean user facing message on wrong timeline description
Summary:
Before:

  $ ../gst-editing-services/tools/ges-launch-1.0 -p
  0:00:00.028629728  8155      0x17e1b60 ERROR                default ges-launcher.c:214:_create_timeline: serialized timeline is   -p

  ** (lt-ges-launch-1.0:8155): ERROR **: Could not create timeline, error: Could not find a suitable formatter
  [1]    8155 trace trap (core dumped)  ../gst-editing-services/tools/ges-launch-1.0 -p

  $

After:

  $ GST_DEBUG=0 ges-launch-1.0 -p

  ERROR: Could not create timeline, error: Could not find a suitable formatter

  $

Reviewers: Mathieu_Du

Differential Revision: http://phabricator.freedesktop.org/D95
2015-04-15 17:53:01 +02:00
Mathieu Duponchelle
c271f89d4a ges-launch: Add support for +test-clip
Summary: With the pattern as a mandatory argument.

Reviewers: thiblahute

Differential Revision: http://phabricator.freedesktop.org/D68
2015-04-07 14:15:36 +02:00
Mathieu Duponchelle
44af36026f ges-launch: Add a save-only option.
Summary: + Allows to serialize the timeline without playing it back.

Reviewers: thiblahute

Differential Revision: http://phabricator.freedesktop.org/D66
2015-04-07 14:15:36 +02:00
Mathieu Duponchelle
4a519bcf5c ges-launch: Better document options.
+ Sort them by topic
+ remove --sample-paths and --sample-paths-recurse.

http://phabricator.freedesktop.org/D58
2015-03-25 19:46:59 +01:00
Mathieu Duponchelle
2c4b92fd98 ges-launch: port to GApplication
Summary: + Extract some utility functions.

Reviewers: thiblahute

Differential Revision: http://phabricator.freedesktop.org/D55
2015-03-25 12:27:52 +01:00
Mathieu Duponchelle
b55265c70d Revert "ges-launch: no need for a tmp string pointer"
This reverts commit 44a0924c1f.

There indeed is a need for a tmp string pointer.
2015-03-24 13:01:39 +01:00
Luis de Bethencourt
44a0924c1f ges-launch: no need for a tmp string pointer 2015-03-24 11:21:08 +00:00
Luis de Bethencourt
865634d66c ges-launch: free string before going out of scope
CID #1291632
2015-03-24 11:19:50 +00:00
Mathieu Duponchelle
7efa8c86a9 ges-launch: Remove useless options, rename some short options. 2015-03-23 12:41:00 +01:00
Mathieu Duponchelle
8e18fd790c bash-completion: Add support for new ges-launch commands. 2015-03-23 12:41:00 +01:00
Thibault Saunier
e37d8e768f ges: command-line-formatter: Properly error out on invalid arguments 2015-03-20 13:53:42 +01:00
Thibault Saunier
28a1e97aa2 ges: Factor out a GESCommandLineFormatter class
This formatter will allow any user to deserialize a timeline using
the new ges-launch command line interface
2015-03-20 13:53:42 +01:00
Mathieu Duponchelle
761067b685 structure-interface: rename layer-priority to layer.
+ And add a short name for it in ges-launch.
2015-03-20 13:53:41 +01:00
Mathieu Duponchelle
6f1091f84a ges-launch: parse property names longer than 1 char.
+ And finish the previous structure when encountering a setter.
2015-03-20 13:53:41 +01:00
Mathieu Duponchelle
c6dedf2f36 ges-launch: Update lexer / parser to handle set-*
+ cleanup of the lexer
2015-03-20 13:53:40 +01:00
Thibault Saunier
ecf167e95e tools: Implement a new CLI interface for the timeline creation 2015-03-20 13:53:40 +01:00
Thibault Saunier
5d7b37112f launcher: Add support to --set-property in the parser 2015-03-20 13:53:40 +01:00
Mathieu Duponchelle
abb5f2cc2f ges-launch: Implement a new parser for the commandline.
Summary: + flex-based lexing and manual simplistic parsing.

Test Plan: Use that stuff to make awesome things, see if it breaks.
2015-03-20 13:53:40 +01:00
Thibault Saunier
c2583e01b6 tools: Avoid trying to remove a signal handler that has already been removed 2014-12-13 15:14:39 +01:00
Thibault Saunier
ff2ccb71ac validate: Handle long tests in the TestManager
+ Minor bug fixes
2014-12-06 10:34:18 +01:00
Thibault Saunier
c7cceae128 validate: Avoid depending on not stable APIs
And cleanup includes
2014-12-06 10:34:17 +01:00
Thibault Saunier
3b353be8ea ges: Keep backward compatibility for relocated assets CLI
Meaning adding an API for user to add relacation URI paths

API:
    ges_add_missing_uri_relocation_uri
2014-12-06 10:34:16 +01:00
Thibault Saunier
ac3cad47b6 validate: Expose GES Validate action
So other can also make use of those action outside
ges-launch itself

https://bugzilla.gnome.org/show_bug.cgi?id=740718
2014-12-06 10:34:15 +01:00
Thibault Saunier
58d525a4e7 ges: Add an init option to set media paths for moved assets
Allowing user to easily set a set of paths to look for moved
assets instead of needing the to re implement that logic
over and over.

https://bugzilla.gnome.org/show_bug.cgi?id=740714
2014-12-06 10:34:15 +01:00
Thibault Saunier
b14b5d92ca tools: launch: Wait for the project to be loaded to activate gst-validate
Otherwize we could have a race where GstValidate actions are launched
even before the project has been loaded
2014-11-10 16:22:42 +01:00
Thibault Saunier
aac186a742 tools: Never try to propose same URI when we know it is missing URI 2014-11-10 16:22:42 +01:00
Thibault Saunier
903f30cb32 tools:launch: Properly terminate when we get a SIGINT signal 2014-11-10 16:22:41 +01:00
Mathieu Duponchelle
0192c0e237 ges-validate: inform of clip removal. 2014-11-10 16:22:41 +01:00
Thibault Saunier
ca0ce859de validate: Implement validate Action type to handle KeyFrames
New action types:
  * set-control-binding
  * add-keyframe
  * remove-keyframe
2014-11-10 16:22:40 +01:00
Thibault Saunier
6d8f744f7f ges-validate: Add actions to add/remove object from container
+ Add an action to set an asset on a GESTimelineElement
2014-11-10 16:22:39 +01:00
Thibault Saunier
c0a0c1f582 ges-validate: Fix edit_container return code
It used to always return FALSE.

+ Fix minor leaks
+ Do not seek ourself, it is users responsability to seek and
commit these days.
2014-11-10 16:22:39 +01:00
Thibault Saunier
0cdec2c2d0 ges-validate: Add an action type to set restriction caps on track 2014-11-10 16:22:38 +01:00
Thibault Saunier
92cb5811e7 tools: Handle asset relocation for assets from scenario
Allowing us to share scenario and media file!
2014-11-10 16:22:38 +01:00
Thibault Saunier
4691210030 ges-validate: Add support for Layer.auto-transition
+ Fix a bug where the mandatory field name for the name of the clip to
remove in remove-clip did not correspond to what we used in the action
(clip-name vs name).
2014-11-10 16:22:38 +01:00
Thibault Saunier
f362e81a29 ges-validate: Add commit and split-clip action types
And stop commit at the end of other action types, this now
has to be done in the scenario itself.
2014-11-10 16:22:38 +01:00
Thibault Saunier
8a6892ba0a ges-validate: Add start/inpoint/duration params to the add-clip action 2014-11-10 16:22:38 +01:00
Thibault Saunier
f4faa487ba tools:ges-launch: Save the project at the end of execution
So that changes from scenarios are taken into account
2014-11-10 16:22:38 +01:00
Thibault Saunier
2d3769f079 tools:ges-launch: Do not set pipeline state before the timeline is ready
When we are loading a project
2014-11-10 16:22:37 +01:00