Sebastian Dröge
3386de7a8a
rtpsource: Make sequence number comparison code more readable
...
... by using gst_rtp_buffer_compare_seqnum() and signed integers
instead of implictly using effects of integer over/underflows.
2015-05-18 18:43:16 +03:00
Sebastian Dröge
ca110fb0b8
rtpjitterbuffer: When detecting a huge seqnum gap, wait for 5 consecutive packets before resetting everything
...
It might just be a late retransmission or spurious packet from elsewhere, but
resetting everything would mean that we will cause a noticeable hickup. Let's
get some confidence first that the sequence numbers changed for whatever
reason.
https://bugzilla.gnome.org/show_bug.cgi?id=747922
2015-05-18 18:43:15 +03:00
Nicolas Dufresne
1797c8f8b1
doc: Workaround gtkdoc issue
...
With gtkdoc 1.22, the XML generator fails when a itemizedlist is
followed by a refsect2. Workaround the issue by wrapping the
refsect2 into para.
2015-05-16 23:37:06 -04:00
Stefan Sauer
426eb3e300
qtdemux: avoid wrong warnings on unknown node types
...
Add 'name' and 'mean' fourccs, as we handle them. Right now each use would
trigger a warning.
2015-05-15 14:56:07 +02:00
Nicola Murino
fefeda5e6c
rtpg726depay: add block_align to output caps
...
It is needed to correctly negotiate caps with matroskamux
and most other muxers.
https://bugzilla.gnome.org/show_bug.cgi?id=749129
2015-05-13 12:39:07 +01:00
Sebastian Dröge
e11a537b65
audiofxbasefirfilter: Fix time-domain convolution with >1 channels
...
input_samples is the number of frames, but we used it as the number of
samples.
https://bugzilla.gnome.org/show_bug.cgi?id=747204
2015-05-12 13:41:58 +03:00
Tim-Philipp Müller
2e412a447a
docs: update example pipelines in element docs
...
Mostly gst-launch -> gst-launch-1.0
Use autovideosink/autoaudiosink more often.
Sprinkle some converters here and there.
2015-05-10 11:05:00 +01:00
Tim-Philipp Müller
3755409409
splitmuxsrc: minor error message clean-up
...
Don't put filename in error message shown to user.
2015-05-10 10:53:13 +01:00
Guillaume Desmottes
2bd3685d04
flacparse: fix buffer leak when stored to seektable
...
Fix a leak with the
validate.file.playback.change_state_intensive.samples_multimedia_cx_flac_Yesterday_flac
scenario.
https://bugzilla.gnome.org/show_bug.cgi?id=749072
2015-05-08 11:11:40 +01:00
Paul Hyunil
3792e9ca9b
qtdemux: fix example pipeline in docs
...
The gst-launch script for example launch line to test qtdemux is
missing a queue before the decodebins, otherwise the gst-launch-1.0
command won't work.
https://bugzilla.gnome.org/show_bug.cgi?id=749054
2015-05-08 11:06:31 +01:00
Sebastian Dröge
27729a2960
Revert "rtpsession: Also report internal sources in on-new-ssrc and on-ssrc-active"
...
This reverts commit d22ec49632
.
Application code might expect that it only gets external sources on those
signals, and get confused by this. If anything we would need to add new
signals.
2015-05-07 14:51:45 +02:00
Sebastian Dröge
d22ec49632
rtpsession: Also report internal sources in on-new-ssrc and on-ssrc-active
...
Without this it seems impossible for an application to easily get notified
about the internal ssrcs that are created, e.g. sender sources, and also
to know when they are active and produce RTCP packets.
https://bugzilla.gnome.org/show_bug.cgi?id=746747
2015-05-06 11:21:22 +02:00
Sebastian Dröge
9865730cfa
rtspsrc: Fix up last commit
2015-05-04 16:50:38 +02:00
Sebastian Dröge
d08f488598
rtspsrc: Only do RTX when using a feedback profile
2015-05-04 16:47:30 +02:00
Sebastian Dröge
9d22ad421b
rtpsession: The stats min_interval is in seconds, not nanoseconds
...
We have to scale it to compare it against our clock times.
2015-05-04 14:12:07 +02:00
Sebastian Dröge
afe1d5a89f
rtpsession: Only return TRUE if early feedback was requested already and it's early enough
2015-05-04 14:11:00 +02:00
Luis de Bethencourt
06d1ae313d
matroska: remove unused property enum items
2015-04-30 15:43:09 +01:00
Tim-Philipp Müller
377c8405aa
qtdemux: fix buffer leak on eos in push mode
...
Based on patch by Guillaume Desmottes.
scenario: validate.http.playback.seek_with_stop.raw_h264_1_mp4
https://bugzilla.gnome.org/show_bug.cgi?id=748617
2015-04-30 13:35:16 +01:00
Sebastian Dröge
178f0a4522
qtdemux: Check for sizes of the rdrf (redirect) atom before accessing the data and use g_strndup() instead of g_strdup()
...
Thanks to Ralph Giles for reporting this.
2015-04-29 19:41:29 +02:00
Sebastian Dröge
33693525b9
rtspsrc: Only enable retransmissions if there is retransmission info in the SDP
...
Otherwise we're going to send early RTCP and NACKs in non-feedback sessions
too, which will confuse servers.
https://bugzilla.gnome.org/show_bug.cgi?id=748627
2015-04-29 15:53:09 +02:00
Guillaume Desmottes
7f4f4131df
matroskademux: fix seek event leak
...
gst_matroska_demux_handle_seek_event() doesn't consume the
event so we have to unref it.
https://bugzilla.gnome.org/show_bug.cgi?id=748584
2015-04-28 19:24:40 +01:00
Sebastian Dröge
9119fbd774
matroska-demux: Send pending tags when adding a new pad
...
We might've parsed those tags before already and tried to push them to
non-existing pads before. Now let's do it for real.
2015-04-28 15:42:49 +02:00
Sebastian Dröge
73c0c2920f
rtpstats: Average RTCP packet size is in bytes, bandwidths in bits
...
We need to convert the size to bits for our calculations.
https://bugzilla.gnome.org/show_bug.cgi?id=747863
2015-04-27 16:45:40 +02:00
Sebastian Dröge
475b1e607e
rtpstats: Use the same lower limit for RTCP bandwidth to stop sending RTCP everywhere
...
https://bugzilla.gnome.org/show_bug.cgi?id=747863
2015-04-27 16:45:33 +02:00
Sebastian Dröge
7596ed91b8
rtpsession: Use bandwidth calculation by default instead of some arbitrary hardcoded value
...
https://bugzilla.gnome.org/show_bug.cgi?id=747863
2015-04-27 16:45:25 +02:00
Sebastian Dröge
928cd110bc
rtpsession: Bandwidth is supposed to be in bits/s, not bytes/s
...
https://bugzilla.gnome.org/show_bug.cgi?id=747863
2015-04-27 16:45:14 +02:00
Luis de Bethencourt
9391622579
Rename property enums from ARG_ to PROP_
...
Property enum items should be named PROP_ for consistency and readability.
2015-04-27 11:22:11 +01:00
Ilya Konstantinov
fd391a5404
rtpjitterbuffer: Fix "stats" property docs
...
https://bugzilla.gnome.org/show_bug.cgi?id=748436
2015-04-26 21:15:44 +02:00
Tim-Philipp Müller
d753a3eeb1
Remove obsolete Android build cruft
...
This is not needed any longer.
2015-04-26 17:55:07 +01:00
Thiago Santos
0ade8b813f
videocrop: print the property values when set
...
Instead of printing the currently used values. The log is meant
to show what the properties changed to, not what is being currently
used.
2015-04-24 13:55:51 -03:00
Luis de Bethencourt
671b4d25cd
remove unused enum items PROP_LAST
...
This were probably added to the enums due to cargo cult programming and are
unused. Removing them.
2015-04-24 17:01:12 +01:00
Tim-Philipp Müller
03d3d36053
level: fix infinite loop for very low interval values
...
https://bugzilla.gnome.org/show_bug.cgi?id=745515
2015-04-24 00:51:29 +01:00
Jesper Larsen
3528046773
rtspsrc: Fix RTCP caps leak
...
https://bugzilla.gnome.org//show_bug.cgi?id=748353
2015-04-23 14:56:27 +01:00
Sebastian Dröge
edcc5be297
rtpjitterbuffer: When request retransmissions for future packets, consider the packet spacing in the extra delay
...
We now take the maximum of 2*jitter and 0.5*packet_spacing for the extra
delay. If jitter is very low, this should prevent unnecessary retransmission
requests to some degree.
https://bugzilla.gnome.org/show_bug.cgi?id=748041
2015-04-22 20:27:18 +02:00
Sebastian Dröge
3fe8ceff14
rtpjitterbuffer: Take a running average of the packet spacings instead of just the latest
...
https://bugzilla.gnome.org/show_bug.cgi?id=748041
2015-04-22 20:25:43 +02:00
Miguel París Díaz
f81c9a9568
rtpjitterbuffer: Add "rtx-next-seqnum" property
...
If this is set to FALSE, rtpjitterbuffer will not request retransmissions for
future packets based on when they are estimated to arrive.
See also https://bugzilla.gnome.org/show_bug.cgi?id=748041
https://bugzilla.gnome.org/show_bug.cgi?id=739868
2015-04-22 19:51:18 +02:00
Sebastian Dröge
68dfe93463
rtxreceive: Put debug output for retransmission requests at the right place
...
Before it was only ever printed once for every time a ssrc was associated with
a specific stream.
2015-04-22 19:51:18 +02:00
Luis de Bethencourt
c884a3b3a5
equalizer: fix dynamic changes on bands
...
When we are in passthrough, the transform function doesn't run and if the
passthrough check is in this function it will never be deactivated. Fix this by
checking directly whenever a gain is changed.
Also set the passthrough to TRUE at init because the gains default to 0, so we
can passthrough until any gain property is changed.
https://bugzilla.gnome.org/show_bug.cgi?id=748068
2015-04-22 10:38:39 +01:00
Vincent Penquerc'h
6e3835594c
ac3parse: fix memory leak
2015-04-17 13:33:09 +01:00
Alex O'Konski
fc038f1f4e
icydemux: Fix segfault if metadata-interval is 0
...
Prevents an extra unref of GstBuffer when passing a non-icy stream through
icydemux with metadata-interval set to 0.
Reproducible with:
gst-launch-1.0 filesrc location=~/testsong.mp3 ! \
'application/x-icy,metadata-interval=(int)0' ! icydemux ! decodebin ! wavenc ! \
filesink location=~/testsong.wav
https://bugzilla.gnome.org/show_bug.cgi?id=748024
2015-04-17 10:01:02 +01:00
Ravi Kiran K N
fd6a5a5d90
audiofx: fix typo in example pipelines
...
Fix typo in example pipelines
https://bugzilla.gnome.org/show_bug.cgi?id=748022
2015-04-17 09:53:46 +01:00
Sebastian Dröge
80268e7d37
rtpsource/rtprtxsend: Also pass correct seqnum-offset and payload to the RTX rtpsource
...
https://bugzilla.gnome.org/show_bug.cgi?id=747394
2015-04-16 17:33:37 +02:00
Arun Raghavan
26bec72e52
rtpsession: Track RTX ssrc caps
...
This is needed so that we can generate SR for RTX stream correctly (the
clock rate is required).
https://bugzilla.gnome.org/show_bug.cgi?id=747394
2015-04-16 17:33:37 +02:00
Sebastian Dröge
17c6532b75
rtprtxsend: Copy over timestamps from the orignal buffers to the RTX buffers
...
https://bugzilla.gnome.org/show_bug.cgi?id=747394
2015-04-16 17:33:37 +02:00
Vincent Penquerc'h
f02ad47998
qtdemux: fix tag list leaks on error paths
2015-04-16 13:10:22 +01:00
Vincent Penquerc'h
765faa306a
qtdemux: fix tag list leak on unknown stream type
2015-04-16 13:10:21 +01:00
George Kiagiadakis
97c03449a4
splitmuxsink: do not access property variable without the object lock, use the local stack copy instead
2015-04-15 13:30:19 +02:00
George Kiagiadakis
1954726328
splitmuxsink: add probe on the multiqueue's sink pad instead of the ghost pad
...
because _release_pad tries to release it from ctx->sinkpad, which is
multiqueue's sink pad, and currently fails because the probe is not
installed there
2015-04-15 13:30:19 +02:00
Sebastian Dröge
caa255d2ed
rtprtx*: Fix typos
2015-04-14 19:08:38 +02:00
Sebastian Dröge
bd19b08d6d
rtpsession: Not sending early RTCP now because of dithering means we send it with the next compound packet
2015-04-14 18:42:44 +02:00