Commit graph

5361 commits

Author SHA1 Message Date
Andy Wingo
451ff2f992 gst-libs/gst/audio/gstbaseaudiosink.c
Original commit message from CVS:
2007-02-05  Andy Wingo  <wingo@pobox.com>

* gst-libs/gst/audio/gstbaseaudiosink.c
(gst_base_audio_sink_callback): Update basesink->offset so that we
pull monotonically increasing offsets instead of, um, seeking back
to 0 each time. Fixes alsasrc ! alsasink!
2007-02-05 18:39:51 +00:00
Tim-Philipp Müller
2933302ce8 gst/videoscale/gstvideoscale.c: A width and height of 1 makes us crash, so increase minimum size to 2x2 pixels until ...
Original commit message from CVS:
* gst/videoscale/gstvideoscale.c:
A width and height of 1 makes us crash, so increase minimum size to
2x2 pixels until someone feels like fixing this (#404512).
2007-02-05 11:44:52 +00:00
Tim-Philipp Müller
e7a698506c tests/check/pipelines/oggmux.c: Add small test to make sure request pads are cleaned up properly even if oggmux never...
Original commit message from CVS:
* tests/check/pipelines/oggmux.c: (GST_START_TEST), (oggmux_suite):
Add small test to make sure request pads are cleaned up properly
even if oggmux never changes state out of NULL.
2007-02-04 16:23:37 +00:00
Tim-Philipp Müller
b1751ae3cb tests/check/libs/utils.c: Fix unit test. Turns out things work much better when you
Original commit message from CVS:
* tests/check/libs/utils.c: (GST_START_TEST):
Fix unit test. Turns out things work much better when you
NULL-terminate string arrays. Should make p5 build bot happy again.
2007-02-04 14:11:51 +00:00
Tim-Philipp Müller
2594880e87 gst-libs/gst/audio/: Oops, forgot to commit fixed-up example.
Original commit message from CVS:
* gst-libs/gst/audio/Makefile.am:
* gst-libs/gst/audio/gstaudiofiltertemplate.c:
(gst_audio_filter_template_base_init),
(gst_audio_filter_template_class_init),
(gst_audio_filter_template_init),
(gst_audio_filter_template_set_property),
(gst_audio_filter_template_get_property),
(gst_audio_filter_template_setup),
(gst_audio_filter_template_filter),
(gst_audio_filter_template_filter_inplace), (plugin_init):
Oops, forgot to commit fixed-up example.
2007-02-03 23:28:45 +00:00
Tim-Philipp Müller
b63fff63d4 Port GstAudioFilter to 0.10. This change technically breaks but seems justifiable on the grounds that the base class ...
Original commit message from CVS:
* docs/libs/gst-plugins-base-libs-sections.txt:
* gst-libs/gst/audio/gstaudiofilter.c: (gst_audio_filter_get_type),
(gst_audio_filter_class_init), (gst_audio_filter_init),
(gst_audio_filter_set_caps),
(gst_audio_filter_class_add_pad_templates):
* gst-libs/gst/audio/gstaudiofilter.h:
Port GstAudioFilter to 0.10. This change technically breaks
API and ABI (and thus also every library developer's heart),
but seems justifiable on the grounds that the base class was
completely unusable before (ie. would crash immediately when
actually used). Fixes #403963 (and eventually also #403572).
Also document all of this a bit.
2007-02-03 20:19:35 +00:00
Tim-Philipp Müller
7d78598f24 Lowering log level to see why things fail on the p5 build bot; fix some typos in unit test messages.
Original commit message from CVS:
* gst-libs/gst/utils/install-plugins.c:
(gst_install_plugins_spawn_child):
* tests/check/libs/utils.c:
(test_base_utils_install_plugins_do_callout):
Lowering log level to see why things fail on the p5 build bot;
fix some typos in unit test messages.
2007-02-03 14:26:54 +00:00
Tim-Philipp Müller
92c11d5d24 tests/check/libs/utils.c: Don't hard-code temp directory for test helper; use GLib functions to write out file and do...
Original commit message from CVS:
* tests/check/libs/utils.c:
(test_base_utils_install_plugins_do_callout):
Don't hard-code temp directory for test helper; use GLib functions
to write out file and do error checking etc.
2007-02-03 13:59:27 +00:00
Tim-Philipp Müller
17a02da2fd gst-libs/gst/utils/: API: add API for applications to initiate installation of missing plugins, ie. gst_install_plugi...
Original commit message from CVS:
* gst-libs/gst/utils/Makefile.am:
* gst-libs/gst/utils/base-utils.h:
* gst-libs/gst/utils/install-plugins.c:
(gst_install_plugins_context_set_xid),
(gst_install_plugins_context_new),
(gst_install_plugins_context_free),
(gst_install_plugins_get_helper),
(gst_install_plugins_spawn_child),
(gst_install_plugins_return_from_status),
(gst_install_plugins_installer_exited),
(gst_install_plugins_async), (gst_install_plugins_sync),
(gst_install_plugins_return_get_name),
(gst_install_plugins_installation_in_progress):
* gst-libs/gst/utils/install-plugins.h:
API: add API for applications to initiate installation of missing
plugins, ie. gst_install_plugins_async() primarily.
Based on libgimme-codec by Ryan Lortie.
* configure.ac:
Add --with-install-plugins-helper configure option so distros can specify
the path of the helper script or program to call when plugin installation
is requested (distros: please do any argument munging in this helper
script instead of patching GStreamer to pass arguments differently
to another program directly).
* docs/libs/gst-plugins-base-libs-docs.sgml:
* docs/libs/gst-plugins-base-libs-sections.txt:
Build and document new API.
* tests/check/libs/utils.c: (result_cb),
(test_base_utils_install_plugins_do_callout), (GST_START_TEST),
(libgstbaseutils_suite):
Some simple checks for the new API.
2007-02-02 20:42:08 +00:00
Tim-Philipp Müller
7439949980 tests/check/elements/audioconvert.c: Add small test for 32bit float <=> 64bit float conversion (works only one way so...
Original commit message from CVS:
* tests/check/elements/audioconvert.c: (test_float_conversion):
Add small test for 32bit float <=> 64bit float conversion (works
only one way so far, 32=>64 produces structured noise).
2007-02-02 14:44:29 +00:00
Tim-Philipp Müller
b7cf10eb6d gst/audioconvert/gstaudioconvert.c: We don't support floats with a width of 40, 48 or 56 bits.
Original commit message from CVS:
* gst/audioconvert/gstaudioconvert.c:
(set_structure_widths_32_and_64), (make_lossless_changes):
We don't support floats with a width of 40, 48 or 56 bits.
2007-02-02 11:21:48 +00:00
Stefan Kost
36180a5f3d gst/audioconvert/: Support for 64-bit float audio in audioconvert (#339837)
Original commit message from CVS:
* gst/audioconvert/audioconvert.c: (float), (double),
(audio_convert_get_func_index):
* gst/audioconvert/gstaudioconvert.c: (set_structure_widths),
(make_lossless_changes):
Support for 64-bit float audio in audioconvert (#339837)
2007-02-02 09:48:53 +00:00
Holger Wansing
6f25185e75 po/: Add German translation (#352069).
Original commit message from CVS:
Patch by: Holger Wansing  <linux wansing-online de>
* po/LINGUAS:
* po/de.po:
Add German translation (#352069).
2007-02-01 18:50:08 +00:00
Sebastian Dröge
d1778e3f6d ext/ogg/gstoggmux.c: Use newly added GstCollectPads API to free the allocated resources in the GstOggPad structures (...
Original commit message from CVS:
reviewed by: Wim Taymans <wim@fluendo.com>
* ext/ogg/gstoggmux.c: (gst_ogg_mux_ogg_pad_destroy_notify),
(gst_ogg_mux_request_new_pad), (gst_ogg_mux_release_pad):
Use newly added GstCollectPads API to free the allocated resources in
the GstOggPad structures (#402393).
2007-02-01 17:52:39 +00:00
Jan Schmidt
800cd83487 gst/playback/gstplaybin.c: Add audioresample+audioconvert in front of the visualisation element, so that elements lik...
Original commit message from CVS:
* gst/playback/gstplaybin.c: (gen_vis_element):
Add audioresample+audioconvert in front of the visualisation
element, so that elements like libvisual 0.4 that don't support all
samplerates can work.
Fixes: #402505
2007-01-31 15:58:53 +00:00
Tim-Philipp Müller
514c2d7610 gst/playback/gstplaybasebin.c: Take some locks and make a copy of the streaminfo value array we maintain while holdin...
Original commit message from CVS:
* gst/playback/gstplaybasebin.c: (gst_play_base_bin_get_property),
(gst_play_base_bin_get_streaminfo_value_array):
Take some locks and make a copy of the streaminfo value array we
maintain while holding the lock, so that the application can
retrieve the stream-info as a value array in a thread-safe way.
2007-01-30 19:19:37 +00:00
Wim Taymans
75d5fcb62e gst/audioconvert/gstaudioconvert.c: Don't fail on 0 sized buffers. Fixes #396835.
Original commit message from CVS:
* gst/audioconvert/gstaudioconvert.c:
Don't fail on 0 sized buffers. Fixes #396835.
2007-01-30 11:29:17 +00:00
David Schleef
888ea4730e gst/typefind/gsttypefindfunctions.c: Detect BBCD as video/x-dirac, so we can play raw dirac streams.
Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c:
Detect BBCD as video/x-dirac, so we can play raw dirac
streams.
2007-01-29 21:13:07 +00:00
Tim-Philipp Müller
a37616d4df ext/theora/theoraenc.c: Check return value of theora_encode_header(), or we might try to allocate a random number of ...
Original commit message from CVS:
* ext/theora/theoraenc.c: (theora_enc_chain):
Check return value of theora_encode_header(), or we might try to
allocate a random number of bytes. theora_encode_header() can fail
if libtheora has been compiled with encoding support disabled.
Fixes #398110.
2007-01-29 18:14:25 +00:00
Wim Taymans
d49920f3a2 tests/check/gst/.cvsignore: Do as buildbot says.
Original commit message from CVS:
* tests/check/gst/.cvsignore:
Do as buildbot says.
2007-01-29 10:53:06 +00:00
Wim Taymans
5be1e44107 ext/libvisual/visual.c: Fix strides in libvisual. Gst uses X strides.
Original commit message from CVS:
* ext/libvisual/visual.c: (gst_visual_src_setcaps):
Fix strides in libvisual. Gst uses X strides.
Inspired by: <ed at catmur dot co dot uk> and
<tim at centricular dot net>
Fixes #401118.
2007-01-29 10:25:11 +00:00
Wim Taymans
fde9b0096c ext/ogg/gstoggdemux.*: Properly propagate streaming errors when we are scanning the file for chains so that we don't ...
Original commit message from CVS:
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_submit_buffer),
(gst_ogg_demux_get_data), (gst_ogg_demux_get_next_page),
(gst_ogg_demux_get_prev_page), (gst_ogg_demux_do_seek),
(gst_ogg_demux_perform_seek),
(gst_ogg_demux_bisect_forward_serialno),
(gst_ogg_demux_read_chain), (gst_ogg_demux_read_end_chain),
(gst_ogg_demux_find_chains), (gst_ogg_demux_handle_page),
(gst_ogg_demux_chain), (gst_ogg_demux_combine_flows),
(gst_ogg_demux_loop_reverse), (gst_ogg_demux_loop):
* ext/ogg/gstoggdemux.h:
Properly propagate streaming errors when we are scanning the file for
chains so that we don't crash when shut down. Might fix some crashers
when quickly switching oggs in RB such as #332503 and #378436.
2007-01-27 13:32:24 +00:00
Tim-Philipp Müller
3b3320ac38 ext/gnomevfs/gstgnomevfssrc.c: Map a gnome-vfs HOST_NOT_FOUND error into a GStreamer NOT_FOUND error code as well.
Original commit message from CVS:
* ext/gnomevfs/gstgnomevfssrc.c: (gst_gnome_vfs_src_start):
Map a gnome-vfs HOST_NOT_FOUND error into a GStreamer NOT_FOUND
error code as well.
2007-01-26 12:44:46 +00:00
Wim Taymans
ce1ff3c94c gst/playback/gstplaybasebin.c: Don't try to disconnect a signal from a finalized object.
Original commit message from CVS:
* gst/playback/gstplaybasebin.c: (remove_source):
Don't try to disconnect a signal from a finalized object.
2007-01-25 16:02:41 +00:00
Tim-Philipp Müller
af52900954 gst/playback/gstdecodebin2.c: Cast lock macro parameters to make sure we're actually accessing the lock member at the...
Original commit message from CVS:
* gst/playback/gstdecodebin2.c: (gst_decode_bin_dispose):
Cast lock macro parameters to make sure we're actually accessing the
lock member at the right class level. Free list itself in _dispose()
as well and NULL it in case dispose gets called multiple times.
2007-01-25 14:29:21 +00:00
Edward Hervey
a8d29e1f82 gst/playback/gstdecodebin2.c: Free GstDecodeGroups no longer used.
Original commit message from CVS:
* gst/playback/gstdecodebin2.c:
(gst_decode_bin_dispose),(gst_decode_bin_finalize):
Free GstDecodeGroups no longer used.
(gst_decode_group_expose):
Don't unlock too many times !
(deactivate_free_recursive):
Free iterator once we're done with it.
Fix for recursively deactivating elements (stop at ghostpads).
2007-01-25 14:02:37 +00:00
Tim-Philipp Müller
dab1309f32 gst/playback/gstplaybin.c: Fix up caps on the frame buffer before we save it and potentially make it accessible to ot...
Original commit message from CVS:
* gst/playback/gstplaybin.c: (handoff):
Fix up caps on the frame buffer before we save it and potentially
make it accessible to other threads via g_object_get; also use
gst_buffer_replace() instead of gst_mini_object_replace().
2007-01-25 12:24:18 +00:00
Tim-Philipp Müller
d289e2d55c gst/playback/gstplaybin.c: Make getting the current frame thread-safe.
Original commit message from CVS:
* gst/playback/gstplaybin.c: (gst_play_bin_get_property):
Make getting the current frame thread-safe.
2007-01-25 12:06:59 +00:00
Edward Hervey
77cf01b76b gst/playback/gstdecodebin2.c: Set queues to bigger sizes to cope with HD contents.
Original commit message from CVS:
* gst/playback/gstdecodebin2.c: (gst_decode_bin_finalize),
(gst_decode_group_new), (gst_decode_group_free):
Set queues to bigger sizes to cope with HD contents.
Fix some mutex freeing and add comment about MT safe methods.
2007-01-25 11:48:10 +00:00
Tim-Philipp Müller
5ed71164a3 ext/pango/gsttextoverlay.c: Don't unnecessarily ref (and then leak) upstream events if the text pad is not linked. Fi...
Original commit message from CVS:
* ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event),
(gst_text_overlay_text_event):
Don't unnecessarily ref (and then leak) upstream events if the text
pad is not linked. Fixes #399948.
* tests/check/gst-plugins-base.supp:
Add suppression for pango on edgy/x86 for textoverlay test.
2007-01-24 12:51:20 +00:00
Wim Taymans
81e92118da gst-libs/gst/rtp/gstrtpbuffer.h: Add some more fixed payloads.
Original commit message from CVS:
* gst-libs/gst/rtp/gstrtpbuffer.h:
Add some more fixed payloads.
2007-01-24 12:10:56 +00:00
Tim-Philipp Müller
c135f896e5 ext/ogg/gstoggdemux.c: Error out properly if we get an error from libogg while reading the
Original commit message from CVS:
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_read_chain):
Error out properly if we get an error from libogg while reading the
BOS page(s). Fixes crash parsing 'fuzzed' ogg file (#399340).
2007-01-23 18:39:45 +00:00
Tim-Philipp Müller
b8d04c8843 gst/playback/gstdecodebin2.c: Don't leak mutex.
Original commit message from CVS:
* gst/playback/gstdecodebin2.c: (gst_decode_bin_finalize):
Don't leak mutex.
* tests/check/elements/playbin.c:
(test_sink_usage_video_only_stream),
(test_suburi_error_unknowntype), (test_suburi_error_invalidfile),
(test_suburi_error_wrongproto), (test_missing_urisource_handler),
(test_missing_suburisource_handler),
(test_missing_primary_decoder), (playbin_suite):
Run all tests once with decodebin and once with decodebin2.
One test does not pass yet with decodebin2.
2007-01-23 17:49:29 +00:00
Edward Hervey
0fcb92f2dd ext/ogg/gstoggmux.c: Fix the cases where oggmux doesn't properly figure out that all sinkpads have gone EOS, and ther...
Original commit message from CVS:
* ext/ogg/gstoggmux.c: (all_pads_eos), (gst_ogg_mux_collected):
Fix the cases where oggmux doesn't properly figure out that all
sinkpads have gone EOS, and therefore doesn't push out the remaining
buffers and the final EOS event.
Fixes #363379
2007-01-23 14:30:28 +00:00
Julien Moutte
60dad35de0 sys/: Don't lock on navigation event push, just on keysym to string.
Original commit message from CVS:
2007-01-23  Julien MOUTTE  <julien@moutte.net>

* sys/ximage/ximagesink.c: (gst_ximagesink_handle_xevents):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents):
Don't lock on navigation event push, just on keysym to string.
Fixes #397673 again.
2007-01-23 13:19:19 +00:00
Edward Hervey
a5146c9037 gst/playback/gstdecodebin2.c: Cleanups.
Original commit message from CVS:
* gst/playback/gstdecodebin2.c: (gst_decode_group_new),
(get_current_group), (group_demuxer_event_probe),
(gst_decode_group_expose), (deactivate_free_recursive),
(gst_decode_group_free):
Cleanups.
Don't forget to emit 'no-more-pads' once a group is exposed.
Cleanup elements from a DecodeGroup once we remove it.
Protect call to gst_decode_group_expose() with the decodebin lock.
2007-01-22 17:37:38 +00:00
Julien Moutte
7861683872 sys/: Looking at Xorg code i can't figure out if that XKeysymToString function is thread sensible or not. Lock it jus...
Original commit message from CVS:
2007-01-22  Julien MOUTTE  <julien@moutte.net>

* sys/ximage/ximagesink.c: (gst_ximagesink_handle_xevents):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents):
Looking at Xorg code i can't figure out if that XKeysymToString
function is thread sensible or not. Lock it just in case as
recommended by Radek Doulik <rodo at ximian dot com>.
2007-01-22 13:16:42 +00:00
Julien Moutte
34af6e729d sys/: Lock that X Call as well. Fixes #397673.
Original commit message from CVS:
2007-01-22  Julien MOUTTE  <julien@moutte.net>

* sys/ximage/ximagesink.c: (gst_ximagesink_handle_xevents):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents):
Lock that X Call as well. Fixes #397673.
2007-01-22 13:10:13 +00:00
Tim-Philipp Müller
0da3960238 gst/typefind/gsttypefindfunctions.c: Don't go into an endless loop if the file starts with 00 00 01 2X, like quicktim...
Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c: (mpeg4_video_type_find):
Don't go into an endless loop if the file starts with 00 00 01 2X,
like quicktime redirect files might. Fixes #396042.
* tests/check/Makefile.am:
* tests/check/gst/.cvsignore:
* tests/check/gst/typefindfunctions.c: (GST_START_TEST),
(typefindfunctions_suite):
Add unit test for the above.
2007-01-22 12:03:27 +00:00
Tim-Philipp Müller
58e6e134cb gst-libs/gst/riff/riff-media.c: On second thought, use "depth" field rather than "bpp" field.
Original commit message from CVS:
* gst-libs/gst/riff/riff-media.c: (gst_riff_create_video_caps):
On second thought, use "depth" field rather than "bpp" field.
2007-01-22 10:27:26 +00:00
Tim-Philipp Müller
439b3193bd gst-libs/gst/riff/riff-media.c: Camtasia caps apparently need a bpp field (#398875).
Original commit message from CVS:
* gst-libs/gst/riff/riff-media.c: (gst_riff_create_video_caps):
Camtasia caps apparently need a bpp field (#398875).
2007-01-22 09:23:01 +00:00
Tim-Philipp Müller
acf3bcdfbb gst/playback/gstplaybasebin.c: Attempt at a better error message in case we don't have the required
Original commit message from CVS:
* gst/playback/gstplaybasebin.c: (setup_subtitle),
(gen_source_element), (gst_play_base_bin_change_state):
Attempt at a better error message in case we don't have the required
URI handler installed; post missing-plugin message also when we're
missing an URI handler for the subtitle URI; clean up properly also
when an error occurs and we never made it to PAUSED state.
* tests/check/elements/playbin.c: (GST_START_TEST),
(playbin_suite):
Check that we're also getting a missing-plugin messsage for a
missing subtitle URI handler (and clean up properly).
2007-01-19 19:09:05 +00:00
Tim-Philipp Müller
638dbd7b71 gst/playback/gstplaybasebin.c: Plug a few reference leaks.
Original commit message from CVS:
* gst/playback/gstplaybasebin.c: (analyse_source), (setup_source):
Plug a few reference leaks.
2007-01-19 18:47:30 +00:00
Tim-Philipp Müller
91773593cf gst/typefind/gsttypefindfunctions.c: Lower probability a bit if the marker isn't right at the start, to decrease the ...
Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
Lower probability a bit if the marker isn't right at the start,
to decrease the chance of false positives.
2007-01-19 12:23:06 +00:00
Tim-Philipp Müller
c47074371a gst/typefind/gsttypefindfunctions.c: Small mpeg2 system stream typefinding improvement: make typefinder probe a bit i...
Original commit message from CVS:
* gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
Small mpeg2 system stream typefinding improvement: make typefinder
probe a bit into the stream instead of just looking for a marker
at the beginning. Fixes #397810.
2007-01-19 11:31:50 +00:00
Tim-Philipp Müller
4936d6ba02 gst/audioconvert/gstchannelmix.c: Remove compatibility cruft for prehistoric GLib versions.
Original commit message from CVS:
* gst/audioconvert/gstchannelmix.c:
Remove compatibility cruft for prehistoric GLib versions.
2007-01-18 16:23:35 +00:00
Tim-Philipp Müller
5262208d6e gst/playback/: Let decodebin be the element to post missing-plugin messages for missing decoders (rather than playbin...
Original commit message from CVS:
* gst/playback/Makefile.am:
* gst/playback/gstdecodebin.c: (close_pad_link):
* gst/playback/gstdecodebin2.c: (analyze_new_pad):
* gst/playback/gstplaybasebin.c: (gst_play_base_bin_class_init),
(gst_play_base_bin_handle_message_func), (unknown_type):
Let decodebin be the element to post missing-plugin messages for
missing decoders (rather than playbin); make playbin implement
GstBin::handle_message so we can suppress missing-plugin messages
for types we're not handling on purpose (don't want to bring up an
installer in those cases).
2007-01-17 16:11:14 +00:00
Tim-Philipp Müller
0eac623115 gst/: Fix potentially unaligned access (#397207).
Original commit message from CVS:
* gst-libs/gst/riff/riff-media.c: (gst_riff_create_video_caps):
* gst-libs/gst/tag/gstvorbistag.c:
(gst_tag_list_to_vorbiscomment_buffer):
* gst/typefind/gsttypefindfunctions.c: (vorbis_type_find):
Fix potentially unaligned access (#397207).
2007-01-16 19:37:55 +00:00
Stefan Kost
268dcb0ab1 tests/examples/seek/seek.c: Allow to toggle looping while it plays. Fix callback prototype. Clean up code a bit more....
Original commit message from CVS:
* tests/examples/seek/seek.c: (set_scale), (update_scale),
(do_seek), (stop_seek), (pause_cb), (stop_cb), (loop_toggle_cb),
(rate_spinbutton_changed_cb), (msg_eos), (msg_segment_done),
(main):
Allow to toggle looping while it plays. Fix callback prototype. Clean
up code a bit more. Add copyright header.
2007-01-16 12:17:06 +00:00
Stefan Kost
bc62bb15e5 sys/xvimage/xvimagesink.c: Red and blue mask was swapped (spotted by Dan Williams).
Original commit message from CVS:
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_get_xv_support):
Red and blue mask was swapped (spotted by Dan Williams).
2007-01-16 11:41:58 +00:00