Sebastian Dröge
2dfa168736
tsdemux: Set number of channels to 2 for dual mono Opus
...
Instead of leaving it at 0, which will then cause caps creation to fail.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4446 >
2023-04-18 14:21:54 +01:00
Sebastian Dröge
655b25ffc4
ges: base-xml-formatter: Don't pass non-GObject pointers to GST_DEBUG_OBJECT
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4444 >
2023-04-18 11:55:10 +01:00
Guillaume Desmottes
0b8a9bfd51
dash: mpdclient: fix divide by 0 if segment has no duration
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4441 >
2023-04-18 09:03:26 +01:00
Seungha Yang
2c7a8739dd
d3d11compositor: Reconfigure resource only when output caps is changed
...
GstD3D11Converter setup is heavy operation since it requires
shader compile, GPU resource allocation, some math, mutex, etc.
We can avoid it if negotiated caps is not changed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4440 >
2023-04-17 19:34:17 +01:00
Edward Hervey
88353d8cb2
qtdemux: Fix av1C parsing
...
This is a regression introduced by
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3882
The av1c codec configuration parsing would always fail due to an off-by-one
error, the content of an atom starting at offset 8 (i.e. the 9th byte) and not
9 (the 10th byte).
Also introduce a break in order to not get stray warnings
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4435 >
2023-04-17 10:02:24 +01:00
Tim-Philipp Müller
1228ef095d
multifile: error out if no filename was set
...
Fixes #2483
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4429 >
2023-04-14 20:20:21 +00:00
Matthias Fuchs
96b61862f1
qtwindow: unref caps in destructor
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4418 >
2023-04-14 16:04:55 +00:00
Nicolas Dufresne
e3aad8b518
v4l2: Fix use after free of fmtdesc part 2
...
Add missing code in merge commit e890e6e8d8
("v4l2: Fix use after free of fmtdesc"). The v4l2object code was
missing.
Related to https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4317
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4426 >
2023-04-14 15:16:06 +00:00
Nicolas Dufresne
76c5eb4654
v4l2: Fix use after free of fmtdesc
...
The decoder needs to force another enumeration of the format. For
this it was clearing the v4l2object insternal list, leaving a fmtdesc
pointer pointing to freed memory. This patch clears the fmtdesc pointer
that has just been free. It also makes sure the probe function does not
use the cached formats list. The probe function will restore the current
fmtdesc pointer based on the currently configured pixelformat.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4426 >
2023-04-14 15:16:06 +00:00
Nicolas Dufresne
85e679ce1a
v4l2: videodec: Prefer acquired caps over anything downstream
...
As we don't have anything smart in the fixation process, we may endup with
a format that has a lower bitdepth, even if downstream can handle higher
depth. it is notably the case when negotiating with deinterlace, which places
is non-passthrough caps before its passthrough one. This makes the generic
fixation prefer the formats natively supported by deinterlace element over
the HW 10bit format. As some HW can downscale 10bit to 8bit, this can break
10bit decoding.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4426 >
2023-04-14 15:16:06 +00:00
Nicolas Dufresne
da136b1146
v4l2: videodec: Remove leading space in comment
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4426 >
2023-04-14 15:16:06 +00:00
Jan Alexander Steffens (heftig)
a299399f5c
tests: allocators: Fix fdmem test with recent GLib
...
The test failed with recent GLib, where `g_close` emits a critical
warning on EBADF. Remove the `g_close` check from `test_fdmem` and add
another version that tests `GST_FD_MEMORY_FLAG_DONT_CLOSE`.
We will depend on the Valgrind test run to warn us about leaked FDs.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2480
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4422 >
2023-04-14 10:14:48 +00:00
Jan Alexander Steffens (heftig)
020115dc34
imagesequencesrc: Properly set default location
...
Noticed this because the generic_states test kept segfaulting at random.
GLibC 2.37 can crash when NULL is supplied as a format string.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4425 >
2023-04-14 08:14:04 +00:00
Sebastian Dröge
905accecc1
gst: tracer: Initialize tracing infrastructure even if the debug system is not compiled in
...
There is a separate #define for the tracing infrastructure.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2467
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4424 >
2023-04-14 07:35:34 +00:00
Michael Olbrich
cb2dcf40b9
srtpdec: fix "srtp-key" check
...
The original code was:
if (!gst_structure_get (s, "srtp-key", GST_TYPE_BUFFER, &buf, NULL) || !buf) {
goto error;
} else {
stream->key = buf;
}
So use "srtp-key" if it is set so a non NULL buffer. The condition was
incorrectly inverted in ad7ffe64a6
to:
if (gst_structure_get (s, "srtp-key", GST_TYPE_BUFFER, &buf, NULL) || !buf) {
stream->key = buf;
} ...
Fix the condition so it works as originally intended and avoid accessing
'buf' uninitialised.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4423 >
2023-04-14 06:51:34 +00:00
Guillaume Desmottes
a921e40228
adaptivedemux2: fix critical when using an unsupported URI
...
adaptivedemux2 only supports http(s), trying to use it with, say,
file:// was raising a CRITICAL in libsoup.
Fix #2476
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4421 >
2023-04-14 05:17:16 +00:00
Matthias Fuchs
f4aeac45e5
glvideoflip: fix leaked caps
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4420 >
2023-04-14 04:33:30 +00:00
Matthias Fuchs
07c1b891b6
glcontext_wgl: fix missing unref
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4419 >
2023-04-14 03:45:12 +00:00
Aleksandr Slobodeniuk
936000f04e
d3d11videosink: fix race conditions in win32 window
...
One race condition is the fact that the window object
can be destroyed while running some routine in the UI
thread (such as resizing). To avoid that situation we make
UI thread hold a reference on the window object while it's
running.
Other probpematic case is when the window handle is reused:
if we stop and start the pipeline very fast,
so the sink creates a new window object that is going to use
the same window handle as the previous one.
And finally the case when the pipeline is stopped immediatelly
right after starting, this one is also handled in this commit.
NOTE: a unit test that reproduces this cases have been added
in the previous commit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4417 >
2023-04-14 02:09:07 +00:00
Aleksandr Slobodeniuk
fec6b6e9f0
d3d11videosink: add gstcheck test for win32 window
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4417 >
2023-04-14 02:09:06 +00:00
Seungha Yang
e972c43916
d3d11videosink: Enhancement for initial window size decision
...
Use AdjustWindowRect() method to calculate window size so that
video scene can be rendered on client area without black borders
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4416 >
2023-04-14 02:08:47 +01:00
Tim-Philipp Müller
d838d8dd1b
Back to development
2023-04-12 00:31:17 +01:00
Tim-Philipp Müller
a8f569e801
Release 1.22.2
2023-04-11 17:29:28 +01:00
Tim-Philipp Müller
4982c7d45e
gst-plugins-base: update translations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4390 >
2023-04-11 12:10:37 +01:00
Tim-Philipp Müller
c512b876b5
gstreamer: update translations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4390 >
2023-04-11 12:10:37 +01:00
Tim-Philipp Müller
0e6fe51c34
avmux: fix element leak
...
Fixes #2473
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4385 >
2023-04-10 19:05:35 +00:00
Tim-Philipp Müller
55d1a6ba0d
avdeinterlace: fix element leak
...
Fixes #2473
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4385 >
2023-04-10 19:05:35 +00:00
Seungha Yang
d16ed17747
h264decoder: Enable low-latency bumping in case of pic_order_cnt_type 2
...
In case of POC type 2, output order is equal to decoding order
(no frame reordering)
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2447
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4383 >
2023-04-10 17:05:53 +00:00
Seungha Yang
0e51c8c5e4
h264decoder: Fix for latency report
...
The minimum latency answered by an element should be the maximum
latency from the element's perspective. Also consider max_reorder_frames
update as a sequence change
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4383 >
2023-04-10 17:05:53 +00:00
Seungha Yang
976df011f6
h264decoder: Ignore invalid max_num_reorder_frames in VUI
...
It's not fatal and can be ignored
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4383 >
2023-04-10 17:05:53 +00:00
Seungha Yang
270ca09961
h265decoder: Fix for latency report when src caps is not configured
...
Depending on subclass, negotiation might not happen on new_sequence()
Fixing regression introduced by the commit
4a4823b972
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4383 >
2023-04-10 17:05:53 +00:00
Seungha Yang
8f8a0800b9
h264decoder: Fix for latency report when src caps is not configured
...
Depending on subclass, negotiation might not happen on new_sequence()
Fixing regression introduced by the commit
4a4823b972
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4383 >
2023-04-10 17:05:53 +00:00
Wang Chuan
08b4f38310
gstd3d11window: fix memory leak
...
GstStructure may leak when using external HWND
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4382 >
2023-04-10 15:33:44 +00:00
Jordan Petridis
c8f33f1836
meson: add missing source_filename in the dav1d wrap
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4379 >
2023-04-10 15:12:54 +00:00
Tim-Philipp Müller
d5957f89bf
debugqroverlay: fix string leak
...
g_string_free(.., FALSE) gives us ownership of the string
already, no need to duplicate that again with g_strdup(),
and doing so will leak the string returned by g_string_free()
here. Caught by compiler warnings in newer GLib versions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4380 >
2023-04-10 13:42:55 +00:00
Edward Hervey
75a550a1b1
twcc: Better handle duplicate packets
...
The previous code would only check if two packets in a row were duplicates. If
not (i.e. a packet is a duplicate of a packet received slightly before) the code
would generate completely bogus FCI because it assumes there were no duplicates
present in the array.
In order to be efficient, just store all received packets and remove the
duplicates just before the FCI is generated once the array of observations have
been sorted by seqnum.
Fixes TWCC usage with moderate to high packet duplication.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4378 >
2023-04-10 13:16:44 +01:00
Seungha Yang
5f17cb9f3d
decklinkaudiosink: Fix playback when video caps is configured before audio
...
Scheduled playback starts on videosink's state change or on caps
but it's possible that audiosink is configure without caps yet.
Try start scheduled playback on audiosink's caps event as well
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4368 >
2023-04-08 00:00:16 +01:00
Rouven Czerwinski
1ff0e6d305
gst-plugins-base: gl: wayland: cleanup on close
...
The proxy and queue are created in the gst_gl_window_wayland_egl_open()
function and will be recreated on open. This leaks both objects, the
wayland client documentation mentions that they should be destroyed
using the appropriate destroy functions.
Found during valgrind memory leak testing, these blocks were marked as
definitely lost.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4355 >
2023-04-06 12:16:58 +01:00
Alexande B
1ba677abda
osxvideosink: fix broken aspect ration and frame drawing region
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4346 >
2023-04-05 14:45:31 +00:00
Sebastian Dröge
2952caab9c
rtsp-server: media: First set state to PLAYING again temporarily, then send EOS
...
Sending the EOS event while the pipeline is PAUSED can deadlock on the
stream lock if a sink is currently blocked because of pre-rolling.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4345 >
2023-04-05 13:17:16 +00:00
Sebastian Dröge
2c3a1d0006
sdp: Skip source-specific caps fields when creating an SDP media from caps
...
Regression from https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2132
We parse the source-specific fields from the SDP and put it into the
caps, but when converting caps into an SDP again this would need special
handling. By default it would end up as part of the fmtp field, which is
simply wrong.
Automatically putting it into the caps and SDP will need some more work.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4344 >
2023-04-05 11:44:11 +00:00
Wojciech Kapsa
601b306aaa
decklink: fix 10 bit RGB (r210) format auto detection
...
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2391
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4342 >
2023-04-05 10:38:45 +00:00
Sebastian Dröge
da4c5c01d1
rtspsrc: Skip PTs with caps incompatible to the global caps
...
Otherwise empty caps are created while all following code assumes that
the caps will have exactly one structure, and then run into assertions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4343 >
2023-04-05 00:56:05 +01:00
Seungha Yang
cb08a6d8dc
tools: Count argc after parsing GOption on Windows
...
Existing codes rely on modified argc value by g_option_context_parse()
but g_option_context_parse_strv() is used in case of Windows.
Count arguments after the option parsing manually.
Fixing command "gst-inspect-1.0.exe -b"
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4322 >
2023-04-01 00:14:57 +00:00
Robert Rosengren
b2feff23bc
alsasink: Fix for being stuck in stop_streaming_threads state
...
Moving from PLAYING to NULL will set the stop_streaming_threads to TRUE,
but when moving back upwards its not reset to FALSE (as only done in
uncalled init and resume callbacks).
Fix by reseting value in the prepare callback.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4321 >
2023-03-31 23:46:28 +01:00
Shengqi Yu
5c9988b759
v4l2object: Add support for YVU420M format
...
This is a multi-planar format with planes non contiguous in memory. It
is intended to be used only in drivers and applications that support the
multi-planar API.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4318 >
2023-03-31 16:34:29 +01:00
Ilie Halip
476a8aca78
typefindfunctions: Increase xml typefinder closing brace limit
...
If the first XML element in a DASH manifest has its closing brance
beyond the first 512 bytes (because of, e.g. lots of attributes),
the MPD typefinder fails. Try to read a larger block, and then
smaller blocks until 512 bytes.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2385
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4302 >
2023-03-30 23:12:23 +00:00
Bart Van Severen
d2678a1f54
rtsp: gstrtspurl: gst_rtsp_url_get_request_uri: use rtsps scheme for tls transport methods
...
gst_rtsp_url_get_request_uri returns rtsp://... url when requested url is rtsps://, this is not
in accordance with https://www.rfc-editor.org/rfc/rfc7826.html#section-19.2 .
This also impedes setting up a rtsps session with a live555 rtsp server.
Don't expose other than rtsp and rtsps internal gstreamer rtsp url schemes
to avoid regression:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2412
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4298 >
2023-03-30 22:05:37 +00:00
Bart Van Severen
e8d7f326ff
Revert "rtsp: gstrtspurl: gst_rtsp_url_get_request_uri: fix incorrect scheme for tls transport methods"
...
This reverts commit 024ef7659d
because it causes a regression:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2412
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4298 >
2023-03-30 22:05:37 +00:00
Colin Kinloch
348cb2ed70
gtkwaylandsink: Destroy GstWlWindow when parent GtkWindow is destroyed
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4312 >
2023-03-30 19:40:10 +00:00