Edward Hervey
8b9b6ead3f
validate: Cast GList data content before usage
...
Apart from code readability, it allows compilers to detect wrong usages,
such as the call to gst_validate_action_new() which was using the wrong
argument
2017-07-19 11:02:44 +02:00
Thibault Saunier
f7252cbd48
validate: Remove some dead code
...
CID 1415457
2017-07-18 10:47:00 -04:00
Thibault Saunier
e70557dc3e
validate: Plug a minor string leak
...
CID 1415459
2017-07-18 10:45:29 -04:00
Thibault Saunier
9ee7b4483c
validate: Don't create scenario on a monitor which has no target
...
Not very probable but avoids a potential NULL pointer dereferencing.
CID 1415460
2017-07-18 10:42:00 -04:00
Thibault Saunier
6572af916b
validate: Always only use the first description in scenarios
...
Also pluging a leak of the descrption copied structure
CID 1415463
2017-07-18 10:38:24 -04:00
Thibault Saunier
c7483a90f0
validate: Plug a string leak
...
CID 1415475
2017-07-18 10:23:31 -04:00
Thibault Saunier
28f8787c17
validate: Add missing break statement
...
CID 1415485
2017-07-18 10:16:07 -04:00
Thibault Saunier
7eb9746adc
Check g_file_set_contents() return value
...
CID 1415486
2017-07-18 10:14:59 -04:00
Thibault Saunier
44260d70bd
validate: Plug leak of copy of a va_list
...
CID 1415490
2017-07-18 10:12:07 -04:00
Thibault Saunier
11ef28f3dc
validate: Do not check NULL pointer uselessly
...
CID 141593
2017-07-18 10:10:06 -04:00
Thibault Saunier
fc49d18425
validate: Plug minor leak in issue creation error path
...
CID 1415494
2017-07-18 10:10:06 -04:00
Thibault Saunier
54e35bb082
validate: Remove some dead code
...
Next will never be NULL as `done` is always set to TRUE when next is
set.
CID 1415503
2017-07-18 10:00:03 -04:00
Thibault Saunier
5c537bd627
validate: monitor: Add missing break; statement
...
Fixes CID 1415500
2017-07-18 09:59:42 -04:00
Edward Hervey
4f1242968e
validate-scenario: Fix wrong return value
...
We were always returning ok ...
CID #1415484
2017-07-18 15:50:35 +02:00
Edward Hervey
3904f2523b
validate-scenario: Check g_file_set_contents() return value
...
CID #1415487
2017-07-18 15:48:01 +02:00
Edward Hervey
e6073a411c
validate-scenario: Fix copy/paste error
...
CID #1415502
2017-07-18 15:45:13 +02:00
Edward Hervey
e5903f1d05
validate-scenario: Fix string usage
...
Use the string representation of the index if it *IS* present (and
not the opposite).
CID #1415506
2017-07-18 15:43:26 +02:00
Edward Hervey
5b54127c5a
validate-utils: Add NULL check
...
Unlikely to be triggered. And fix typo at the same time
CID #1415464
2017-07-18 15:38:04 +02:00
Thibault Saunier
c1f613d8e7
validate:scenario: Allow setting properties by element factory name
2017-06-30 12:30:40 -04:00
Thibault Saunier
f2fc6a4550
validate:scenario: Enhance the set_property action to handle enum props
...
User needs to specify the enum value as a string, to be used
as with gst_util_set_object_arg.
Also enhance reporting and verify that the set value has actually
been taken into account.
2017-06-30 09:46:57 -04:00
Thibault Saunier
dbc598b378
validate: Use Gst printing utils in our reporting system
...
Allowing us to use GST_PTR_FORMAT and friends!
2017-06-30 09:45:02 -04:00
Thibault Saunier
6a8b0111cd
validate:scenario: Enhance playbin3 stream selection error message
2017-06-22 11:52:26 -04:00
Thibault Saunier
eac403f87c
validate: Add missing space in segment mismatch issue description
2017-06-20 15:51:27 -04:00
Thibault Saunier
a728a7df49
validate: Fix the way we check if _CONFIG is a list of structures
2017-06-16 17:36:34 -04:00
Thibault Saunier
6439494f40
validate: overrides: Add a hook about newly added elements in a bin
2017-06-16 17:36:34 -04:00
Thibault Saunier
e0484a7cdd
validate: Attach overrides before calling monitor.setup()
2017-06-16 17:36:34 -04:00
Thibault Saunier
237a976d07
validate: Add a way to use config actions in GST_VALIDATE_CONFIG files
...
The synthax is:
core, action=action-name, param1=1, param2=param2
2017-06-07 11:17:53 -04:00
Thibault Saunier
8d251f12d9
scenario: Fallback to using media_info to determine stream duration
...
In the case the query duration return CLOCK_TIME_NONE.
2017-06-07 11:17:53 -04:00
Thibault Saunier
b9774b14b5
validate: Do not print \r in actual files
2017-06-07 11:17:53 -04:00
Thibault Saunier
3c62c315a9
validate: Implement RTSP support
2017-06-07 11:17:53 -04:00
Reynaldo H. Verdejo Pinochet
a18cef9c3f
validate: reporter: add doc entry for gst_validate_report()'s varargs
...
Avoids GTK-Doc parser warnings
2017-06-07 00:04:34 -07:00
Reynaldo H. Verdejo Pinochet
4349e11cb0
validate: scenario: fix typo/grammar issues in function documentation
2017-06-07 00:04:34 -07:00
Reynaldo H. Verdejo Pinochet
018ca98fd9
validate: actions: drop needless newline before feature-rank and wait
...
Stale new-lines messed the help output of gst-validate -t
2017-06-07 00:02:54 -07:00
Reynaldo H. Verdejo Pinochet
7f396ec660
validate: actions: add info on mandatory fields for set-property
...
Additionally, drop a comment that becomes redundant after adding this
info to the action description
2017-06-06 23:04:52 -07:00
Reynaldo H. Verdejo Pinochet
89fff02bb3
validate: scenario: fix description for 'seek' and 'stop'
2017-06-06 23:04:28 -07:00
Reynaldo H. Verdejo Pinochet
4b57c0bbb4
validate: fix documentation for gst_validate_init()
2017-06-06 18:50:47 -07:00
Thibault Saunier
9d3b760cf3
validate: Make Reporter.runner a MT safe weak reference
...
It can be used in any thread!
2017-06-01 16:57:50 -04:00
Thibault Saunier
e27367f040
validate: Fix json serialized object leaks
2017-06-01 16:57:50 -04:00
Thibault Saunier
86e9135b56
validate: Use GWeakRefs on monitor target and pipeline
...
Making it thread safe and more future proof (though having them point
to NULL might not be handled all around).
https://bugzilla.gnome.org/show_bug.cgi?id=782784
2017-06-01 16:57:50 -04:00
Thibault Saunier
8cc1b39919
validate: monitor: Unref our weak reference to the pipeline
2017-05-31 14:53:05 -04:00
Thibault Saunier
8f123cbc6f
validate: Make accessing Scenario.pipeline thread safe
...
The fact that Scenario.pipeline was not accessible in a thread way lead
to the fact that all users had to take the unref the last pipeline ref
in the main thread, otherwise we were crying. This was an ugly
restriction which lead to issue when using scenario on gst-rtsp-server.
This break the API as this commit remove the GstValidateScenario.pipeline
field but it is worth it.
2017-05-31 14:53:05 -04:00
Víctor Manuel Jáquez Leal
29480d006c
validate: g_object_newv() is deprecated
...
Since glib version 2.54, g_object_newv() is deprecated.
This patch changes that function with a simpler g_object_new(),
since no properties are set.
https://bugzilla.gnome.org/show_bug.cgi?id=782860
2017-05-20 12:40:26 +02:00
Edward Hervey
a4b16d54a0
validate-report: Don't leak GError
2017-05-05 15:27:37 +02:00
Edward Hervey
506e537f82
validate-scenario: Don't end up with invalid action name
...
When replacing an action structure, also update the action name with
the (new) name from the new structure. Otherwise we end up with
a bogus name from the previous (deleted) structure.
2017-05-05 15:27:37 +02:00
Edward Hervey
790e78c4f8
validate-scenario: Avoid invalid memory access
...
The name of the action comes directly (i.e. not copied) from the
contained GstStructure field. Therefore make sure to take that
name from the proper structure field (copied just before) and
not from an outside one.
2017-05-05 14:43:25 +02:00
Reynaldo H. Verdejo Pinochet
9d33d0ec9c
validate: drop unneeded break+concat in some string literals
...
Perform other related improvements while at it.
2017-04-12 10:31:21 -07:00
Thibault Saunier
26b388c349
validate: Do not expect track switch to be synchronous for playbin3
...
And let following actions to be executed (setting the action as
INTERLACED) which will make sure the track switch happened at some
point. It means the user has to set the pipeline to PLAYING so we can
make it works but we do not have choice here I think
https://bugzilla.gnome.org/show_bug.cgi?id=781213
2017-04-12 11:28:50 -03:00
Edward Hervey
1f5a900bce
validate-pad-monitor: Fix previous commit
...
Post-send handling was only meant for seek events
2017-04-10 11:43:28 +02:00
Edward Hervey
b156616b5c
pad-monitor: Safely store expected seek values
...
Protect the expected seek values with the same lock as the one
that will be used to read/validate the resulting segments and flush
values.
Avoids races with duplicated seeks (i.e. a seek that was already
sent and handled via another pad, such as in demuxers).
https://bugzilla.gnome.org/show_bug.cgi?id=781112
2017-04-10 09:15:50 +02:00
Reynaldo H. Verdejo Pinochet
22d99ac89c
validate: scenario: fix error message on scenario parsing failure
2017-04-05 15:26:31 -07:00