Commit graph

63 commits

Author SHA1 Message Date
Sebastian Dröge
1bf4edf721 omx: Don't handle FLUSHING and NOT_LINKED as errors
Also don't stop the task on NOT_LINKED. We're not a demuxer.
2014-01-25 17:44:57 +01:00
Josep Torra
f3f9330332 omx: Take lock on EOS to update the flow return value
Fixes "GThread-ERROR **: file gthread-posix.c: line 171
(g_mutex_free_posix_impl): error 'Device or resource busy' during
'pthread_mutex_destroy ((pthread_mutex_t *) mutex)'" in _finalize.
2013-05-20 12:06:34 +02:00
jitendra
715b44ea66 omx: Add pads based on element type
This allows to later add sources and sink that only have a srcpad
or sinkpad.

https://bugzilla.gnome.org/show_bug.cgi?id=699754
2013-05-06 16:20:20 +02:00
Tim-Philipp Müller
2cbbab3128 omx: more printf format fixes
Fix printf formats again, so that gst-omx compiles warning-
free on the Raspberry Pi as well. Unfortunately OMX_UINT32
maybe be typedefed to uint32_t or unsigned long, which
doesn't work well with our debugging printf format strings,
so just use %u for those and cast to guint.
2013-04-18 23:10:13 +01:00
jitendra
960590f92f omx: Disable output port before transition to idle state
https://bugzilla.gnome.org/show_bug.cgi?id=698109
2013-04-16 12:46:48 +02:00
Tim-Philipp Müller
0c08d375f4 omx: fix printf formats in debug messages
OMX_U32 is typedefed to an unsigned long,
OMX_TICKS to a 64-bit integer.
2013-04-08 17:02:32 +01:00
Josep Torra
a5778efe16 omx: Clarify that loop task is also paused in EOS 2013-03-16 10:00:24 +01:00
Sebastian Dröge
e1f94660f7 omx: Stop output port task after draining 2013-03-15 11:46:34 +01:00
Sebastian Dröge
22dce51dd4 omx: Handle the OMX_EventBufferFlag to detect EOS too 2013-03-14 12:51:54 +01:00
Sebastian Dröge
8bf902b69d omxaudioenc: Disable output port when setting a new format 2013-03-11 10:29:44 +01:00
Sebastian Dröge
65174bbd7f omx: Catch errors when releasing buffers to a port and handle them 2013-03-11 10:04:10 +01:00
Josep Torra
bd071327da omx: Fix deadlock in encoders and add explainatory comments. 2013-03-09 14:14:40 +01:00
Sebastian Dröge
c014b1c9a3 omx: Flush and stop srcpad when configuring new caps 2013-03-08 15:50:20 +01:00
Sebastian Dröge
7a1eaec3b9 omx: Add timeout to the flush operation and move buffer populating to a separate function 2013-03-07 13:57:00 +01:00
Sebastian Dröge
60861f3990 omx: Do number of buffers configuration explicitely 2013-03-07 13:56:44 +01:00
Sebastian Dröge
d92fb127ae omxaudioenc: Only enable the output port after we know the output format 2013-03-01 11:25:04 +01:00
Sebastian Dröge
aeec430261 omx: Return the OMX_ERRORTYPE from gst_omx_port_update_port_definition 2013-02-28 15:49:14 +01:00
Sebastian Dröge
1a906da409 omx: Add API for allocating a specific number of buffers and using EGLImages or buffers allocated elsewhere 2013-02-28 11:20:52 +01:00
Sebastian Dröge
e42faae652 omx: Refactor code flow a bit if output port settings have changed 2013-02-27 16:56:02 +01:00
Sebastian Dröge
b12610efd7 omx: Clean up port settings change handling 2013-02-27 15:50:20 +01:00
Sebastian Dröge
5b45cb0810 omx: Auto-detect the port indizes if possible 2013-02-25 12:42:05 +01:00
Sebastian Dröge
70368c31cd omx: Refactor waiting for buffers to be released by the component to a separate function 2013-02-25 10:41:12 +01:00
Sebastian Dröge
fa9bf95c40 omxaudioenc: Rename component variable 2013-02-25 09:19:08 +01:00
Sebastian Dröge
219a93bbaf omx: Some minor refactoring and cleanup 2013-02-12 11:49:21 +01:00
Sebastian Dröge
c3bcc43db7 omx: Split enabling/disabling of port into sending the command and waiting for it
This allows to do anything necessary after sending the command to actually let it finish
2013-02-12 11:41:43 +01:00
Sebastian Dröge
be31e7273b omx: Fix some memory leaks and suboptimal locking 2013-01-14 10:36:57 +01:00
Sebastian Dröge
a42f27547d omx: Implement new approach for locking that should solve all deadlocks on RPi
No mutex is locked while calling any OpenMAX functions anymore
and everything from the OpenMAX callbacks is inserted into a message
queue and handled from outside the callbacks.

Also there's only a single mutex and condition variable per component
now for handling anything from OpenMAX callbacks and a single mutex
for keeping our component/port state sane.
2013-01-14 10:36:32 +01:00
Sebastian Dröge
1d01c0ebf0 omx: Fix ununsed variable compiler warning 2012-12-20 12:30:05 +01:00
Sebastian Dröge
83b4c1d892 omx: No need to start the srcpad task in ::start() already
It will be started properly after the caps are set.
2012-12-20 12:27:47 +01:00
Sebastian Dröge
f90a6ed9e9 omx: Improve debug output 2012-12-20 12:20:31 +01:00
Sebastian Dröge
2481ceb8c4 omx: Update to new GLib thread API 2012-11-12 11:29:48 +01:00
Sebastian Dröge
e84fee6488 omx: Fix compilation after gst_pad_start_task() API changes 2012-06-20 11:09:13 +01:00
George Kiagiadakis
158775f497 Implement a new custom recursive mutex type and fix locking in callbacks so that in-context calls are allowed.
According to the OMX specification, implementations are allowed to call
callbacks in the context of their function calls. However, our callbacks
take locks and this causes deadlocks if the unerlying OMX implementation
uses this kind of in-context calls.

A solution to the problem would be a recursive mutex. However, a normal
recursive mutex does not fix the problem because it is not guaranteed
that the callbacks are called from the same thread. What we see in Broadcom's
implementation for example is:

- OMX_Foo is called
- OMX_Foo waits on a condition
- A callback is executed in a different thread
- When the callback returns, its calling function
  signals the condition that OMX_Foo waits on
- OMX_Foo wakes up and returns

The solution I came up with here is to take a second lock inside the callback,
but only if recursion is expected to happen. Therefore, all calls to OMX
functions are guarded by calls to gst_omx_rec_mutex_begin_recursion() / _end_recursion(),
which effectively tells the mutex that at this point we want to allow calls
to _recursive_lock() to succeed, although we are still holding the master lock.
2012-05-07 17:01:16 +03:00
Sebastian Dröge
3523724970 omxaudioenc: Use gst_buffer_extract() to copy the input buffer data to the OpenMAX buffer 2012-04-16 08:35:33 +02:00
Olivier Crête
ff2603a727 Port to Gst 0.11 2012-04-13 12:16:34 -04:00
Jonas Larsson
887d43c290 omxaudioenc: Add hack for encoder components that don't allow empty EOS buffers 2011-12-14 10:09:34 +01:00
Sebastian Dröge
766f5bd161 omxaudioenc: Don't forward EOS events immediately but let all other events be handled by the base class
Previously this logic was inversed, which did not make any sense at all.
2011-12-06 13:28:41 +01:00
Sebastian Dröge
064e4c628c omxaudioenc: Use correct timestamp, duration and filled length for the EOS buffers 2011-12-06 12:47:25 +01:00
Sebastian Dröge
217ac7b3be omxaudioenc: Use audio base classes from gst-plugins-base instead of having our own copies 2011-11-25 11:31:58 +01:00
Sebastian Dröge
9917fbe4c5 omxaudioenc: First set ports to flushing before waiting for the srcpad streaming thread to finish 2011-11-18 10:00:31 -08:00
Sebastian Dröge
8a5fbb876c omxaudioenc: Signal the drain GCond even if downstream returned an error 2011-11-17 11:29:39 -08:00
Sebastian Dröge
7df465bfb3 omxaudioenc: Shutdown component in PAUSED->READY and deallocate buffers 2011-11-17 10:19:47 -08:00
Sebastian Dröge
1ab4e4b945 omxaudioenc: Make srcpad caps setting threadsafe 2011-11-10 15:18:08 +01:00
Sebastian Dröge
f0775fac6f omxaudioenc: Make the srcpad task and the sinkpad streaming thread handling threadsafe 2011-11-10 15:10:14 +01:00
Sebastian Dröge
b62ffe1ada omxaudioenc: Always flush the ports and make sure no processing is happening in ::flush
This fixes a race condition that happened when seeking
very often in a short period of time.
2011-11-10 15:03:05 +01:00
Sebastian Dröge
05e4b48855 omxaudioenc: Improve EOS handling
If downstream return UNEXPECTED we should still signal the
drain cond because nothing will trigger this again later.
2011-11-10 14:56:19 +01:00
Sebastian Dröge
1b7742ca98 omxaudioenc: Improve debugging of EOS and draining 2011-11-10 14:54:33 +01:00
Sebastian Dröge
8c1aee4171 omxaudioenc: No need to signal the drain cond when going from READY to PAUSED
Also the component is not started in READY
2011-11-10 14:41:50 +01:00
Sebastian Dröge
b45197c0d7 omxaudioenc: Release the audio encoder stream lock before acquiring an input buffer
Otherwise the srcpad task might block on this lock and
no buffers ever become available again.
2011-11-08 12:47:00 +01:00
Sebastian Dröge
17d0751887 omxaudioenc: Don't try to drain the component after EOS
And don't send EOS twice in any case. This most likely
will cause the component to not output it again and
is not necessary anyway.
2011-11-08 11:10:57 +01:00