Commit graph

49 commits

Author SHA1 Message Date
Edward Hervey
6b9e2628b7 jpegparse: Fix unitialized variable on macosx 2011-01-06 12:51:27 +01:00
Sebastian Dröge
1f8ba27334 jifmux: Don't leak taglist 2010-12-19 12:00:25 +01:00
Mark Nauwelaerts
aae382bcc6 jpegparse: avoid leaking tag event 2010-12-13 16:25:29 +01:00
Mark Nauwelaerts
2056f4a633 jpegparse: avoid leaking converted comment string 2010-12-12 22:14:59 +01:00
Mark Nauwelaerts
74fb627a08 jpegparse: try to convert comment tag to UTF-8 2010-12-08 16:30:11 +01:00
Mark Nauwelaerts
49d7f207cb jpegparse: discard incomplete image
... as determined when finding SOI next image before an EOI.
2010-12-08 16:30:11 +01:00
Mark Nauwelaerts
0a26e138dd jpegparse: avoid infinite loop when resyncing 2010-12-08 16:30:11 +01:00
Thiago Santos
7622328aab jpegparse: Small optimization on tags parsing
Optimize a little avoiding copying a taglist when parsing xmp/exif
data.
2010-11-22 17:43:53 -03:00
Arun Raghavan
8ca66f336e jpegformat: Push tags after setting srcpad caps
This patch defers emission of tag events till caps are set on the source
pad of jpegparse, so that these tags can be seen downstream.

https://bugzilla.gnome.org/show_bug.cgi?id=627211
2010-11-19 14:57:59 -03:00
Víctor Manuel Jáquez Leal
e5728ebcb1 jpegparse: add gst_jpeg_parse_skip_marker ()
https://bugzilla.gnome.org/show_bug.cgi?id=626618
2010-11-19 16:30:18 +02:00
Víctor Manuel Jáquez Leal
285c32e01f jpegparse: use byte reader accessors
https://bugzilla.gnome.org/show_bug.cgi?id=626618
2010-11-19 16:27:24 +02:00
Víctor Manuel Jáquez Leal
e11fdf67f0 jpegparse: inline gst_jpeg_parse_sof ()
No functional changes (hopefully).

https://bugzilla.gnome.org/show_bug.cgi?id=626618
2010-11-19 16:25:39 +02:00
Víctor Manuel Jáquez Leal
d0dc44db02 jpegparse: fix typo
https://bugzilla.gnome.org/show_bug.cgi?id=626618
2010-11-19 16:25:35 +02:00
Thiago Santos
3a9734f3dc jifmux: Reset tags when going to READY
Reset the tagsetter tags when going to READY state
2010-09-10 13:39:06 -03:00
Thiago Santos
2a0ae1ce1d jpegformat: Fix element description
Use saner categories for jifmux/jpegparse elements
2010-09-10 13:39:06 -03:00
Thiago Santos
69151f6850 jifmux: Make it more colorspace smart
This makes it able to recombine rgb images, making it possible
to add tags to rgb jpegs as well.

Uses a simple strategy to check what are the possible colorspaces
and avoid adding jfif to ones that aren't YUV/Gray.
2010-09-07 14:45:12 -03:00
Thiago Santos
27333b0ef2 jifmux: Do not limit the size of the image on 16bits
Use guint instead of guint16 to represent the size of the encoded image,
this would make some recombined images lose most of their data and
show like a big black image with a small line of content on top.

Also adds a minor log message.
2010-09-05 09:15:55 -03:00
Thiago Santos
f664fd9c04 jifmux: Set output pad caps
Set output pad caps to guarantee caps on the buffers being
pushed downstream.
2010-09-05 09:15:55 -03:00
Thiago Santos
d49acb5588 jifmux: Detect EOI correctly
EOI are not always at the last 4 bytes. We need to search
the last 5 bytes to find the 0xFFD9 sequence as jpegenc seems
to round the buffer size to the next 4 multiple.
2010-09-05 09:15:55 -03:00
Thiago Santos
ba15ad9387 jifmux: Put APP0 first always
Fixes the order of the APP0/APP1 markers. APP0 should
be first.
2010-09-05 09:15:55 -03:00
Thiago Santos
407f615887 jifmux: Avoid recombining RGB jpegs
JFIF only allows YUV as colorspace, when we receive an RGB jpeg,
we should just push it forward without adding the JFIF marker.

Fixes #627413
2010-08-21 21:08:13 +02:00
Víctor Manuel Jáquez Leal
1d57953496 jpegparse: fix exif frame size
Skip the correct number of bytes when reading exif
data

Fixes #623854
2010-07-08 14:27:45 -03:00
Mark Nauwelaerts
3a1d0b7a0f jpegparse: fix skipping extra 0xff markers
In particular, this makes the jpegparse unit test pass again.
Also add a debug statement.

Fixes #622690.
2010-07-05 11:54:25 +02:00
Tim-Philipp Müller
144d43bcef assrender, ivfparse, jpegformat: fix compiler warnings with debugging disabled in core 2010-06-27 11:25:20 +01:00
Mark Nauwelaerts
7601bc306a jpegparse: handle FLUSH_STOP sink event 2010-06-14 15:48:34 +02:00
Mark Nauwelaerts
e6cf05b114 jpegparse: optimize image parsing
Use adapter API for scanning and peeking to reduce buffer copying.

See #583047.
2010-06-14 15:48:34 +02:00
Thiago Santos
00897e21a9 jpegformat: Add exif support
Adds exif writing support to jifmux.
Adds parsing support to jpegparse.

Fixes #614872
2010-06-09 17:29:32 -03:00
Stefan Kost
418a791868 jpegformat: make the intention of the elements more clear 2010-05-07 22:53:17 +03:00
Thiago Santos
20a8666388 Revert "jifmux: Merge xmp and tagsetter tags."
This reverts commit 4e5c412234.

jifmux shouldn't be able to handle jif and shouldn't expect
any xmp on its data. So, no need to handle them.
2010-05-07 14:00:03 -03:00
Thiago Santos
4e5c412234 jifmux: Merge xmp and tagsetter tags.
When the current file already has tags, they shouldn't be ignored,
parse them and merge with the tagsetter ones.
2010-05-07 12:42:23 -03:00
Thiago Santos
a9e4c64efa jifmux: Reject buffers without caps
jifmux expects whole jpeg pictures in buffers, so it should
reject buffers without caps.
2010-05-07 11:07:34 -03:00
Thiago Santos
72fdd708cf jifmux: Be safe and check bytewriter returns
Check GstByteWriter returns to know when recombining the image
failed and log a warning.
2010-05-07 10:59:22 -03:00
Thiago Santos
0d637e4f09 jifmux: Avoid adding 2 xmp packets
jifmux was only appending a new xmp packet to the stream,
it should replace if there is already one.
2010-05-07 10:13:54 -03:00
Mark Nauwelaerts
d68a4c1dcc jpegparse: improve buffer scanning
Specifically, when scanning for entropy data segment length and needing
more data, do not rescan from start next time around, but resume at
last position.

See also #583047.
2010-04-30 19:53:57 +02:00
Stefan Kost
4a87fee780 jpegformat: add blank line to fix generated xml 2010-03-24 16:25:43 +02:00
Benjamin Otte
b7655bbd2e Add -Wredundant-decls flag
and fix warnings from it
2010-03-22 12:05:59 +01:00
Edward Hervey
69a40a1591 jpegparse: Fix unitialized variable on macosx 10.5 2010-03-12 09:52:57 +01:00
Stefan Kost
3b78cc5eca jpegformat: add xmp reading and writing support
Bump needed base version for new xmp helper library. Use xmp helpers in
jpegparse and jifmux.
2010-03-12 10:35:15 +02:00
Edward Hervey
5050967766 jpegformat: Fix unitialized variables 2010-03-11 17:58:25 +01:00
Stefan Kost
caf2be2115 jpegparse: return offset+length from _get_image_length().
_find_end_marker() find the position of the marker. EOI has a fixed length of 2
bytes that where missing. Fixes #608998
2010-02-17 13:12:00 +02:00
Tim-Philipp Müller
3e45e6ba9f jpegparse: fix invalid memory access
See bug #608998.
2010-02-17 01:32:12 +00:00
Tim-Philipp Müller
a60d54c4e2 jpegparse: lower rank to NONE so it is not autoplugged for decoding
This element is too new and too untested to have it autoplugged.
2010-02-07 10:19:06 +01:00
Stefan Kost
6c6ea0b79b jpegformat: add a basic jifmuxer
The new element can chop and reassemble the markers. I implements the tagsetter
and for now can serialize some tags to jpeg comments.
2010-02-03 15:13:30 +02:00
Stefan Kost
b9f8f5d281 jpegparse: improve parsing
Handle more app maker. Print app marker names to debug log. Remember last_marker
when parsing to avoid reparsing from the very begin.
2010-02-02 17:19:31 +02:00
Stefan Kost
f3122f2b30 jpegparse: provide a getcaps function for src pad and improve setcaps
Previously jpegparse was failing in decodebin as the caps we were setting where not
setting all caps fields. We need the own getcaps function to report what we actualy
accept.
2010-02-01 17:46:29 +02:00
Stefan Kost
ab7e974dab jpegparse: extract comment and post as metadata 2010-02-01 17:16:16 +02:00
Stefan Kost
e1dd998bd0 jpegformat: code cleanups
Move the jpeg marker defines to a header (to be used for jifmux). Rewrite some
comments. Use gst_element_class_set_details_simple(). Add more logging.
2010-02-01 17:15:38 +02:00
Stefan Kost
8bd0f42017 jpegformat: move plugin part to speparate file, so that we can add the jifmux 2010-01-29 12:25:08 +02:00
Arnout Vandecappelle
bb5331e272 jpegparse: new jpeg parser element. FIxes #583098
Parse JPEG images, extracts its metadata, set caps and
packetize an image per buffer.
2010-01-29 11:41:15 +02:00