Sebastian Dröge
04a5eee15e
mxfmux: Remove some dead code that could never be called
...
Coverity CIDs #1328818 , #1328819 , #1328820 .
2015-10-27 16:32:48 +02:00
Sebastian Dröge
4cdc83fe5d
mxfmux: Remove empty set/get_property()
...
We can add them again if we ever add properties.
2015-10-23 18:58:41 +03:00
Sebastian Dröge
d6a5e4ff16
mxfmux: Port to GstAggregator
2015-10-23 18:58:15 +03:00
Sebastian Dröge
8b3953b887
mxfmux: Set GC essence element UL version to 0x01
...
ffmpeg otherwise rejects it and the spec is not 100% clear about that.
2015-10-23 16:38:22 +03:00
Sebastian Dröge
cb5c1e8fd4
mxf: Reorder CFLAGS and LIBS
2015-10-23 16:31:49 +03:00
Sebastian Dröge
0b48144f07
mxfmux: Set KAG size to 1
...
We're not aligning our output in any way, and 0 is invalid.
2015-10-21 19:54:15 +03:00
Sebastian Dröge
8b15b609d2
mxfmux: Don't let the header partition's prev_partition point forward to the footer
2015-10-21 19:54:15 +03:00
Sebastian Dröge
a1e240ca6b
mxftypes: Fix generation of operational pattern UL
2015-10-21 19:54:15 +03:00
Sebastian Dröge
f11a3ccf9d
mxfmpeg: h264 is always byte-stream inside MXF
2015-10-21 19:54:15 +03:00
Sebastian Dröge
d571b4f8fa
mxfmux: Don't leak SEEK events when dropping them
2015-10-21 19:54:15 +03:00
Sebastian Dröge
770d94f4b5
mxfvc3: The wrapping is the 15th byte of the essence container UL, not the 16th
...
In other mappings it is the 16th though.
2015-10-21 19:54:15 +03:00
Sebastian Dröge
41982e6ccf
mxfdemux: If seeking to the remaining parts of the file fails on EOS, consider the stream done
...
Without this we would run this while loop forever, always seeking again for
the same stream.
2015-10-21 19:54:15 +03:00
Sebastian Dröge
9af6a1a617
mxf: Re-enable mxfmux element
2015-10-21 19:54:15 +03:00
Sebastian Dröge
d388655756
mxfjpeg2000: Fix caps
...
There is no fields field anymore.
2015-10-21 19:54:15 +03:00
Sebastian Dröge
9c9dd9d369
mxfmux: Don't fail SEGMENT events
2015-10-21 19:54:15 +03:00
Sebastian Dröge
38e75d93dc
mxfmux: Push stream-start and caps event before segment event
...
And don't push the caps event during instance initialization already.
2015-10-21 19:54:15 +03:00
Sebastian Dröge
5d7367ef47
mxfaes-bwf: Format is unsigned if it's 1 byte per channel
...
... not 1 byte per block.
2015-10-21 19:54:15 +03:00
Luis de Bethencourt
8899efae60
Update references to decodebin
...
Update old references for decodebin2 to decodebin.
2015-05-08 13:54:08 +01:00
Guillaume Desmottes
da113b5ad7
mxf: fix descriptor leak
...
Free the existing descriptor array, if any, before replacing it.
Fix leaks with the
validate.file.playback.scrub_forward_seeking.test-mpeg2-mp3_mxf scenario.
https://bugzilla.gnome.org/show_bug.cgi?id=748580
2015-04-28 11:53:52 -03:00
Tim-Philipp Müller
699452ef31
Remove obsolete Android build cruft
...
This is not needed any longer.
2015-04-26 18:59:32 +01:00
Guillaume Desmottes
4d790dae67
mxfdemux: fix memory leak
...
Reset the internal segment before freeing it.
mxf_index_table_segment_parse() allocates data inside the segment
(like segment->delta_entries) which have to be freed using
mxf_index_table_segment_reset().
https://bugzilla.gnome.org/show_bug.cgi?id=746803
2015-04-04 19:47:40 +01:00
Mark Nauwelaerts
32e87b1024
mxfdemux: resurrect some flow return handling
...
https://bugzilla.gnome.org/show_bug.cgi?id=744572
2015-03-28 18:22:29 +01:00
Jan Schmidt
f150cf2d2e
Remove a bunch of silly ';;' typos at the end of lines
2015-03-12 01:33:03 +11:00
Luis de Bethencourt
9909d1f770
mxfdemux: remove unneeded values
...
No need to store the GstFlowReturn when we can check if it is not OK directly
2015-02-18 19:27:46 +00:00
Luis de Bethencourt
4d43472c2b
mxfdemux: renaming GstFlowReturn variable
...
Having a variable named ret in a static void function is very confusing since
this usually is to store what the function will return.
2015-02-18 19:26:43 +00:00
Luis de Bethencourt
b7e0c7a163
mxfdemux: remove ignored value
...
Value stored in ret will be ovewritten in the next iteration of the loop. Which
means it is never used.
Plus a style issue to make gst-indent happy and allow the commit.
2015-02-18 18:00:54 +00:00
Mathieu Duponchelle
631663b854
mxfdemux: Use IndexTableSegments.
...
This speeds up seeking drastically.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=732294
2014-12-14 12:53:55 +01:00
Vineeth T M
14acb6fb37
gst: remove unnecessary GLIB_DISABLE_DEPRECATION_WARNINGS
...
There are unnecessary definitions for disabling deprecation warnings.
Since GLIB_DISABLE_DEPRECATION_WARNINGS is not needed anymore in these files,
removing the same.
https://bugzilla.gnome.org/show_bug.cgi?id=737559
2014-10-02 10:51:35 +03:00
Sebastian Rasmussen
e79e96e59d
mxfmux: Avoid taking unnecessary ref
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=733123
2014-07-16 16:47:21 +02:00
Thiago Santos
b8d87c11ab
mxfdemux: remove unread last_flow variable
...
it isn't necessary anymore and is already unused
2014-05-27 07:42:46 -03:00
Sebastian Dröge
a3489ffa83
mxfdemux: Compare positions to find the earliest pad, not flow returns
2014-05-27 12:24:43 +02:00
Thiago Santos
ae839d8dc2
mxfdemux: use GstFlowCombiner
...
Removes flow return combination code to use the newly added GstFlowCombiner
https://bugzilla.gnome.org/show_bug.cgi?id=709224
2014-05-26 23:29:43 -03:00
Tim-Philipp Müller
f8d63c5ad9
mxfdemux: post error message when erroring out on unsupported essence wrapping
2014-05-14 00:25:09 +01:00
Vincent Penquerc'h
60d7e45cab
mxf: fix MP2 case
...
Testing mpegversion when mpegaudioversion was likely meant.
Similar tests in sys/androidmedia/gstamcaudiodec.c also test
mpegaudioversion with the same conditional code.
Coverity 206071
2014-04-21 13:23:46 +01:00
Vincent Penquerc'h
d111287995
mxfmux: guard against dividing by 0
...
Use a placeholder value in that case, it's better than crashing.
Coverity 1139697
2014-04-21 13:23:46 +01:00
Vincent Penquerc'h
52981d5a4a
mxfdemux: guard against NULL non source components
...
This component is dereferenced, and later code checking for
NULL in particular cases implies it can be NULL. This likely
does not fix the coverity warning as it was seeing another
path setting component to NULL explicitely, but this was
spotted by looking at:
Coverity 1139736
Which is actually OK from what I can see since the actual
dereference of the explicit NULL pointer will not happen
if the condition that led to the NULL pointer assignment
is met, since the assignment and defeference have mutually
exclusive tests.
2014-04-21 09:24:00 +01:00
Edward Hervey
3d6265a9f5
mxfdemux: Fix copy/paste error
...
We want to check whether the rate is different. We check changes in
numerator *and* denominator.
CID #1139631
CID #1139642
2014-04-16 16:25:29 +02:00
Edward Hervey
be859d02a6
mxf: Handle fraction parsing failure
...
And properly cleanup/reset the segment before returning on errors
CID #206012
2014-04-16 16:19:47 +02:00
Edward Hervey
fa72b4c870
mxf: Remove useless check
...
a guint will always smaller or equal to the maximum value it can
contain
CID #206049
2014-04-16 16:12:02 +02:00
Vincent Penquerc'h
172c398127
mxf: avoid dereferencing NULL mapping data pointer
...
Also unref buffers on error, as it seems to be done in one, but
not all, error paths.
The NULL pointer part is Coverity 206112
https://bugzilla.gnome.org/show_bug.cgi?id=727889
2014-04-16 16:08:38 +02:00
Tim-Philipp Müller
39dc1f0ebb
mxfdemux: guard against NULL material track
...
Just to be on the safe side.
2014-04-08 16:53:41 +01:00
Tim-Philipp Müller
6e764e5b11
mxfdemux: implement simple KEY_UNIT seeking
...
If a KEY_UNIT seek was requested, adjust segment
start to position of the key frame.
2014-04-08 14:37:34 +01:00
Tim-Philipp Müller
4898a51afe
mxfdemux: fix seeking, send data starting from a key unit
...
Fixes multiple seeking issues. When doing ACCURATE or normal
non-KEYUNIT seeks, mxfdemux would just send data from the
edit unit that covered the seek position, whether that's
a keyframe or not. Decoders would only output things from
the next keyframe then, which means there's a gap between
the start of the segment and the first decoded data in
some cases. In combination with gst-editing-services this
might result in a frozen picture for the duration of that
gap at the beginning (if videorate fixes up the first
buffer's start timestamp to cover the entire gap), or
a black frame (if no videorate is used and videomixer
fills the gap). Also fixes A/V sync issue when requesting
a KEYUNIT seek.
2014-04-08 13:26:49 +01:00
Vincent Penquerc'h
8e580ea6f1
mxf: fix stop date parsing using the wrong input
...
Coverity 1139645
2014-04-07 13:54:50 +01:00
Sjoerd Simons
f6da7ea8bb
mxfdemux: Don't go into pull mode when the sequential flag is set
...
When the scheduling query results has GST_SCHEDULING_FLAG_SEQUENTIAL set
in its flags don't go into pull mode to prevent over-eager seeking.
https://bugzilla.gnome.org/show_bug.cgi?id=722934
2014-01-24 22:14:47 +01:00
Sebastian Dröge
6812f96de4
gst: Don't swap start/stop for negative rates in the SEGMENT query
2013-07-29 12:14:08 +02:00
Sebastian Dröge
6b78fa336d
mxfdemux: Implement SEGMENT query
2013-07-29 11:02:54 +02:00
Sebastian Dröge
46e85b4a6c
mxfdemux: Add support for group-id in the stream-start event
2013-07-23 10:33:31 +02:00
Sebastian Dröge
e51cd4fe2f
gst: Add better support for static plugins
2013-04-15 15:59:22 +02:00
Stefan Sauer
2991e1ed48
mfxdemus: update todo (ther eis a muxer)
2013-04-11 10:06:23 +02:00