Mathieu Duponchelle
1993229993
validate-runner: Implement REPORT_NONE for global reporting.
...
Yeah that was tough. Helpful already though, for example:
GST_VALIDATE_REPORT_LEVEL=none,x:all gst-validate src name=x ! sink
will only report issues reported by the source.
+ Add test.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
0a1cdb2164
tests: Check monitors correctly determine their reporting level.
...
+ [API] gst_validate_reporter_get_reporting_level
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
5cb60060dc
validate-runner / monitor: Let the user single out pads.
...
That's some pretty specific code but it should be helpful.
The following syntax can be used : element-name::pad-name.
+ Free return of gst_object_get_name.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
b21bb1ff34
validate-runner / reporter: Sanitize reports refcounting.
...
The previous code worked but was confusing, the runner didn't actually
take the ref it was releasing later.
+ Fix indentation.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
de554ba417
tests: Test reports refcounts.
...
+ Set the element monitor on the element as qdata.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
c943a75766
validate-monitor: Determine the reporting level at setup.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
1d7f15598f
validate-runner: Add code to parse GST_VALIDATE_REPORT_LEVEL.
...
+ Extend the tests.
+ [API] gst_validate_runner_get_default_reporting_level
+ [API] gst_validate_runner_get_reporting_level_for_name
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6ed125bfb1
validate-runner: report-level initial work.
...
+ Defines reporting levels and document them.
+ Add API to get the default level.
+ fix indentation.
+ fix some typos.
+ Add the beginning of a reporting test.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6e08079f8b
validate-pad-monitor: concatenate issues.
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=735665
The process is to check for a similar report in intercept_report on
the pads of the upstream element, set that report as the master report
of the intercepted report, and return REPORTER_KEEP instead
of REPORTER_REPORT.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
f001777cc6
validate-reporter: Add some methods
...
+ gst_validate_reporter_get_reports
+ gst_validate_reporter_get_reports_count
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
222a517384
validate-report: Add the notion of master / shadow reports.
...
A master report is a report that has been detected by a monitor
to stem from the same issue. It thus contains a list of
"shadow reports" which it will browse when printing itself.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
b8ac717297
validate-report: Make the ref / unref functions safer.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
3e557ca92b
validate-reporter: Add return value to intercept_report.
...
It will allow to drop, keep or report reports.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6104701268
validate-pad-monitor: Reimplement reporter interface.
...
+ Do nothing there for now, except chain up.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
fb90aa2ead
validate-reporter: add gst_validate_reporter_get_report.
...
+ Add locking.
2014-10-21 20:13:51 +02:00
Thibault Saunier
26ef55d622
validate: Print position if it could properly be queried
...
Otherwize we will print meaningless garbage.
2014-10-13 16:30:05 +02:00
Thibault Saunier
99045f7dbb
validate: Rename action type playback_time to playback-time
...
Keeping backward compatiblity with the old naming
2014-10-12 20:19:42 +02:00
Thibault Saunier
02ab99fcbb
validate: Rename gst_validate_add_action_type to gst_validate_register_action_type
...
The _register naming corresponds much better to what the method does
and makes it more similar to how we refer to this kind of action in
GStreamer.
It is a last minute API change, but that API should not change anymore
after 1.4 is released.
2014-10-12 20:10:19 +02:00
Thibault Saunier
9158bb36e3
validate: Fix the addition of playback_time in the parameter types
2014-10-12 20:00:03 +02:00
Thibault Saunier
ce87de95ea
validate: Add the 'flags' for the seek action type
...
This was always a mandatory field but was not documented
2014-10-12 19:16:08 +02:00
Anuj Jaiswal
83c0453d81
validate: mishandled pointer criticals
...
Free glist of criticals
Signed-off-by: Anuj Jaiswal <anuj.jaiswal@samsung.com>
https://bugzilla.gnome.org/show_bug.cgi?id=736313
2014-10-09 20:38:12 -03:00
Mathieu Duponchelle
8cfffb4a3a
validate-runner: switch to using a GList for the reports.
...
+ Return a copy of that list in get_reports.
+ update tests.
2014-09-30 11:42:42 +02:00
Mathieu Duponchelle
1f1cf83af8
validate-runner: Hide implementation.
2014-09-30 11:42:42 +02:00
Mathieu Duponchelle
855f141453
gst-validate-runner: Add locking for the reports list.
2014-09-30 11:42:42 +02:00
Anuj Jaiswal
c98f7e7b38
validate: (performance issue)refactor to remove duplicate assignment
...
Signed-off-by: Anuj Jaiswal <anuj.jaiswal@samsung.com>
https://bugzilla.gnome.org/show_bug.cgi?id=736412
2014-09-12 09:57:05 +02:00
Thibault Saunier
332a51d1f0
validate: Get the Runner reports in order of arrival
...
Making sure they are printed in the right order
2014-09-12 09:57:05 +02:00
Thibault Saunier
7e85c9b0b5
validate: Start a testsuite
...
Currently implemented tests are:
* Settup and cleanup on monitor is done properly
* Some tests in the PadMonitor are done properly, namely:
- Buffer before segment
- Buffer outside segment
- First buffer running time is always 0
- The Demuxer flow aggregation is properly checked
https://bugzilla.gnome.org/show_bug.cgi?id=736379
2014-09-12 09:57:05 +02:00
Edward Hervey
80de4392ce
validate/private: Avoid double typdef
...
Instead just include required (public and local) header
gst-validate-scenario.h:43:44: error: redefinition of typedef 'GstValidateActionParameter' is a C11 feature [-Werror,-Wtypedef-redefinition]
2014-09-12 09:49:35 +02:00
Thibault Saunier
3755581fd3
validate: Take a const gchar ** in gst_validate_print_action_types
...
This is what we actually need and thus is cleaner.
2014-09-05 23:15:29 +02:00
Thibault Saunier
69165a9f04
validate: Implement the notion of implementer namespace to the action types
...
This allows users to know who implements an action type.
+ Enhance the printing of all action making it readable.
2014-09-05 23:03:58 +02:00
Thibault Saunier
34fd5af840
validate: docs: Add some GstValidate usage documentation
...
+ Fix minor issues in the gst-validate and gst-validate-transcoding
tools documentation
2014-09-05 19:00:23 +02:00
Guillaume Desmottes
f7955f5249
validate: remove redundant pre-condition in monitor_factory_create
...
The same check is already done at the head of the function.
https://bugzilla.gnome.org/show_bug.cgi?id=736019
2014-09-05 19:00:23 +02:00
Guillaume Desmottes
f900f53e95
validate: fix a couple of typos in comments
...
https://bugzilla.gnome.org/show_bug.cgi?id=736019
2014-09-05 19:00:23 +02:00
Thibault Saunier
7cfdb5372c
validate: Use a GList to store action types instead of hashtable
...
It is more adapted and allows us to print the action types in a stable
maneer.
2014-09-05 19:00:23 +02:00
Thibault Saunier
eb6739c91b
validate: report: Do not repeat type name when printing its details
2014-09-05 19:00:23 +02:00
Thibault Saunier
e5b485d776
validate: Document the API with gtk-doc
2014-09-05 19:00:23 +02:00
Thibault Saunier
45ffbdec07
validate: Add GObject Introspection support
2014-09-05 19:00:23 +02:00
Thibault Saunier
4fd1939b21
validate: Rework the action parameter API
...
Making it possible to properly define parameters, and describe them.
+ Document all action types!
2014-09-05 19:00:23 +02:00
Thibault Saunier
d29a8e4a77
validate: Add an option to print all avalaible actions with details
...
+ Cleanup actions descriptions
+ Make GstValidateActionType internal only and only expose the structure
2014-09-05 19:00:23 +02:00
Thibault Saunier
0ad475063d
validate: Do not segfault when receiving a segment on unlink pad
...
For some reason we did no discover that before.
2014-09-05 19:00:23 +02:00
Thibault Saunier
8eeaa1a95f
validate: Make GstValidateActionType a GstMiniObject and expose it in the API
2014-09-05 19:00:23 +02:00
Thibault Saunier
bdc09d2d4a
validate:scenario: Cleanup header and add some padding to classes
...
Let's start making gst-validate ABI and API stable
2014-09-05 19:00:23 +02:00
Thibault Saunier
3979c49cd2
validate: The scenario only old a weak ref so unref the weak ref
...
We were unrefing an object we did not actually own a ref on.
2014-08-12 15:14:28 +02:00
Thibault Saunier
32dac5014a
validate: Allow several outputs in GST_VALIDATE_FILE
2014-08-12 13:16:43 +02:00
Thibault Saunier
2da2c6cc56
validate:launcher: Allow limitating local HTTP server bandwith
...
By default we limit its bandwith to 1MBps which is somehow similare to a
good internet connection case.
2014-08-12 13:16:43 +02:00
Thibault Saunier
f42f0724e5
validate: Actually accept rounding errors and small mistakes for position
...
WHen seeking in paused the position right after should be pretty much
the exact one, but sometimes it can be a little different because of
rounding issues and similare.
2014-08-04 13:03:19 +02:00
Thibault Saunier
8518e08dbb
validate: Add a way to avoid printing all the issue in reports
...
Avoiding user to be flooded by information he does not want while
debugging
2014-08-04 13:02:46 +02:00
Thibault Saunier
d682bd29a9
validate: Print the report when aborting because of an issue
...
Letting a chance to the user to know what bug he faced!
2014-08-04 13:02:46 +02:00
Thibault Saunier
5c50219fae
validate: Enhance output about critical errors
...
+Lower some warning to INFO
2014-08-04 13:02:46 +02:00
Thibault Saunier
6da09fb919
validate: Allow overrides for scenario issues
2014-08-04 13:02:46 +02:00