Wim Taymans
fd755182b1
uridecodebin: clean up decodebin properties
...
When reusing a decodebin2 element, clear the properties we might have changed,
to their default values or else we might end up with old configuration.
Fixes #608484
2010-02-01 15:00:18 +01:00
Tim-Philipp Müller
16601b09fe
playbin2: when no uri is set, post an error message
...
When no uri is set, don't just return STATE_CHANGE_FAILURE from the
state change function, but actually post an error message.
2010-01-30 15:41:32 +00:00
Edward Hervey
c60f94da58
decodebin2: Don't skip an element when getting the topology
...
Fixes #608167
2010-01-26 17:29:21 +01:00
Julien Moutte
d6108b8fad
subtitleoverlay: relax caps template on sink pads
...
Allow any caps on sink pad templates as we could do passthrough with non raw
video caps.
2010-01-25 18:57:52 +01:00
Sebastian Dröge
fcf2668b20
Revert "inputselector: Protect g_object_notify() with the object's mutex"
...
This reverts commit a37426c41c
, it's
causing deadlocks with playbin2.
2010-01-25 12:22:17 +01:00
Kipp Cannon
a37426c41c
inputselector: Protect g_object_notify() with the object's mutex
...
This works around the thread unsafety of g_object_notify()
Fixes bug #607513 .
2010-01-24 20:55:26 +01:00
Wim Taymans
12af633942
uridecodebin: handle raw sources about-to-finish signals
...
When we are dealing with a source that produces raw audio/video, we don't use a
decodebin2 to decode the data and we thus don't have the drained/about-to-finish
signal emited. To fix this, we add a padprobe on the source pads and emit the
drained signal ourselves. This then makes playbin2 emit the about-to-finish
signal for raw sources such as cdda://
Fixes #607116
2010-01-22 16:36:46 +01:00
Tim-Philipp Müller
b0fe1867d4
playsink: re-use iterator callback to avoid code duplication
2010-01-18 10:10:27 +00:00
Tim-Philipp Müller
7216605ffa
playsink: when looking for sink properties, make sure they have the right type
...
We don't want to end up setting values on elements where the property is of
a different type than we expect. Can't transform the value either, since we
can't really make assumptions about the scale and transform function.
Fixes crashes when using playbin2 with apexsink (#606949 ).
2010-01-18 10:10:27 +00:00
Sebastian Dröge
7335ce5d3e
playbin2: Only allow to set the URIs in states <= READY or from an about-to-finish signal handler
...
Changing the URIs in a state > READY results in unexpected behaviour,
i.e. the new URIs are only used after the current track has finished.
Fixes bug #607226 .
2010-01-18 09:32:42 +01:00
Mark Nauwelaerts
2482a536ac
decodebin2: sprinkle some more locking
...
... to avoid races and ensure some data structure consistency.
See also #574289 .
2010-01-16 18:48:00 +01:00
Mark Nauwelaerts
45447337ad
decodebin2: mind blocked pads when shutting down
...
Fix regression in shutdown deadlock handling now that the
target of a ghostpad is blocked instead of ghostpad itself.
See also #574293 .
2010-01-14 18:26:03 +01:00
Sebastian Dröge
3b842bc98b
playsink: Fix disabling of subtitles if subtitles were used before
...
In this case the video still goes through the text chain and
subtitles are still going in there, in case subtitles are
enabled again. This makes sure that re-enabling subtitles
happens instantly.
Fixes hanging video when disabling subtitles, caused by an
unliked video pad.
2010-01-14 13:36:23 +01:00
Mark Nauwelaerts
36fee21834
playbin2: fix pad ref leak
2010-01-14 10:46:28 +01:00
Brijesh Singh
0fe6b6e8ab
playsink: Fix handling of the native audio/video flags
...
Fixes bug #606687 .
2010-01-13 09:39:54 +01:00
Wim Taymans
22939b074c
Merge branch 'master' of ssh://git.freedesktop.org/git/gstreamer/gst-plugins-base
2010-01-05 10:38:41 +01:00
Wim Taymans
15216d23ac
decodebin2: fix typo in debug message
2009-12-23 21:24:48 +01:00
Wim Taymans
99e836a340
decodebin2: avoid some type checks
2009-12-23 18:18:03 +01:00
Wim Taymans
3b0fc1e4fb
playbin2: avoid leaking selector request pads
2009-12-23 17:08:27 +01:00
Wim Taymans
d4e1ff012d
uridecodebin: avoid leaking queue and typefind
...
Don't leak the queue and typefind elements that we might link after the
source element.
2009-12-23 15:46:25 +01:00
Jonathan Matthew
138c851173
uridecodebin: don't name the queue
...
There is no reason to name the queue.
Fixes #605219
2009-12-23 15:43:52 +01:00
Wim Taymans
8266d201a0
decodebin2: add some debugging
2009-12-16 11:44:11 +01:00
Wim Taymans
26071d748f
playsink: fix video when subtitles disabled
...
When we have a source with subtitles but they were disabled with the flags,
still ghostpad the video pad instead of leaving it unlinked.
2009-12-09 12:11:55 +01:00
Sebastian Dröge
7bf631e448
playbin2: Fix stream-changed message list iteration
...
When iterating the list and removing the current element, first
get the next element and then remove the current one and not
the other way around.
2009-12-08 13:41:28 +01:00
Sebastian Dröge
49fd39c3fd
playsink: Some minor cleanup
2009-12-07 09:13:40 +01:00
Sebastian Dröge
930a57db20
playbin2: Reset stream segments on FLUSH_STOP and don't adjust QoS events for non-time segments
2009-12-06 18:06:05 +01:00
Stefan Kost
e6e9e3c589
build: fix build with debug logging disabled.
2009-12-03 23:38:54 +02:00
Stefan Kost
a6cf29fd3d
playbin2: don't iterate the factory lists in non-debug mode
...
When debugging is disabled, we won't see anything printed anyway.
2009-12-03 18:08:49 +02:00
Sebastian Dröge
732f3055a3
subtitleoverlay: Fix some pad refcount issues
...
Fixes bug #603345 .
2009-11-30 10:22:54 +01:00
Sebastian Dröge
1273909419
playbin2: Transform QoS events to be meaningful for upstream elements
...
This is necessary because the sinks don't notice the group switches
and the decoders/demuxers have a different running time than the
sinks.
Fixes bug #537050 .
2009-11-23 08:06:02 +01:00
Thiago Santos
0d6195686b
decodebin2: error when all streams have no buffers
...
In some cases (all buffers dropped by a parser) a decodebin2
chain might receive an EOS before it gets enough data to
expose a decoded pad. In the case that no streams can expose
a pad we should error out instead of hang.
Fixes #542758
2009-11-19 14:51:33 -03:00
Sebastian Dröge
7e5d6ed441
playbin2: Fix stupid bug introduced in last commit
2009-11-19 12:23:08 +01:00
Sebastian Dröge
d6dd987ffb
playbin2: Aggregate the stream-changed message by looking at the seqnum
...
Just counting how many messages were sent and how many were received
is not good enough because they might've been duplicated (e.g. by the
visualization audio tee). Comparing the sequence numbers should give
better results in that case.
2009-11-19 12:12:57 +01:00
Sebastian Dröge
ea40d8e36a
playbin2: Ignore async state changes of the uridecodebins
...
Otherwise the async state change from READY->PAUSED of the
uridecodebins will take playbin2 from PLAYING->PAUSED again
during gapless group switches.
Fixes bug #602000 .
2009-11-19 12:12:57 +01:00
Thiago Santos
e3e7ba0d1a
decodebin2: set to buffer less on no-more-pads
...
When a decodebin2 receives no-more-pads of a group it
can set that group's multiqueue buffering thresholds to
'playing' buffering method, avoiding that it buffers
too long and cause problems when using with queue2.
See the associated bug for details.
Fixes #600787
2009-11-18 15:16:18 -03:00
Sebastian Dröge
af34d2c1f8
playbin2: Don't handle DURATION queries during group switches
...
During a group switch return the cached duration of the old group
because the old group still didn't finish playback. If we have no
cached duration return FALSE.
Fixes bug #585969 .
2009-11-18 16:40:32 +01:00
Sebastian Dröge
7e674d8605
playbin2: Post a stream-changed message after activating a group
...
This is useful to detect when playbin2 has really switched to the next
group after about-to-finish for example.
Fixes bug #584987 .
2009-11-18 16:40:32 +01:00
Wim Taymans
c4d7dbce1a
playsink: make sure we always go to PAUSED async
...
Set the need_async_start flag before going to PAUSED so that we always post the
ASYNC_START message, even after reusing playsink.
2009-11-17 16:39:09 +01:00
Wim Taymans
65773b58dd
playsink: make sure we remain a sink
...
When we remove our elements, we could lose our sink flag. Make sure we remain a
sink by setting the flag again after removing elements.
2009-11-17 16:37:57 +01:00
Sebastian Dröge
3b4fd71270
playbin2: Make subtitle error handling more robust and ignore late errors too
...
Make sure, to only "simulate" subtitle no-more-pads if it was still
pending and also handle errors in the subtitle pipeline as warnings
after the subtitles prerolled.
Don't set the suburidecodebin to READY after errors, handle_message
will usually be called from the streaming thread and doing that
from there is obviously not a good idea.
2009-11-14 14:08:40 +01:00
Sebastian Dröge
cdc5fc2c66
subtitleoverlay: Handle errors from subtitle elements as warning and go into passthrough mode
2009-11-14 14:08:40 +01:00
Sebastian Dröge
16dec615cb
playbin2: Don't leak the GError and debug string when parsing error messages
2009-11-14 14:08:40 +01:00
Sebastian Dröge
18f5fad785
playbin2: Improve subtitle passthrough in uridecodebin
...
Now the caps property isn't set anymore for the subtitle caps
but instead in the autoplug-continue signal it is detected
if the caps belong to a supported subtitle stream.
This makes automatic use of newly installed plugins.
2009-11-12 13:20:42 +01:00
Sebastian Dröge
7827660dcd
subtitleoverlay: Only recreate factory caps if necessary and cache them
2009-11-12 13:20:42 +01:00
Sebastian Dröge
068aecc389
subtitleoverlay: Only update the factory list when the registry has changed
...
Also don't free the list every time we go to NULL.
2009-11-12 13:20:42 +01:00
Sebastian Dröge
6980503927
subtitleoverlay: Use gst_pad_get_caps_reffed()
2009-11-12 13:20:41 +01:00
Sebastian Dröge
b02d9837f7
playbin2/playsink: Use new "silent" property instead of unlinking
...
This makes sure that subtitleoverlay still gets segment updates and
everything to pass on downstream. Without this segment problems happen.
2009-11-12 13:20:41 +01:00
Sebastian Dröge
af3d16dbb1
subtitleoverlay: Update segments after pushing the events downstream
...
This makes sure that we don't apply segments twice downstream. Also
always send our newsegment events downstream.
2009-11-12 13:20:41 +01:00
Sebastian Dröge
e869b57296
subtitleoverlay: Add silent property to disable subtitles
...
This tries to disable subtitles in the overlay or renderer
and if that's not possible it goes into passthrough mode.
2009-11-12 13:20:41 +01:00
Sebastian Dröge
eb2d207811
subtitleoverlay: Set the video framerate on parsers if possible
...
Fixes bug #599649 .
2009-11-12 13:20:41 +01:00
Sebastian Dröge
c5d26b23c7
playbin2: Handle external subtitles better
...
First of all, make sure that suburidecodebin never
errors out because of not-linked in case external subtitles
are used but then subtitles are disabled.
And then make sure that external subtitles always start from
the correct position and are not racing until EOS if they
get unselected and selected again.
2009-11-12 13:20:41 +01:00
Sebastian Dröge
16073d1eb7
playbin2: Flush the subtitles before switching to a new subtitle stream
...
This makes sure that all currently shown subtitles disappear
and new ones can be shown as soon as possible.
2009-11-12 13:20:40 +01:00
Sebastian Dröge
e91458f13c
playbin2: Set subtitle caps as raw caps for the uridecodebins
...
This will make sure that no subparse is ever plugged and subtitleoverlay,
that subpicture streams are handled the same was as subtitles and that
subtitle renderers are used if available.
Fixes bugs #595123 , #570753 , #591662 , #591706 .
2009-11-12 13:20:40 +01:00
Sebastian Dröge
ced1b8f897
playbin2/playsink: Remove everything related to subpicture streams
...
These will soon be handled the same way as subtitle streams.
2009-11-12 13:20:40 +01:00
Sebastian Dröge
dcc109bd9a
playsink: Add a queue before subtitleoverlay
...
This will improve playback, and the same thing is done
for subpicture streams too.
2009-11-12 13:20:40 +01:00
Sebastian Dröge
c0828e55b6
playsink: Use subtitleoverlay for subtitles
2009-11-12 13:20:40 +01:00
Sebastian Dröge
92ccb87850
subtitleoverlay: Add new element for generic subtitle overlaying
...
This autopluggs the required elements for parsing and rendering
different subtitle formats on a video stream.
Fixes bug #600370 .
2009-11-12 13:20:40 +01:00
Sebastian Dröge
1da5a3f7d3
playback: Update factories list on every access if the registry has changed
...
This makes application's simpler because the element doesn't need to
go to NULL first to make use of newly installed plugins.
Fixes bug #601480 .
2009-11-11 14:00:26 +01:00
Sebastian Dröge
ab96265c57
playback: When going from NULL->READY check if the registry has new features
...
This makes it possible to use newly installed plugins after going back
to NULL instead of requiring a new instance.
Fixes bug #599266 .
2009-11-10 18:30:46 +01:00
Tim-Philipp Müller
23f92ed8cd
playsink: assign chain->mute before using it
...
Fixes GObject warnings when starting totem.
2009-11-10 01:06:17 +00:00
Edward Hervey
e34abf228d
playback: Fix the order in strcmp that I broke in previous commit.
2009-11-09 19:58:20 +01:00
Edward Hervey
b9053c5ae8
playback: Avoid expensive API calls in tight loop.
...
We know we're dealing with GstPluginFeature.
2009-11-09 19:18:07 +01:00
Sebastian Dröge
dfd51aa82a
inputselector: Remove useless variables and fix a uninitialized variable compiler warnings
2009-11-08 11:27:57 +01:00
Sebastian Dröge
6c15d9e8d4
decodebin2: Add property to disable/enable posting of stream-topology messages
...
Most people don't need this messages and generating them is quite
expensive.
2009-11-06 17:01:04 +01:00
Sebastian Dröge
5798b543df
decodebin2: Protect subtitle elements and subtitle encoding by a new mutex
...
Using the object lock here can and will lead to deadlocks because
of deep-notifies of property changes: the deep-notify handler will
get the parent of objects, which will take the object lock again.
Fixes bug #600479 .
2009-11-06 15:15:06 +01:00
Sebastian Dröge
f365385458
inputselector: Make sure that running_time->timestamp calculation never becomes negative
2009-11-06 13:14:14 +01:00
Sebastian Dröge
97519751ad
uridecodebin: Improve all-raw-caps detection for pads
2009-11-06 12:37:03 +01:00
Sebastian Dröge
27034be461
inputselector: Use the start time (i.e. timestamp) as the last stop
...
Using the end time makes it impossible to replace buffers, which is
a big problem for subtitles that could have very long durations.
2009-11-06 12:11:21 +01:00
Wim Taymans
8b93746b78
inputselector: use _get_caps_reffed()
2009-11-05 13:12:19 +01:00
Stefan Kost
a78c8bf3ed
pad: rename new api from _refed to _reffed.
...
Due to popular demand rename the new api as we still can.
2009-11-05 13:00:27 +02:00
Wim Taymans
fcb283b78b
playbin2: avoid copying caps
...
Use get_caps_refed() when we can.
2009-11-04 18:57:07 +01:00
Wim Taymans
89f02fb269
decodebin2: use new getcaps function to avoid copies
...
Use the gst_pad_get_caps_refed() to avoid some caps copy functions.
2009-11-04 18:31:09 +01:00
Wim Taymans
eb92aa282f
uridecodebin: use faster element_link_pads
...
Use the faster gst_element_link_pads because we know for sure the sinkpad name
and we don't need to have the function search for a suitable pad anymore.
2009-11-04 17:50:11 +01:00
Sebastian Dröge
0672457604
playbin2: Return NOT_LINKED for unselected text pads from a demuxer
...
We want to return NOT_LINKED for unselected pads but only for pads
from the normal uridecodebin. This makes sure that subtitle streams
are not raced past audio/video from decodebin2's multiqueue.
For pads from suburidecodebin OK should always be returned, otherwise
it will most likely stop with an error.
2009-11-04 10:53:27 +01:00
Stefan Kost
f71ed36694
inputselector: also add inline to the proto to fix the build
...
Merged from gst-plugins-bad, e1e9be6dbe
.
2009-11-04 08:20:59 +01:00
Sebastian Dröge
dd55311f3b
uridecodebin: Initialize caps property with the default raw caps
2009-11-03 13:03:26 +01:00
Sebastian Dröge
0285d77d96
decodebin2: Use static caps for the default raw caps and put them into a separate header
...
This way we can use the same default raw caps everywhere.
2009-11-03 13:03:23 +01:00
Josep Torra Valles
e9d1819fe3
playbin: Make sure to keep a reference on the volume element
...
Fixes null pointer dereferences under certain circumstances.
Fixes bug #595401 .
2009-11-02 07:30:54 +01:00
Sebastian Dröge
e72c3029c0
playsink: Reset {mute,volume}-changed flags after setting the volume
...
These flags are there to make sure that the volume is set, if there
is no volume element yet.
2009-10-30 09:24:30 +01:00
Sebastian Dröge
598c937634
playsink: If notify::{volume,mute} is triggered by the volume element, update our internal state
2009-10-30 09:24:03 +01:00
Sebastian Dröge
d85dadc122
playsink: Proxy notify::volume and notify::mute from the volume/mute elements (or sinks)
...
Fixes bug #600027 .
2009-10-29 14:30:31 +01:00
Sebastian Dröge
de1db5ccbd
playbin2: Proxy notify::volume and notify::mute from the playsink to playbin2
2009-10-29 14:19:09 +01:00
Sebastian Dröge
75d36a0b1e
queue2: Remove from gst-plugins-base
...
This is now in coreplugins.
2009-10-29 11:29:46 +01:00
Tim-Philipp Müller
6f4c1ac583
Remove GST_DEBUG_FUNCPTR where they're pointless
...
There's not much point in using GST_DEBUG_FUNCPTR with GObject
virtual functions such as get_property, set_propery, finalize and
dispose, since they'll never be used by anyone anyway. Saves a
few bytes and possibly a sixteenth of a polar bear.
2009-10-28 00:59:35 +00:00
Wim Taymans
7065c7a02d
queue2: add custom acceptcaps function
2009-10-27 15:23:00 +01:00
Wim Taymans
0b00e25b54
decodebin2: implement low/high watermark property
2009-10-27 15:22:22 +01:00
Wim Taymans
7ab778199e
uridecodebin: don't use 2 buffering elements
...
Only use the multiqueue buffering when we don't have a stream (and thus are
using queue2 to do the buffering already).
2009-10-24 16:10:00 -04:00
Wim Taymans
660fc111d1
playbin2: add flag to enable decodebin buffering
...
Add a flag that enables buffering in decodebin.
2009-10-24 16:10:00 -04:00
Wim Taymans
f998858192
decodebin2: buffering is implemented now
2009-10-24 16:09:59 -04:00
Wim Taymans
26290f44d6
uridecodebin: buffering is implemented now
2009-10-24 16:09:59 -04:00
Wim Taymans
3d2b3dd268
decodebin2: configure use-buffering on multiqueue
2009-10-24 16:09:59 -04:00
Wim Taymans
d5add83976
uridecodebin: use 0 for max buffer size
2009-10-24 16:09:59 -04:00
Wim Taymans
1fa7f049f1
uridecodebin: set some reasonable defaults
2009-10-24 16:09:59 -04:00
Wim Taymans
3883fac8d8
uridecodebin: set buffering properties on decodebin2
...
Propagate the buffering properties on decodebin2 but only if we are not already
doing download buffering.
2009-10-24 16:09:59 -04:00
Wim Taymans
adba87539f
uridecodebin: add use-buffering property
...
Add a use-buffering property that will perform buffering on the parsed or
demuxed media.
2009-10-24 16:07:36 -04:00
Wim Taymans
baecd335b2
decodebin2: refactor queue size configuration.
...
Refactor the queue size configuration into a new method.
Use the same queue values for buffering as for preroll.
2009-10-24 16:07:36 -04:00
Wim Taymans
cffe4d7bd3
decodebin2: move error path down
2009-10-24 16:07:36 -04:00
Wim Taymans
1c982d0dbe
decodebin2: implement max queue size properties
2009-10-24 16:07:36 -04:00
Wim Taymans
3fffb0e2dd
decodebin2: add properties for buffering
...
Add properties that can be used to configure the multiqueue buffers and
buffering methods
2009-10-24 16:07:36 -04:00
Sebastian Dröge
4de2ab48ea
playbin2: Don't destroy the suburidecodebin on errors
...
It can still be reused
2009-10-24 13:08:07 +02:00