mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-04 01:32:42 +00:00
Code Issues 1 Projects Releases Wiki Activity
958 commits 44 branches 1508 tags 344 MiB
Commit graph

770 commits

Author SHA1 Message Date
Enrique Ocaña González
d1a79d7c59 Properly handle drain requests while flushing 
Without this commit the decoder streaming thread stops without ever attending
the drain request, leaving the decoder input thread waiting forever.

https://bugzilla.gnome.org/show_bug.cgi?id=758274
 2015-11-18 15:18:02 +02:00
Nicolas Huet
9adf0ff829 omx: fix hacks leak on class init 2015-11-18 12:02:44 +00:00
Thiago Santos
03fc454457 omxaacdec: Do not accept unknown layouts 
It was defaulting to RAW when an unknown layout was received but
the caps template would actually forbid that on the caps query
or accept-caps anyway.
 2015-09-01 16:13:00 -03:00
Thiago Santos
1f3bf04fe7 omxaudiodec: use default pad accept-caps handling 
Instead of the audiodecoder one. The OMX audioo decoders have their
valid input in the template pad, so just check against that to
avoid doing a query downstream.
 2015-09-01 09:01:45 -03:00
Thiago Santos
c038df6671 omxvideodec: use default pad accept-caps handling 
Instead of the videodecoder one. The OMX video decoders have their
valid input in the template pad, so just check against that to
avoid doing a query downstream.
 2015-08-28 12:57:33 -03:00
Graham Leggett
703bab6885 omxvideoenc: Add keyframe support for the Rpi, using OMX_IndexConfigBrcmVideoRequestIFrame 
https://bugzilla.gnome.org/show_bug.cgi?id=753085
 2015-08-27 11:15:29 +03:00
Philippe Normand
e0327521f6 omxh264dec: implement is_format_change 
The omxvideodecoder class only checks some of the caps parameters but if
other fields change such as h264 profile and/or level it wouldn't trigger a
reconfiguration.

https://bugzilla.gnome.org/show_bug.cgi?id=752376
 2015-08-16 15:48:16 +02:00
Aurélien Zanelli
d2df0fb032 omxvideodec: unref allocator after getting it from allocation query 
Otherwise a reference will be leaked for each allocator. It only happens
when target platform is Raspberry Pi and when we have GL support.

https://bugzilla.gnome.org/show_bug.cgi?id=751867
 2015-07-06 11:54:28 +03:00
Sebastian Dröge
3f46a12aab omxaudiodec: Add an output adapter for chunking the output into codec frames 
Otherwise the base class will be confused.
See https://bugzilla.gnome.org/show_bug.cgi?id=685730
 2015-05-19 19:14:42 +03:00
Tim-Philipp Müller
afab78e52e Remove obsolete Android build cruft 
This is not needed any longer.
 2015-04-26 18:24:26 +01:00
Luis de Bethencourt
24c0197e46 omxaudiodec: add comment explaining duplicate code path 2015-03-06 12:12:49 +00:00
Luis de Bethencourt
e8d76fb1ef Revert "omxaudiodec: remove duplicate code path" 
This reverts commit a8d26ff27a.
 2015-03-06 12:09:06 +00:00
Luis de Bethencourt
70c48cf85f omx: handle both errors in the two steps of update_port_definition 
Also consider potential errors in the _get_parameter() in the return of the
update_port_definition function.

CID #1287052
 2015-03-06 12:06:22 +00:00
Luis de Bethencourt
3aa008adb7 omxaudioenc: impossible if statement 
ret is set to GST_STATE_CHANGE_SUCCESS and never touched, so it is impossible
for it to be anything else at the if check. Remove the if check.

CID #1287053
 2015-03-06 10:57:53 +00:00
Luis de Bethencourt
964cb549bb omxaudiodec: impossible if statement 
ret is set to GST_STATE_CHANGE_SUCCESS and never touched, so it is impossible
for it to be anything else at the if check. Remove it.

CID #1287054
 2015-03-06 10:54:46 +00:00
Luis de Bethencourt
a8d26ff27a omxaudiodec: remove duplicate code path 2015-03-06 10:50:30 +00:00
George Kiagiadakis
0ef1e90b34 omx: call handle_messages() only once in acquire_buffer() to avoid potential deadlock 
There is one rare case where calling handle_messages() more than once can cause a deadlock
in the video decoder element:

- sink pad thread starts the src pad task (gst_omx_video_dec_loop())
- _video_dec_loop() calls gst_omx_port_acquire_buffer() on dec_out_port
- blocks in gst_omx_component_wait_message() releasing comp->lock and comp->messages_lock
  (initially, there are no buffers configured on that port, so it waits for OMX_EventPortSettingsChanged)
- the sink pad thread pushes a buffer to the decoder with gst_omx_port_release_buffer()
- _release_buffer() grabs comp->lock and sends the buffer to OMX, which consumes it immediately
- EmptyBufferDone gets called at this point, which signals _wait_message() to unblock
- the message from EmptyBufferDone is processed in gst_omx_component_handle_messages()
  called from gst_omx_port_release_buffer()
- gst_omx_port_release_buffer releases comp->lock
- the src pad thread now gets to run, grabbing comp->lock while it exits from _wait_message()
- _acquire_buffer() calls the _handle_messages() on the next line after _wait_message(),
  which does nothing (no pending messages)
- then it goes to "retry:" and calls _handle_messages() again, which also does nothing
  (still no pending messages)
- scheduler switches to a videocore thread that calls EventHandler, informing us about the
  OMX_EventPortSettingsChanged event that just arrived
- EventHandler graps comp->messages_lock, but not comp->lock, so it can run in parallel at
  this point just fine.
- scheduler switches back to the src pad thread (which is in the middle of _acquire_buffer())
- the next _handle_messages() which is right before if (g_queue_is_empty (&port->pending_buffers))
  processes the OMX_EventPortSettingsChanged
- the buffer queue is still empty, so that thread blocks again in _wait_message()
- the sink pad thread tries to acquire the next input port buffer
- _acquire_buffer() also blocks this thread in:
   if (comp->pending_reconfigure_outports) { ... _wait_message() ... }
- DEADLOCK. gstreamer is waiting for omx to do something, omx waits for gstreamer to do something.

By removing those extra _handle_messages() calls, we can ensure that all the checks of
_acquire_buffer() will re-run. In the above case, after the scheduler switches back to
the middle of _acquire_buffer(), the code will enter _wait_message(), which will see that
there are pending messages and will return immediately, going back to "retry:" and
re-doing all the checks properly.

https://bugzilla.gnome.org/show_bug.cgi?id=741854
 2015-03-04 09:51:03 +01:00
Wonchul Lee
df58d8baac omx: cleanup code a bit to remove else statement 
https://bugzilla.gnome.org/show_bug.cgi?id=745191
 2015-02-26 11:15:37 +02:00
Jun Ji
8936f6634c omx: Add omxamrdec 
https://bugzilla.gnome.org/show_bug.cgi?id=739333
 2014-11-13 13:32:16 +01:00
Sebastian Dröge
40ab1b0a45 omxaudiodec: Clean up code a bit to get rid of useless NULL checks 2014-09-30 10:47:20 +03:00
junji
eba9e3f29d omxaudiodec: Unmap input buffers after usage 
https://bugzilla.gnome.org/show_bug.cgi?id=736314
 2014-09-30 10:44:38 +03:00
Michal Lazo
bfeab29a39 omxvideoenc: Setup aspect ratio on RPi 
Needs firmware from yesterday or newer to work with all possible
aspect ratios. Before that it only supported a fixed list.

https://bugzilla.gnome.org/show_bug.cgi?id=732533
 2014-09-01 12:18:58 +03:00
Sebastian Dröge
cdb918aefb omxaudioenc: Implement the hack flag GST_OMX_HACK_NO_COMPONENT_RECONFIGURE 2014-08-28 10:45:37 +03:00
Sebastian Dröge
2c98a6ab7e omxaudioenc: Use the base class' open/close vfuncs instead of calling them ourselves 2014-08-28 10:45:37 +03:00
Peng Liu
d3d0a82ba4 omxvideoenc: Implement the hack flag GST_OMX_HACK_NO_COMPONENT_RECONFIGURE 
Fix a video encoder stall problem on RPi when changing the aspect ratio.

https://bugzilla.gnome.org/show_bug.cgi?id=732533
 2014-08-28 10:45:11 +03:00
Sebastian Dröge
d75334456d omx: Let base classes handle EOS 
https://bugzilla.gnome.org//show_bug.cgi?id=734774
 2014-08-14 17:36:11 +03:00
Sebastian Dröge
19d77004d2 omxaudiodec: Fix flushing logic and make it more similar to the video decoder 2014-08-14 17:33:07 +03:00
Sebastian Dröge
b4c7c726ef Release 1.2.0 2014-07-23 11:28:12 +02:00
Sebastian Dröge
c4deb7c07c omxaudiosink: Set port to not flushing in prepare() and keep it at flushing in unprepare() 
https://bugzilla.gnome.org/show_bug.cgi?id=733168
 2014-07-20 17:47:50 +02:00
Sebastian Dröge
08385fe944 omxaudiodec: Implement setting of fallback channel positions 2014-07-13 22:15:44 +02:00
Sebastian Dröge
03cf0bc9a4 omx: Add AAC audio decoder 2014-07-13 18:22:39 +02:00
Sebastian Dröge
f4961d0a72 omxaudiodec: Get PCM parameters from the out port, not the in port 2014-07-02 09:22:28 +02:00
Sebastian Dröge
c27053c94e omxaudiodec: Implement hack for not disabling the output port after set_format until the output format is known 
Needed on some OMX implementations, e.g. the one from Atmel. It does
not send the settings-changed event on the output port if it is
disabled.
 2014-07-02 09:21:00 +02:00
Sebastian Dröge
0c3b3ef3d0 omx: Add audio decoder base class and a subclass for MP3 2014-07-02 09:21:00 +02:00
Sebastian Dröge
3d94d3e44d omx: Link to gmodule-2.0-no-export for being able to use the g_module_*() API 
https://bugzilla.gnome.org/show_bug.cgi?id=732518
 2014-07-01 09:38:01 +02:00
Sebastian Dröge
33e083fff6 omxh264enc: Properly accumulate headers and push before the next frame 
Fixes output of encoding on RPi, where each header buffer (SPS and PPS)
is in a separate OMX buffer.

https://bugzilla.gnome.org/show_bug.cgi?id=726669
 2014-06-29 19:10:19 +02:00
Sebastian Dröge
0a60770a28 omxvideoenc: Implement flush() instead of the deprecated reset() 2014-06-29 19:04:54 +02:00
Sebastian Dröge
4593f434a0 omxbufferpool: Copy buffers if the stride does not match and we can't use video meta 
https://bugzilla.gnome.org/show_bug.cgi?id=731672
 2014-06-24 15:11:53 +02:00
Sebastian Dröge
b9238195dd omx: Only include OMX_VideoExt.h conditionally 
It does not exist on the RPi for example.
 2014-06-24 14:52:43 +02:00
Sebastian Dröge
af38fe7dce omxbufferpool: Fix format string compiler warning 2014-06-24 13:02:13 +02:00
Michal Lazo
326e15ca85 omxbufferpool: Initialize debug category 2014-06-24 13:01:48 +02:00
Sebastian Dröge
03c54e7c0f omxbufferpool: Properly convert OMX alignment to GStreamer alignment 
GStreamer uses a bitmask for the alignment while OMX uses the
alignment itself. Let's convert.

https://bugzilla.gnome.org/show_bug.cgi?id=710564
 2014-06-24 12:42:22 +02:00
Sebastian Dröge
6617d6f577 omxh264enc: Don't let baseclass finish frames for SPS/PPS buffers 
Otherwise we a) send them twice, and b) finish a frame for something
that does not even include a frame.

https://bugzilla.gnome.org/show_bug.cgi?id=726669
 2014-06-24 11:11:28 +02:00
Sebastian Dröge
b496a6d6f2 omxvideo: Include the separate headers too for compatibility with 1.0.x 2014-06-24 10:22:37 +02:00
Zhao, Halley
38a07c5386 omxvp8dec: use VP8 definition from OMX_VideoExt.h 
https://bugzilla.gnome.org/show_bug.cgi?id=726957
 2014-06-24 10:21:07 +02:00
Aurélien Zanelli
58aa603b36 omxvideodec: fix a query leak 
Also add a debug message if query fails.

https://bugzilla.gnome.org/show_bug.cgi?id=731898
 2014-06-20 11:54:25 +02:00
Aurélien Zanelli
ad969ffda3 omxvideodec: release frames with old PTS to avoid memory issue 
Interlaced stream could make the decoder use two input frames to produce
one output frame causing the gstvideodecoder frame list to grow.
Assuming the video decoder output frame in display order rather than in
decoding order, this commit add a way to release frames with PTS less
than current output frame.

https://bugzilla.gnome.org/show_bug.cgi?id=730995
 2014-06-04 16:36:02 +02:00
Kazunori Kobayashi
4c488d425d omx: Fix a missing g_free() in error path 
This fixes a memory leak with g_strdup() when an error occurs.

https://bugzilla.gnome.org/show_bug.cgi?id=731141
 2014-06-03 09:23:41 +02:00
Aurélien Zanelli
3ed713db0d omxvideodec: add missing stream unlock in error path 2014-06-02 19:28:51 +02:00
Sebastian Dröge
190adce125 omx: Don't handle disabling/enabling ports exactly like flushing 
Otherwise we might abort a flush operation in another thread when
enabling/disabling ports, leading to deadlocks sometimes.

https://bugzilla.gnome.org/show_bug.cgi?id=730989
 2014-05-31 15:12:05 +02:00
Sebastian Dröge
bf7e6109d9 omxvideodec: Don't leak buffer pool config in error cases 
CID 1216158
 2014-05-26 11:03:03 +02:00
Sebastian Dröge
34577a965d omxvideoenc: Don't forget to unref codec state 
CID 1214603
 2014-05-19 09:10:07 +02:00
Sebastian Dröge
e542177c65 omxvideodec: Make output buffer pointer always initialized 
CID 1214605
 2014-05-19 09:08:33 +02:00
Sebastian Dröge
c2e5dca5f0 omxvideodec: Check return value of gst_buffer_map() 
CID 1214599
 2014-05-19 09:06:42 +02:00
Sebastian Dröge
429b0e1e27 omxvideodec: Check return value of gst_omx_port_set_enabled() for errors 
CID 1214589
 2014-05-19 09:04:09 +02:00
Sebastian Dröge
e08c0dc88a omxvideodec: Check return values of buffer pool config parsing functions 
CID 1214588
 2014-05-19 09:01:46 +02:00
Sebastian Dröge
59ac1dd03b omx: Remove dead code, buf can never be NULL here as we just check for that the line above 
CID 1214596
 2014-05-19 08:48:50 +02:00
Sebastian Dröge
800ef8ab14 omx: Fix comparisons in gst_omx_state_to_string() case to actually make sense 
CID 1214593
 2014-05-19 08:47:36 +02:00
Sebastian Dröge
7b558e37bc omx: Make sure to compare the error codes as unsigned integers so that comparisons >2**31 actually work 
CID 1214592
 2014-05-19 08:47:33 +02:00
Sebastian Dröge
93528dc43b omx: Fix comparisons in gst_omx_command_to_string() default cause to actually work 
CID 1214591
 2014-05-19 08:44:55 +02:00
Sebastian Dröge
2c3797acfe omxaudioenc: Implement hack for not disabling the output port after set_format until the output format is known 
Needed on some OMX implementations, e.g. the one from Atmel. It does
not send the settings-changed event on the output port if it is
disabled.
 2014-05-15 13:22:56 +02:00
Sebastian Dröge
40869afea7 omxvideoenc: Implement hack for not disabling the output port after set_format until the output format is known 
Needed on some OMX implementations, e.g. the one from Atmel. It does
not send the settings-changed event on the output port if it is
disabled.
 2014-05-15 13:21:07 +02:00
Sebastian Dröge
4e20116bc6 omx: Add a hack for not disabling the output port after set_format until the output format is known 
Needed on some OMX implementations, e.g. the one from Atmel. It does
not send the settings-changed event on the output port if it is
disabled.
 2014-05-15 10:59:35 +02:00
Josep Torra
e08540d969 omxaudiosink: implement _delay only in the RaspberryPI 
Make code implementation conditionally built for RaspberryPI because
OMX_IndexConfigAudioRenderingLatency seems to be a Broadcom extension.

On other targets the query position might not be accurate without
implementing _delay appropriatelly.
 2014-05-12 12:33:32 +02:00
Sebastian Dröge
527af797d2 omxaudioenc: Correctly scale nTickCount by OMX_TICKS_PER_SECOND 2014-05-12 08:56:15 +02:00
Sebastian Dröge
14af0f266e omxaudioenc: Drain encoder on NULL buffer and don't drain on flushing 2014-05-10 22:48:23 +02:00
Sebastian Dröge
cfbf5bf16d omxvideodec: Set nTickCount based on the buffer's duration instead of something wrong 2014-05-10 22:47:56 +02:00
Sebastian Dröge
bc2990169a omxvideoenc: Set nTickCount to the whole duration of the buffer instead of a wrong calculation 2014-05-10 22:47:21 +02:00
Sebastian Dröge
cef3fb5fc3 omxaudiosink: Fix format string compiler warnings 2014-05-10 22:46:51 +02:00
Josep Torra
b3eb4d897d omxaudiosink: Implements OpenMAX based audio sinks 
Provides omxanalogaudiosink and omxhdmiaudiosink elements on
the Raspberry PI.

- omxanalogaudiosink is capable to render raw mono or stereo audio
through the jack output.
- omxhdmiaudiosink is capable to render raw audio up to 8 channels
and transmit ac3/dts(IEC 61937) through the HDMI output.
- sinks provide a clock derived from rendered samples
- sinks support the GstStreamVolume interface by implementing
the volume and mute properties.

https://bugzilla.gnome.org/show_bug.cgi?id=728962
 2014-05-09 13:15:18 +02:00
Julien Isorce
bdec8c0595 omxvideodec: can negotiate caps with memory:EGLImage feature when using EGLImage allocator 
Previously when using gst EGLImage allocator the caps was
video/x-raw, format=RGBA instead of
video/x-raw(memory:EGLImage), format=RGBA

Kepp previous behavior in case negotiation fails with caps feature.
It means it will still have a chance to use EGLImage even if the
feature is not in the caps.

https://bugzilla.gnome.org/show_bug.cgi?id=729196
 2014-05-02 18:00:48 +01:00
Aurélien Zanelli
420b0b62d3 omxvp8dec: fix typo in GST_TYPE_OMX_VP8_DEC define 
https://bugzilla.gnome.org/show_bug.cgi?id=728774
 2014-04-23 10:34:52 +02:00
Aurélien Zanelli
da4cf3da1f omxvideodec: don't unref caps before logging field from it 
https://bugzilla.gnome.org/show_bug.cgi?id=728322
 2014-04-17 09:33:47 +02:00
Julien Isorce
499fb23e9c omxvideodec: use new libgstgl API since libgstegl has been removed 
There is no point to retrieve a ref/unref type
instead of an EGLDisplay directly. It's like for EGLImage.

https://bugzilla.gnome.org/show_bug.cgi?id=703343
 2014-04-15 18:32:12 +01:00
Julien Isorce
d4bb7cb4c7 configure.ac: check for libgstgl since libgstegl has been removed 
https://bugzilla.gnome.org/show_bug.cgi?id=703343
 2014-04-15 18:32:12 +01:00
Aurélien Zanelli
1b6879921c omxvideodec: add support of more color format 
Add support for ABGR, ARGB, RGB16, BGR16, YUY2, UYVY, YVYU, GRAY8 and
NV16 color format.
 2014-04-15 15:09:24 +01:00
Aurélien Zanelli
f5f876f681 omxvideodec: simplify color format conversion in fill_buffer function 2014-04-15 15:09:24 +01:00
Aurélien Zanelli
6834d2e0b3 omxbufferpool: make video stride and offset calculation easier 
It will be easier to support more color format.
 2014-04-15 15:09:23 +01:00
Aurélien Zanelli
c115da9fd5 omx: add an helper to convert OMX color format to GStreamer color format 2014-04-15 15:09:23 +01:00
Josep Torra
718fd1bb93 omxvideodec: Implement pipeline draining to support adaptive scenarios 
When draining due a format change also drain
the pipeline to reclaim back all buffers.

https://bugzilla.gnome.org/show_bug.cgi?id=726107
 2014-03-28 11:40:20 +00:00
Josep Torra
73d83f311c omxvideodec: fixes race condition during seeks 
Acording 6.1.3 Seek Event Sequence in the OpenMAX IL 1.1.2 spec
document in order to flush the component it needs to be in
paused state.

https://bugzilla.gnome.org/show_bug.cgi?id=726038
 2014-03-25 16:07:25 +00:00
Julien Isorce
39ca9f980e omxvideodec: use flush because reset is deprecated 
https://bugzilla.gnome.org/show_bug.cgi?id=726038
 2014-03-25 16:07:15 +00:00
Julien Isorce
777411c286 omxvideodec: populate the most downstream output port on reset 
Make seeking work when using egl_render component

https://bugzilla.gnome.org/show_bug.cgi?id=726038
 2014-03-25 16:06:51 +00:00
Josep Torra
100e9f998d omxbufferpool: return buffers to the pool instead of freeing them 
We have to return the buffers back to the pool in when stopping to
not mess with the GstBufferPool accounting.
The OMX buffers will be freed when those won't be in charge of the
pool in the chained up call to 'stop'.
Fixes segfaults on finalize and pool not being properly deactivated.

https://bugzilla.gnome.org/show_bug.cgi?id=726337
 2014-03-24 18:20:51 +00:00
Christian König
651e67e32d omxvideodec: add missing unlock in the error path 
Signed-off-by: Christian König <christian.koenig@amd.com>

https://bugzilla.gnome.org/show_bug.cgi?id=726958
 2014-03-24 11:11:39 +00:00
Michal Lazo
c832b03b3b fix filemode 2014-03-19 08:53:02 +01:00
Julien Isorce
e8ca74c6f8 omxbufferpool: fix memory leak if used on output port 
When using GstOMXBufferPool on an output port, it internally uses
a GPtrArray to manage the GstBuffers instead of the default queue
from the GstBufferPool base class.

In this case GstBufferPool::default_free_buffer is not called when
the pool is stopped. Because the queue is empty. So explicitely
call gst_omx_buffer_pool_free_buffer on each buffer contained in
the GPtrArray.

https://bugzilla.gnome.org/show_bug.cgi?id=726337
 2014-03-17 18:02:51 +00:00
Sebastian Dröge
922d036ae7 omxh264enc: Fix compiler warnings 2014-03-16 17:32:05 +01:00
Michal Lazo
e55bf0a4c5 omxh264enc: IDR interval, SPS and PPS headers for rpi 
https://bugzilla.gnome.org/show_bug.cgi?id=720031
 2014-03-16 17:31:01 +01:00
Christian König
8a860bd024 omxvideo: fix debug category initialisation 
https://bugzilla.gnome.org/show_bug.cgi?id=726024
 2014-03-15 12:42:03 +01:00
Christian König
0ea0eb1579 omxbufferpool: add proper type definitions 
https://bugzilla.gnome.org/show_bug.cgi?id=726325
 2014-03-15 11:26:36 +01:00
Christian König
0700d6875f omx: consolidate message waiting code 
Add a wait_message helper function and remove all those duplicated code.

https://bugzilla.gnome.org/show_bug.cgi?id=725493
 2014-03-12 14:04:57 +01:00
Sebastian Dröge
6b28cf0378 omx: Copy old copyright notice into the new file 2014-03-12 12:48:12 +01:00
Sebastian Dröge
a04ef276e5 omx: Rename function from _4_ to _for_ for clarity 2014-03-12 12:47:34 +01:00
Christian König
6bf4d9a498 omxvideo: start sharing more code between video decoder and encoder 
Identical functionality spread of two different components.
We can't use a common base class because of different inheritance,
but let's try to share the code anyway.

https://bugzilla.gnome.org/show_bug.cgi?id=726024
 2014-03-12 12:47:09 +01:00
Sebastian Dröge
e9b7dc230b omxbufferpool: Fix header include guard 2014-03-12 12:42:23 +01:00
Christian König
325c90f99d omxvideodec: separate the buffer pool from the decoder 
https://bugzilla.gnome.org/show_bug.cgi?id=726025
 2014-03-12 12:42:03 +01:00
Christian König
de5f940186 omx: simplify tunnel functions 
Specifying the component is error prone and unnecessary.

https://bugzilla.gnome.org/show_bug.cgi?id=726021
 2014-03-12 08:48:46 +01:00
Christian König
14a0da437f omxvideodec: fix memory leak in gst_omx_video_dec_allocate_output_buffers 
https://bugzilla.gnome.org/show_bug.cgi?id=725907
 2014-03-08 15:23:59 +01:00
Christian König
5ac0fe2108 omxvideodec: fix memory leak gst_omx_video_dec_negotiate 
https://bugzilla.gnome.org/show_bug.cgi?id=725907
 2014-03-08 15:22:15 +01:00
Christian König
20cfcda4db omxvideoenc: fix a memory leak in gst_omx_video_enc_getcaps 
https://bugzilla.gnome.org/show_bug.cgi?id=725826
 2014-03-06 20:37:02 +01:00
Christian König
85db124673 omxvideoenc: simplify _find_nearest_frame 
Just the same as we did with the decoder. Also give the
function a gst_omx_video_enc prefix to distinct it from
the decoder function.

https://bugzilla.gnome.org/show_bug.cgi?id=724236
 2014-03-03 20:12:58 +01:00
Christian König
2cfe70ed5d omxvideodec: simplify _find_nearest_frame 
No need to make it more complicated and error prone than
necessary. Also give the function a gst_omx_video_dec prefix
to distinct it from the encoder function.

https://bugzilla.gnome.org/show_bug.cgi?id=724236
 2014-03-03 20:12:51 +01:00
Christian König
bf0d2614c3 omxvideodec: remove dead code 
This code doesn't seems to be used for quite a while,
remove it before it starts to rot.

https://bugzilla.gnome.org/show_bug.cgi?id=724236
 2014-03-03 20:12:35 +01:00
Christian König
8b06b07f6f omx: fix two serious message handling bugs 
Waiting for the next message if we already got one
is nonsense and can lead to lockups.

https://bugzilla.gnome.org/show_bug.cgi?id=725468
 2014-03-02 12:09:59 +01:00
Christian König
4e4f093319 omxvideoenc: fix startup race condition 
The reset function shouldn't start the src pad
loop if it wasn't started before.

Signed-off-by: Christian König <christian.koenig@amd.com>
 2014-03-02 12:08:09 +01:00
Christian König
0a8cfcde87 omxvideodec: fix startup race condition 
The reset function shouldn't start the src pad
loop if it wasn't started before.

Signed-off-by: Christian König <christian.koenig@amd.com>
 2014-03-02 12:08:09 +01:00
Sebastian Dröge
1bf4edf721 omx: Don't handle FLUSHING and NOT_LINKED as errors 
Also don't stop the task on NOT_LINKED. We're not a demuxer.
 2014-01-25 17:44:57 +01:00
Tim-Philipp Müller
498b74ab6a omx: don't use the 'z' modifier to print size_t 
gcc will warn in some cases even if the size of the type
is exactly that of size_t on the platform.

https://bugzilla.gnome.org/show_bug.cgi?id=699008
 2013-08-20 16:00:07 +01:00
Roman Arutyunyan
5ba55b6c9a gstomxvideoenc: Set bitrate in setcaps 
Otherwise it gets lost whenever we configure new caps

https://bugzilla.gnome.org/show_bug.cgi?id=698049
 2013-07-01 15:48:47 +02:00
Josep Torra
f3f9330332 omx: Take lock on EOS to update the flow return value 
Fixes "GThread-ERROR **: file gthread-posix.c: line 171
(g_mutex_free_posix_impl): error 'Device or resource busy' during
'pthread_mutex_destroy ((pthread_mutex_t *) mutex)'" in _finalize.
 2013-05-20 12:06:34 +02:00
Josep Torra
64ef1f0e11 omxvideodec: Redesign video size change reconfiguration code 
Ensure stop the decoder before clossing the tunnel.
 2013-05-10 12:25:07 +02:00
jitendra
715b44ea66 omx: Add pads based on element type 
This allows to later add sources and sink that only have a srcpad
or sinkpad.

https://bugzilla.gnome.org/show_bug.cgi?id=699754
 2013-05-06 16:20:20 +02:00
Carlos Rafael Giani
2d1138f45c omx: fixed type error in printf call 
%zu expects size_t

https://bugzilla.gnome.org/show_bug.cgi?id=699008
 2013-04-27 09:17:28 +01:00
Tim-Philipp Müller
a2db76b048 Check for gstreamer-egl 
And don't use if not available.

https://bugzilla.gnome.org/show_bug.cgi?id=697574
 2013-04-23 11:05:19 +01:00
Tim-Philipp Müller
2cbbab3128 omx: more printf format fixes 
Fix printf formats again, so that gst-omx compiles warning-
free on the Raspberry Pi as well. Unfortunately OMX_UINT32
maybe be typedefed to uint32_t or unsigned long, which
doesn't work well with our debugging printf format strings,
so just use %u for those and cast to guint.
 2013-04-18 23:10:13 +01:00
Josep Torra
82807bd9dd omx: fixes unused variable 'comp' when GStreamer is built without debug 2013-04-18 16:40:06 +02:00
Josep Torra
9d0763a91d omxvideodec: don't use 'self->dec_out_port' anymore and use just 'port' 
Fixes some criticals.
 2013-04-18 16:03:56 +02:00
Josep Torra
9de6308382 omxvideodec: fixes 'port' may be used uninitialized in this function 2013-04-18 15:21:32 +02:00
Josep Torra
4974f75d91 omxvideodec: silence warnings building for RPI related to 'vcos_*' 2013-04-18 12:03:31 +02:00
Josep Torra
ae3454683e omxvideodec: Use new type from libgstvideo 2013-04-18 11:45:50 +02:00
jitendra
960590f92f omx: Disable output port before transition to idle state 
https://bugzilla.gnome.org/show_bug.cgi?id=698109
 2013-04-16 12:46:48 +02:00
Tim-Philipp Müller
0c08d375f4 omx: fix printf formats in debug messages 
OMX_U32 is typedefed to an unsigned long,
OMX_TICKS to a 64-bit integer.
 2013-04-08 17:02:32 +01:00
Josep Torra
16cf5d77db omxvideodec: use the correct printf format in a debug message 2013-04-08 16:52:19 +02:00
Josep Torra
c46a6a757e omxvideodec: use the correct OMX_IndexParam value 
Fixes playback is not smooth in the EGL path.
 2013-04-08 16:31:33 +02:00
Sebastian Dröge
31159a9b36 omxvideodec: Don't use API that is not in master yet 
It's not really needed here yet, will be needed in future versions
 2013-04-05 13:45:24 +02:00
Sebastian Dröge
8a1bb1b4a3 omxvideodec: Add support for egl_render on RPi 2013-03-26 14:00:03 +01:00
Tim-Philipp Müller
f17c8ac55b omx: fix compiler warnings when compiling with -DG_DISABLE_ASSERT 
As we do for releases. Fixes 'variable may be used uninitialized'
warnings.
 2013-03-22 19:23:46 +00:00
Tim-Philipp Müller
75dca2b081 omx: fix typo in copyright headers 2013-03-19 16:40:09 +00:00
Sebastian Dröge
4483581e2a omx: Add more constraints to the default sink template caps 2013-03-19 13:28:30 +01:00
Sebastian Dröge
e533da2b22 omxvideodec: Set ENDOFFRAME flag for the end of frames 2013-03-19 12:55:09 +01:00
Sebastian Dröge
8460cabd13 omx: Add Theora decoder 2013-03-19 12:25:27 +01:00
Sebastian Dröge
29a348efac omx: Remove additional comma 2013-03-18 16:43:24 +01:00
Sebastian Dröge
36e76faa05 omx: Rename MPEG2 decoder for consistency everywhere 2013-03-18 16:34:51 +01:00
Sebastian Dröge
d9d46263c6 omx: Add MJPEG decoder support 2013-03-18 16:34:51 +01:00
Sebastian Dröge
0f5e6e967b omx: Add VP8 decoder support 2013-03-18 16:34:51 +01:00
Tim-Philipp Müller
9da6ee8727 omxmpeg2dec: mpeg-2 decoder should be able to handle mpeg-1 too 
https://bugzilla.gnome.org/show_bug.cgi?id=695879
 2013-03-16 13:21:51 +00:00
Josep Torra
8231c9068e omx: minor stylistic change for consistency with other similar code 2013-03-16 10:13:06 +01:00
Josep Torra
a5778efe16 omx: Clarify that loop task is also paused in EOS 2013-03-16 10:00:24 +01:00
Josep Torra
e16207f3dd omxvideoenec: Don't forget propagate flow return value upstream 2013-03-16 09:59:01 +01:00
Tim-Philipp Müller
c51afe9093 omx: improve debug logging some more 2013-03-15 13:17:18 +00:00
Sebastian Dröge
2b580837f5 omxvideodec: Make sure that the first frame we pass to OpenMAX is a sync frame 2013-03-15 14:09:45 +01:00
Sebastian Dröge
e1f94660f7 omx: Stop output port task after draining 2013-03-15 11:46:34 +01:00
Sebastian Dröge
35a13a2cea omx: Reset EOS flag in more places 2013-03-15 11:01:12 +01:00
Sebastian Dröge
84c6fd44d2 omxvideodec: Deallocate output buffers with the right function 2013-03-15 10:38:58 +01:00
Tim-Philipp Müller
d7862b927c omx: log commands as strings 
Makes logs easier to read.
 2013-03-15 09:29:56 +00:00
Tim-Philipp Müller
07e6ae99f1 omx: log states as strings 2013-03-15 09:29:55 +00:00
Tim-Philipp Müller
118345eef5 omx: log component name in debug messages 
Useful when we have more different components
active at the same time.
 2013-03-15 09:29:55 +00:00
Sebastian Dröge
047b3735cf omxvideodec: Don't interpolate timestamps 
We will get exactly one frame per input buffer and assigning
timestamps between frames if more than one OMX buffer is required
per frame easily confuses timestamp tracking in OMX.
 2013-03-15 09:51:42 +01:00
Sebastian Dröge
c59d8930ac omxvideodec: Give the codec_data the timestamp of the first frame and no duration 2013-03-15 09:51:34 +01:00
Sebastian Dröge
67dc871116 omx: Reset some more buffer fields as required 2013-03-14 17:26:51 +01:00
Sebastian Dröge
5bab4a05f0 omx: The hack to disable usage of EOS buffers is not necessary anymore on RPi 2013-03-14 17:01:08 +01:00
Sebastian Dröge
ec687f1414 omx: Reset the flags for output ports when releasing a buffer, not for input ports 2013-03-14 17:00:42 +01:00
Sebastian Dröge
02335ef953 omx: Only unref caps after usage of its fields 2013-03-14 15:03:02 +01:00
Sebastian Dröge
bda1e97abd omxvideodec: Simplify bufferpool implementation 2013-03-14 14:51:32 +01:00
Sebastian Dröge
9128ba5018 omxvideodec: Improve min/max buffer counts handling 2013-03-14 12:52:46 +01:00
Sebastian Dröge
22dce51dd4 omx: Handle the OMX_EventBufferFlag to detect EOS too 2013-03-14 12:51:54 +01:00
Sebastian Dröge
acf15e84a9 omx: Mark OpenMAX buffers as EGLImage if they contain one 
Needs special handling in some places, e.g. because nFilledLen
will always be 0.
 2013-03-13 13:10:28 +01:00
Sebastian Dröge
b9af5f4f31 omxvideoenc: Properly check the nVersion field 2013-03-13 10:21:49 +01:00
Sebastian Dröge
68c8196912 omxvideoenc: RPi returns garbage for OMX_IndexParamVideoBitrate, work around that 2013-03-13 09:38:07 +01:00
Sebastian Dröge
1ebd34e637 omxvideodec: Make sure to always get the right buffer 2013-03-13 09:38:03 +01:00
Sebastian Dröge
f4ad6e0858 omxvideodec: Make sure the buffer is released to the pool if it's not the one we wanted 2013-03-13 09:37:58 +01:00
Sebastian Dröge
ef357cce80 omxvideodec: Drop too late frames instead of finishing them 2013-03-13 09:37:43 +01:00
Sebastian Dröge
fa7be0b618 omx: Release buffers to the correct port 2013-03-13 09:37:36 +01:00
Sebastian Dröge
303b6c4dc5 omx: Always load the OpenMAX IL cores with G_MODULE_BIND_LOCAL 2013-03-13 09:37:02 +01:00
Sebastian Dröge
f505dad87a omx: Lazy-load symbols of libbcm_host.so 
It exports eglIntOpenMAXILDoneMarker(), which is also
exported by libopenmaxil.so... but we need the version
from libopenmaxil.so as the other one is just a stub.
 2013-03-13 09:35:20 +01:00
Sebastian Dröge
3544fa5ae3 omx: Don't set profile/level in other encoders if downstream caps don't specify any 2013-03-11 13:59:15 +01:00
Sebastian Dröge
77f95de529 omxh264enc: If caps specify no profile/level use the component's defaults 2013-03-11 13:49:38 +01:00
Sebastian Dröge
3c13502b75 omxvideoenc: Always allocate output buffers from the loop function 2013-03-11 13:45:04 +01:00
Sebastian Dröge
bd53faacc9 omxh264enc: The h264 encoders are supposed to output byte-stream/au 2013-03-11 13:13:22 +01:00
Sebastian Dröge
79a1fed0e0 omxvideoenc: Wait until the Executing state is reached before passing buffers to the component 2013-03-11 11:52:57 +01:00
Sebastian Dröge
448ea34b75 omxvideodec: Don't provide buffers to downstream 
This only works reliable if we have a way to tell downstream to
release all our buffers for reconfiguration.
 2013-03-11 10:39:25 +01:00
Sebastian Dröge
8bf902b69d omxaudioenc: Disable output port when setting a new format 2013-03-11 10:29:44 +01:00
Sebastian Dröge
f518ce5ed9 omxvideoenc: Disable output port when setting a new format 2013-03-11 10:29:30 +01:00
Sebastian Dröge
00be69f4a0 omxvideodec: Disable output port when setting a new format 
Based on a patch by Josep Torra <n770galaxy@gmail.com>
 2013-03-11 10:22:07 +01:00
Sebastian Dröge
65174bbd7f omx: Catch errors when releasing buffers to a port and handle them 2013-03-11 10:04:10 +01:00
Sebastian Dröge
eac2078056 omxvideoenc: Use the correct video codec state when filling an input buffer 2013-03-10 12:09:23 +01:00
Sebastian Dröge
98cf9f6fe2 omxvideoenc: Store correct input state 2013-03-10 12:05:50 +01:00
Sebastian Dröge
fb3b213b3e omxvideoenc: Allocate output buffers as early as possible 2013-03-10 11:31:55 +01:00
Sebastian Dröge
b9bf849a39 omx: Log unknown events 2013-03-10 11:03:18 +01:00
Josep Torra
bd071327da omx: Fix deadlock in encoders and add explainatory comments. 2013-03-09 14:14:40 +01:00
Josep Torra
7423e3e023 omxvideodec: fix printf format identifier 2013-03-09 13:27:08 +01:00
Josep Torra
cde5df17fa omx: Minor changes on debuging info 2013-03-09 13:24:30 +01:00
Josep Torra
6d8bf76391 omxvideodec: avoid a deadlock 2013-03-09 13:24:16 +01:00
Sebastian Dröge
aa6be53375 omxvideodec: Don't forget to populate output port 2013-03-08 15:58:01 +01:00
Sebastian Dröge
c014b1c9a3 omx: Flush and stop srcpad when configuring new caps 2013-03-08 15:50:20 +01:00
Sebastian Dröge
716adfa5be Revert "omx: use no-component-reconfigure hack on the Raspberry PI" 
This reverts commit e123b2089f.

It's not required anymore after the fix from the last commit.
 2013-03-07 17:40:21 +01:00
Sebastian Dröge
ed0de9d699 omxvideodec: Only negotiate a color format with downstream on the initial caps 2013-03-07 17:38:40 +01:00
Sebastian Dröge
bbd30a96bd omxvideodec: Make sure the output port is disabled while we allocate buffers 2013-03-07 17:29:43 +01:00
Sebastian Dröge
20c9ae0823 omx: Also wait for disabled output ports to be reconfigured 2013-03-07 17:27:05 +01:00
Sebastian Dröge
0cd96e8c6b omxvideodec: Add buffer pool for sharing OpenMAX memory with downstream 2013-03-07 14:10:12 +01:00
Sebastian Dröge
7a1eaec3b9 omx: Add timeout to the flush operation and move buffer populating to a separate function 2013-03-07 13:57:00 +01:00
Sebastian Dröge
001b7f0ed9 omx: Remove min buffer count hack for RPi again 
It's not necessary anymore
 2013-03-07 13:56:50 +01:00
Sebastian Dröge
60861f3990 omx: Do number of buffers configuration explicitely 2013-03-07 13:56:44 +01:00
Josep Torra
cc495aeb16 omxvideodec: fixes reconfiguration 
Avoid having fixed fields from previous caps on reconfiguration.
 2013-03-07 11:24:54 +01:00
Josep Torra
e123b2089f omx: use no-component-reconfigure hack on the Raspberry PI 2013-03-07 11:02:39 +01:00
Josep Torra
118c023f55 omxvideoenc: drop unused data member 2013-03-01 15:32:47 +01:00
Sebastian Dröge
0b348473fa omxvideoenc: And set it actually on the right port 2013-03-01 12:24:09 +01:00
Sebastian Dröge
eef92abf28 omxvideoenc: Set the coding type in the subclasses to the specific codec 2013-03-01 12:18:08 +01:00
Sebastian Dröge
42937eaea0 omxvideoenc: gst_omx_port_update_port_definition() returns a OMX_ERRORTYPE, not a gboolean 2013-03-01 11:49:53 +01:00
Sebastian Dröge
687a188dad omxvideo{dec,enc}: Don't use the input state if it wasn't set yet 2013-03-01 11:44:17 +01:00
Sebastian Dröge
d92fb127ae omxaudioenc: Only enable the output port after we know the output format 2013-03-01 11:25:04 +01:00
Sebastian Dröge
a53c5638e2 omxvideoenc: Only enable the output port after we know the output format 2013-03-01 11:24:56 +01:00
Sebastian Dröge
63e0d61971 omxvideodec: Only enable the output port after we know the output format 2013-03-01 11:21:25 +01:00
Sebastian Dröge
0bb816e32c omx: Handle errors more gracefully 2013-03-01 11:18:38 +01:00
Sebastian Dröge
aeec430261 omx: Return the OMX_ERRORTYPE from gst_omx_port_update_port_definition 2013-02-28 15:49:14 +01:00
Sebastian Dröge
dc0385d762 omx: Return port definition update errors 2013-02-28 15:38:28 +01:00
Sebastian Dröge
1dd6214f44 omx: Add hack for RPi for the minimum number of buffers required for a port 
The value in the port definition is invalid and the initial actual
buffer count should be used.
 2013-02-28 13:57:43 +01:00
Sebastian Dröge
5132a89331 omx: Always tell the component about the right number of buffers that we're going to allocate 2013-02-28 13:26:56 +01:00
Sebastian Dröge
59e92f955d omx: Invert assertion to let it express what was intended 2013-02-28 13:07:58 +01:00
Sebastian Dröge
1a906da409 omx: Add API for allocating a specific number of buffers and using EGLImages or buffers allocated elsewhere 2013-02-28 11:20:52 +01:00
Sebastian Dröge
e42faae652 omx: Refactor code flow a bit if output port settings have changed 2013-02-27 16:56:02 +01:00
Sebastian Dröge
b12610efd7 omx: Clean up port settings change handling 2013-02-27 15:50:20 +01:00
Josep Torra
26b69d99a2 omxvideodec: initialize param structure before using it 2013-02-27 11:30:14 +01:00
Josep Torra
b85358aff7 omxvideoenc: prevent a NULL pointer access 2013-02-27 10:21:39 +01:00
Josep Torra
3973425689 omxvideodec: prevent a NULL pointer access 2013-02-26 17:25:49 +01:00
Sebastian Dröge
8872afff1d omx: Fix deadlock during reconfiguration 2013-02-25 13:11:16 +01:00
Sebastian Dröge
5b45cb0810 omx: Auto-detect the port indizes if possible 2013-02-25 12:42:05 +01:00
Sebastian Dröge
3e090dd83b omx: Refactor querying of component supported caps into its own function 2013-02-25 11:42:38 +01:00
Sebastian Dröge
70368c31cd omx: Refactor waiting for buffers to be released by the component to a separate function 2013-02-25 10:41:12 +01:00
Sebastian Dröge
f79bbc302b omx: Add methods to set up and close a tunnel between components 2013-02-25 09:47:37 +01:00
Sebastian Dröge
fa9bf95c40 omxaudioenc: Rename component variable 2013-02-25 09:19:08 +01:00
Sebastian Dröge
92c7944499 omxvideoenc: Rename component variable 2013-02-25 09:19:08 +01:00
Sebastian Dröge
e08b801fea omxvideodec: Rename component variable 2013-02-25 09:19:08 +01:00
Josep Torra
71b4573a34 omxvideoenc: remove duplicated line 2013-02-22 16:27:33 +01:00
Sebastian Dröge
cba466b61c Retry loading libbcm_host.so without an absolute path if that failed 2013-02-22 10:42:08 +01:00
Sebastian Dröge
9ed06008cd Add OpenMAX IL target for Bellagio 
Not tested since a very long time though.
 2013-02-21 11:03:23 +01:00
Sebastian Dröge
cfafeabfa2 Allow using external OpenMAX IL headers 2013-02-21 10:59:29 +01:00
Sebastian Dröge
05819da94d Set default hacks for the RPI target and always initialize bcm_host 2013-02-21 10:08:07 +01:00
Sebastian Dröge
5d6d6ec2df omx: Add FIXME for the future 2013-02-12 11:55:39 +01:00
Sebastian Dröge
219a93bbaf omx: Some minor refactoring and cleanup 2013-02-12 11:49:21 +01:00
Sebastian Dröge
4399c0b96b omx: Don't access the port's buffers array if it wasn't allocated yet 2013-02-12 11:49:07 +01:00
Sebastian Dröge
dd3ad9e6d5 omx: Mark an array as const 2013-02-12 11:44:40 +01:00
Sebastian Dröge
c3bcc43db7 omx: Split enabling/disabling of port into sending the command and waiting for it 
This allows to do anything necessary after sending the command to actually let it finish
 2013-02-12 11:41:43 +01:00
Sebastian Dröge
58a093bc0c omx: Flushing is also allowed in Paused state 2013-02-12 11:37:38 +01:00
Sebastian Dröge
39672e70c4 omxvideoenc: Set stride, slice height and buffer size 2013-02-12 11:28:36 +01:00
Sebastian Dröge
044a88f838 omxvideoenc: Properly negotiate OMX color format with the component 2013-02-12 11:03:32 +01:00
Sebastian Dröge
023b542ad5 omxvideoenc: Implement getcaps() vfunc 2013-02-12 11:03:30 +01:00
Julian Scheel
3d7a50944d omx: add mpeg2 video decoder 
This adds a decoder class for mpeg2, as well as an extended
configuration for raspberry pi.

https://bugzilla.gnome.org/show_bug.cgi?id=692446

Signed-off-by: Julian Scheel <julian@jusst.de>
 2013-01-24 22:46:52 +00:00
Sebastian Dröge
5c4799ccf1 omx: Minimize the time when the messages lock is held 
Fixes a deadlock if any OMX functions are called when the
messages are handled.

Thanks to Nicolas Dufresne for noticing.
 2013-01-18 16:47:52 +01:00
Tim-Philipp Müller
453d81886d omx: improve debug message when we can't find the config file 
Mention where we looked for the config file.
 2013-01-18 15:28:20 +00:00
Sebastian Dröge
4044aaecbe omx: Fix includes to properly work with the 1.0 releases 2013-01-17 18:08:15 +01:00
Sebastian Dröge
e5bf204a1d omx: Update port definition when changing some port setting 2013-01-15 14:37:37 +01:00
Sebastian Dröge
449017b50b omx: Rename from libgstopenmax.so to ligstomx.so for consistency 2013-01-15 14:37:37 +01:00
Nicolas Dufresne
8c3bd103ff omx: Add a method to send message 2013-01-14 10:37:13 +01:00
Sebastian Dröge
2d913c6773 omx: Atomic ops are not required anymore for the reconfiguration 2013-01-14 10:37:06 +01:00
Sebastian Dröge
be31e7273b omx: Fix some memory leaks and suboptimal locking 2013-01-14 10:36:57 +01:00
Sebastian Dröge
bcb181bd2d omxvideoenc: Don't forget to unmap frame in error cases 2013-01-14 10:36:50 +01:00
Sebastian Dröge
25d5c55764 omxvideoenc: Fix copying of the video frames to the OMX buffers 2013-01-14 10:36:44 +01:00
Sebastian Dröge
2fd8d72c50 omxvideodec: Fix copying of the video frames from the OMX buffers 2013-01-14 10:36:38 +01:00