Commit graph

9 commits

Author SHA1 Message Date
Tim-Philipp Müller
699452ef31 Remove obsolete Android build cruft
This is not needed any longer.
2015-04-26 18:59:32 +01:00
Luis de Bethencourt
c944093d08 remove unused enum items PROP_LAST
This were probably added to the enums due to cargo cult programming and are
unused.
2015-04-24 16:48:26 +01:00
Luis de Bethencourt
5f4b9a2819 rtp: donl_present variable unused
donl_present is not implemented, yet the value is set and checked a few times.
Cleaning this.

CID 
2015-03-06 14:54:45 +00:00
Luis de Bethencourt
54ce23e0cb rtp: value truncated too short creates dead code
type is truncated to 0-31 with "& 0x1f", but right after that it is checks if
the value is equivalent to GST_H265_NAL_VPS, GST_H265_NAL_SPS, and
GST_H265_NAL_PPS (which are 32, 33, and 34 respectively). Obviously, this will
never be True if the value is maximum 31 after the truncation.
The intention of the code was to truncate to 0-63.
2015-01-08 15:36:04 +00:00
Luis de Bethencourt
66a08297c7 rtp: fix nal unit type check
After further investigation the previous commit is wrong. The code intended to
check if the type is 39 or the ranges 41-44 and 48-55. Just like gsth265parse.c
does. Type 40 would not be complete.
2015-01-08 15:27:44 +00:00
Luis de Bethencourt
20dc27f983 rtp: fix dead code and check for impossible values
nal_type is the index for a GstH265NalUnitType enum. There are two types of dead
code here:
First, after checking if nal_type is >= 39 there are two OR conditionals that
check if the value is in ranges higher than that number, so if nal_type >= 39
falls in the True branch those other conditions aren't checked and if it falls
in the False branch and they are checked, they will always also be False. They
are redundant.
Second, the enum has a range of 0 to 40. So the checks for ranges higher than 41
should never be True.
Removing this redundant checks.

CID 1249684
2015-01-08 13:58:13 +00:00
Sebastian Dröge
fff292438c rtpbad: Fix make dist by removing non-existing file from EXTRA_DIST
It's used by the rtp plugin in gst-plugins-good for VP8 but not needed
or used here.
2014-10-19 13:44:38 +02:00
Thijs Vermeir
a7ec281c43 rtpbad: include plugins base cflags (fix build on jenkins) 2014-10-17 16:51:27 +02:00
Thijs Vermeir
293522d418 rtp: add h265 RTP payloader + depayloader 2014-10-17 10:40:24 +02:00