He Junyan
04472c5adb
codecs: vp8decoder: Fix two typo of struct name.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1797 >
2020-11-11 18:52:37 +00:00
Seungha Yang
5342b05390
codecs: h264decoder: Fix missing drain handling in bumping
...
Should've included in the commit 5527cc4a2e
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1783 >
2020-11-09 14:40:06 +00:00
Seungha Yang
64c1218948
codecs: h264decoder: Try reference picture marking process in any case
...
... even if there is some invalid conditions
(because of broken stream, our implementation fault or so).
Otherwise baseclass will keep such reference pictures and
it would result to DPB full.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1783 >
2020-11-09 14:40:06 +00:00
Seungha Yang
81151145b2
codecs: h264decoder: Reset frame number per MMCO type 5
...
It should be cleared so that avoid wrong frame gap detection
for following pictures.
Passing 4 more conformance bitstream tests
* MR2_TANDBERG_E
* MR3_TANDBERG_B
* MR4_TANDBERG_C
* MR5_TANDBERG_C
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1768 >
2020-11-05 14:56:28 +00:00
Seungha Yang
e78dc91f9e
codecs: h264decoder: Fix for MMCO type 2
...
As per 8.2.5.4.2, we should mark a picture which has
LongTermPicNum == long_term_pic_num as "unused for reference",
not pic_num.
Passing conformance bitstream test with MR2_MW_A
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1768 >
2020-11-05 14:56:28 +00:00
Seungha Yang
0e53668a9b
codecs: h264picture: Add more trace log
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1768 >
2020-11-05 14:56:28 +00:00
Rafostar
5c31aeaaa4
doc: player: mention that get_pipeline method needs unref
...
All other methods in docs clearly mention that an unref is needed, so should `get_pipeline()`. #1450
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1764 >
2020-11-05 08:57:51 +00:00
Rafostar
40f1a34d10
player: call ref_sink on pipeline
...
Otherwise `gst_player_get_pipeline()` will return a floating reference which may confuse bindings and lead to crash.
Fixes #1450
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1763 >
2020-11-05 08:36:10 +00:00
Nicolas Dufresne
6f556518c8
h265parser: Fix wrong warning message
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1714 >
2020-11-04 17:53:23 +00:00
Nicolas Dufresne
c1502a2bdf
h265decoder: Remove unsued WpOffsetHalfRangeC
...
This is only needed for VA implementation of weight tables and isn't used
within the base class.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1714 >
2020-11-04 17:53:23 +00:00
Seungha Yang
5527cc4a2e
codecs: h264decoder: Rework for DPB management
...
Sync with recent h265decoder DPB implementation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1761 >
2020-11-05 02:26:47 +09:00
Seungha Yang
b70ceb4235
codecs: h264decoder: Remove unused pts variable
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1761 >
2020-11-05 00:33:34 +09:00
Seungha Yang
d1f397e754
codecs: h265picture: Minor update for coding style
...
It's GstH265Dpb, not GstH265Decoder
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1755 >
2020-11-02 20:20:56 +00:00
Seungha Yang
db10288382
codecs: h265decoder: Make GstVideoCodecFrame hold the last reference of the buffer
...
The functionality of passing the last reference of GstH265Picture
was silently dropped by the commit eeffd91109
This commit will make it work again.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1755 >
2020-11-02 20:20:56 +00:00
Seungha Yang
b69840711e
codecs: h265decoder: Clear GstVideoCodecFrame on DPB clear if needed
...
h265decoder might need to clear DPB depending on context even if
it's not flushing case. So associated GstVideoCodecFrame needs to be
released in case non-flushing case.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1755 >
2020-11-02 20:20:56 +00:00
Seungha Yang
16b4fe3d0b
codecs: h265decoder: Don't drain DPB on EOB/EOS/IDR nalu
...
DPB bumping decision per end-of-bitstream, end-of-sequence or IDR nal
should done by spec. In short, draining on EOB/EOS/IDR is undefined
behavior as per spec.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1755 >
2020-11-02 20:20:56 +00:00
Nicolas Dufresne
849b7a315c
h265decoder: Complete dependent slice header
...
This will save the last independent slice and fill in the missing
information for dependent slices. This was left over during the porting
from gstreamer-vaapi. The private variable prev_independent_slice was
already there.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1750 >
2020-11-02 18:20:32 +00:00
Nicolas Dufresne
e3fb5f894f
h265decoder: Prevent possible infinite loop
...
Theoretically, one could produce a broken stream that would lead to
infinite in the specified algorithm to calculate l0/l1 reference lists.
This patch will pearly exit if this condition is met.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1750 >
2020-11-02 18:20:32 +00:00
Nicolas Dufresne
2e2e93c303
h265parse: Add missing const qualifier
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1750 >
2020-11-02 18:20:32 +00:00
Seungha Yang
eeffd91109
codecs: h265decocer: Rework for DPB management
...
* Move all DPB bumping process into GstH265Dpb internal
* Handle DPB add process in GstH265Dpb struct
* Make implementation to be 1:1 mappable with hevc specification
* Fix wrong DPB bumping implementation especially when no_output_of_prior_pics_flag
was specified.
With fixes from Nicolas Dufresne <nicolas.dufresne@collabora.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1748 >
2020-11-01 21:46:12 +09:00
Olivier Crête
cca313ecd8
rtpsender: Add API to set the priority
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707 >
2020-10-30 16:24:40 -04:00
Olivier Crête
7be09a5f22
webrtc: Save the media kind in the transceiver
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707 >
2020-10-30 16:23:10 -04:00
Olivier Crête
78c687da3e
webrtc: Document more objects
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707 >
2020-10-30 16:23:10 -04:00
Thibault Saunier
a5fd2a4bc3
uritranscodebin: Move to using a urisourcebin for our source.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1151 >
2020-10-29 13:30:07 +00:00
Thibault Saunier
7d1f5e951f
transcoder: Base sync transcoding variant on a GMainLoop
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1151 >
2020-10-29 13:30:07 +00:00
He Junyan
002cddf131
codecs: h265decoder: Fix picture leaks because of reference set.
...
The last frame's reference set has no one to cleanup. We need to
clean all pictures in the stop() func.
We also add a helper function to cleanup all the pictures in the
reference picture set.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1717 >
2020-10-23 16:21:15 +00:00
He Junyan
4d296a07e4
codecs: h265decoder: Fix 3 ref array leaks in finalize.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1717 >
2020-10-23 16:21:15 +00:00
Xavier Claessens
2efb4a7adb
Meson: Use pkg-config generator
2020-10-23 11:14:18 -04:00
Nicolas Dufresne
f22fc190e7
h265decoder: Add support for l0/l1
...
Add support for reference list needed for VA-API and some V4L2 decoders.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1713 >
2020-10-21 09:05:57 -04:00
Nicolas Dufresne
f330b5ae62
h265decoder: Sync with the H264 implementation
...
This ensures that we get the last reference to picture being outputed,
avoiding GstBuffer structure copies and simplifying the buffer management.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1713 >
2020-10-21 09:05:57 -04:00
Víctor Manuel Jáquez Leal
113867766e
codecs: vp9decoder: Add segmentation to picture.
...
VA-API needs AC and DC quant scales for both luma and chroma, and the loop
filter level for current frame, but these values are not available outside
the private GstVp9Parser structure. And these values may change from frame
to frame, so they are picture specific.
This patch add GstVp9Segmentation structure array to GstVp9Picture to expose
it to derived classes. This approach is safer than passing the parser at
picture handling flow.
Also, this patch, in order to solve Documentation CI, mark as private the
GstVp9Picture structure.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1700 >
2020-10-16 17:50:42 +00:00
Víctor Manuel Jáquez Leal
5e3c7f2092
codecs: vp9decoder: Pass parser as new_sequence() parameter.
...
In order to know the chroma format, besides profile, subsampling_x and
subsampling_y are needed (Spec 7.2.2 Color config semantics). These values are
in GstVp9Parser but not in GstVp9Framehdr.
Also, bit_depth is available in parser but not frame header. Evenmore, those
values are copied to picture structure later.
In case of VA-API, to configure the pipeline, it is require to know the chroma
format and depth.
It is possible to know chroma and depth through caps coming from vp9parser, but
it requires string parsing. It would be less error prone to get these values
through the parser structure at new_sequence() virtual method.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1700 >
2020-10-16 17:50:42 +00:00
Andrew Wesie
11353b3f6e
codecparsers: h264parser: guard against ref_pic_markings overflow
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1703 >
2020-10-16 15:11:26 +00:00
He Junyan
6b3ff669ee
codecs: vp8decoder: handle the show_frame check in base class.
...
Move the show_frame check from sub class to vp8 decoder's base class.
Calling the sub class' output_picture() function only when the frame
is displayed and marking the other automatically as decode only.
This is done to avoid logic and code repetition in subclasses.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1670 >
2020-10-15 19:01:54 +00:00
Seungha Yang
a31a6608fe
codecs: vp9decoder: handle the show_frame check in base class
...
Same as vp8 decoder update https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1670
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1697 >
2020-10-15 18:36:54 +00:00
Sebastian Dröge
cc7e98816f
Revert "webrtc: Save the media kind in the transceiver"
...
This reverts commit f54d8e9945
.
It breaks the CI until the C# bindings are fixed.
2020-10-08 18:53:12 +03:00
Sebastian Dröge
a40d6f4994
Revert "rtpsender: Add API to set the priority"
...
This reverts commit a8b287c764
.
It breaks the CI until the C# bindings are fixed.
2020-10-08 18:53:10 +03:00
Sebastian Dröge
f12265d9c5
Revert "webrtc: Document more objects"
...
This reverts commit ad68c6b1eb
.
It breaks the CI until the C# bindings are fixed.
2020-10-08 18:52:50 +03:00
Sebastian Dröge
74a42c5ba8
Revert "webrtc: Add hotdoc style since tags"
...
This reverts commit 63a5fa818c
.
It breaks the CI until the C# bindings are fixed.
2020-10-08 18:51:37 +03:00
Olivier Crête
63a5fa818c
webrtc: Add hotdoc style since tags
...
We're stuck having to add a separate comment for now.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425 >
2020-10-06 16:52:48 -04:00
Olivier Crête
ad68c6b1eb
webrtc: Document more objects
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425 >
2020-10-06 16:49:08 -04:00
Olivier Crête
a8b287c764
rtpsender: Add API to set the priority
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425 >
2020-10-06 16:49:08 -04:00
Olivier Crête
f54d8e9945
webrtc: Save the media kind in the transceiver
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425 >
2020-10-06 16:49:08 -04:00
He Junyan
d90e353daa
codecparsers: vp8parser: clear the frame_hdr before parsing.
...
Uninited frame_hdr may have garbage and may contain some wrong
results after the parsing process.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1587 >
2020-09-25 17:07:43 +08:00
Víctor Manuel Jáquez Leal
3dd8276551
codecs: h264: unref leaked caps
...
Unref a leaked caps at set_latency().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1590 >
2020-09-23 11:52:47 +02:00
Haihao Xiang
4a93f6e651
h265parse: recognize more HEVC extension streams
...
There are streams which have the right general_profile_idc and
general_profile_compatibility_flag, but don't have the right extension
flags. We may try to use chroma_format_idc and bit_depth to
recognize these streams.
e.g.
https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/SCC/IBF_Disabled_A_MediaTek_2.zip
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1328 >
2020-09-16 16:51:45 +00:00
Haihao Xiang
626af12498
h265parser: select the right profile for high throughput SCC stream
...
Currently screen-extended-high-throughput-444 is recognized as
screen-extended-main-444, screen-extended-high-throughput-444-10 is
recognized as screen-extended-main-444-10 because they have the same
extension flags, so without this patch, it is possible that a decoder
which supports SCC but doesn't support throughput SCC will try to decode
a throughput SCC stream.
e.g.
https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/SCC/HT_A_SCC_Apple_2.zip
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1328 >
2020-09-16 16:51:45 +00:00
Seungha Yang
7f10f8a93e
codecs: vp9decoder: Relying on upstream vp9parse for super frame handling
...
By this way, we can simplify the decoding flow. Moreover, we don't
need to worry about the case where multiple visible-frames are
composed in one super-frame, since upstream vp9parse will split
them per frame unit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567 >
2020-09-15 15:54:53 +00:00
Seungha Yang
95db5e7182
codecs: vp9decoder: Remove unused pts variable
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567 >
2020-09-15 15:54:53 +00:00
Víctor Manuel Jáquez Leal
e0e37a0d92
codecs: h264decoder: Calculate and set latency
...
Add gst_h264_decoder_set_latency(), which calculates and sets
latency on base decoder class, after new_sequence is called.
This assumes that in new_sequence() vmethod, callee negotiates
downstream caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1531 >
2020-09-15 11:20:13 -04:00