Commit graph

4529 commits

Author SHA1 Message Date
Vittorio Palmisano
35dd89951d x264enc: fix up avcC header construction and playback by flash players
Fix off-by-one bug when constructing the avcC header chunk: we
wrote wrong profile info into the header. The first byte in the
SPS NAL we get from x264 is the nal type, not the profile_idc.

Also add some debug logging.

Fixes #610089.
2010-02-16 13:33:10 +00:00
Robert Swain
ad45fd1827 asfdemux: Improve seek behaviour for audio-only with no index
Instead of seeking to seek_time - 5s in the hope of hitting a keyframe
for video, we can just seek to seek_time instead.
2010-02-16 13:02:47 +01:00
Tim-Philipp Müller
bde03ffc01 configure: fix up GST_CXXFLAGS properly
We don't want C specific flags in GST_CXXFLAGS, so base it on the
GST_CFLAGS that only contains the pkg-config CFLAGS but none of
the GST_OPTION_CFLAGS. Also, we only need the local includes once.
2010-02-16 00:26:37 +00:00
Tim-Philipp Müller
f295a84433 Update MAINTAINERS, add myself 2010-02-16 00:26:36 +00:00
Stefan Kost
086528d359 configure: base GST_CXXFLAGS on --cflags from pkg-config
pkg-config sets GST_CFLAGS and GST_LIBS. We need to use CFLAGS as a starting
point for for both C and CXX settings.
2010-02-15 23:16:32 +02:00
Sebastian Dröge
cfe16b0e7c Automatic update of common submodule
From 96dc793 to 44ecce7
2010-02-14 23:18:44 +01:00
Tim-Philipp Müller
a5984e6b49 win32: change how win32/common/config.h is updated
Generate win32/common/config.h-new directly from config.h.in,
using shell variables in configure and some hard-coded information.
Change top-level makefile so that 'make win32-update' copies the
generated file to win32/common/config.h, which we keep in source
control. It's kept in source control so that the git tree is
buildable from VS.

This change is similar to the ones applied a while ago to GStreamer
core, gst-plugins-base and gst-plugins-good and prevents configure
from changing files in source control. The generated config.h
should be ok, but needs testing.
2010-02-01 09:27:58 +00:00
Tim-Philipp Müller
efc5181d13 rtspreal: don't construct config header with uninitialised bytes
Turns out 4 + 4 + 2 + (4 * 2) is actually 18 and not 22. This avoids
a presumably unintentional padding of uninitialised bytes at the end
of the CONT tags chunk, which should be harmless but causes warnings
in valgrind (see #608533 for a test URL).
2010-01-31 13:03:58 +00:00
Tim-Philipp Müller
cd6b16734e rtspreal: add finalize function so we can free streams and rulebook
Fix memory leak in Real RTSP component (#608533).
2010-01-30 19:15:15 +00:00
Tim-Philipp Müller
4cb5f32308 rtspreal: fix minor memory leak
Caps take their own reference when a buffer is added to them, so
unref buffer after adding it to caps (#608533).
2010-01-30 19:15:15 +00:00
Tim-Philipp Müller
29c509a7b8 rdtdepay: unref input buffer when done
Fixes memory leak, see #608533.
2010-01-30 19:15:15 +00:00
Tim-Philipp Müller
5aae2740b4 Automatic update of common submodule
From 15d47a6 to 96dc793
2010-01-30 15:19:56 +00:00
Mark Nauwelaerts
8a1414694d x264enc: make use of Access Unit delimiters configurable
API: GstX264Enc:aud
2010-01-29 19:47:03 +01:00
Thiago Santos
8f60eb26f3 asfdemux: Do not subtract padding twice
Only subtract implicit padding if an explicit one isn't
provided. Avoids subtracting it twice and causing
parsing errors.

Fixes #607698
2010-01-22 15:49:58 -03:00
Stefan Kost
da70785dcd assert: g_assert_not_reached() cannot replace return statement
Fix build with assert being turned off.
2010-01-22 16:55:14 +02:00
Tim-Philipp Müller
64545310d4 Automatic update of common submodule
From 14cec89 to 15d47a6
2010-01-20 00:55:12 +00:00
Edward Hervey
8829c5141a asfdemux: Don't forget to update flow variable
Forgot to update the return value in the loop.
2010-01-18 18:01:55 +01:00
Edward Hervey
bb20a20d86 asfdemux: Check flow return on every push
We previously only aggregated flow returns after the while(push) loop,
which meant that in some cases we would end-up not properly aggregating
the flow returns.

This is based on the same flow aggregation algorithm as oggdemux.
2010-01-18 17:51:57 +01:00
Thiago Santos
c77dfa7b9f x264enc: Add stream-format to output caps
Adds stream-format to output caps of x264enc that
informs if the stream is in bytestream of avc format.

Fixes #606662
2010-01-13 10:17:44 -03:00
Arnaud Patard
9094dc1bc6 xingmux: Fix unaligned memory access
ARM/SPARC need 32bit alignment but xingmux accesses possibly
unaligned memory, which leads to SIGBUS.

Fixes bug #586464.
2010-01-11 14:06:03 +01:00
Michael Smith
84d80fffcd asfdemux: Use GST_STR_NULL in a couple of places.
Fixes crashing on some of the log statements on win32.
2010-01-07 14:37:31 -08:00
Thiago Santos
6dd3525806 rmdemux: Parse and post bitrate for streams
Parse the bitrate of the streams and post their tags.

Fixes #599299
2010-01-07 16:36:08 -03:00
Thiago Santos
db73c4337d asfdemux: Post bitrate tag
If stream bitrate object is available, post the bitrate
tags.

Fixes #599297
2010-01-07 13:54:21 -03:00
Mark Nauwelaerts
8e5df1a902 mp3parse: minor validation check of (Xing, VBRI) metadata
... to detect e.g. a truncated file, rendering some of the metadata invalid.
2010-01-04 15:25:52 +01:00
Mark Nauwelaerts
b64f6065c2 mp3parse: use proper total_time and total_bytes in various cases
The correct basis for (Xing, VBRI) seek table calculations is the
byte size and duration provided by that metadata, rather than some
other (possibly even estimated) one.  This also prevents an infinite
conversion loop in (unlikely) case where a TOC is provided without
such corresponding (duration) metdata.
2010-01-04 15:25:50 +01:00
Thiago Santos
5e3f07b6a1 mp3parse: conserve stop time for non-accurate seek
Use the same strategy as accurate seeks to store
pending non-accurate seeks to avoid overwriting non-definite
stop times. When doing non-accurate seeks our position
reporting might drift off by some secs and the stream can
end up before it should.

Fixes #603695
2010-01-04 10:01:44 -03:00
Mark Nauwelaerts
6c05222326 Automatic update of common submodule
From 47cb23a to 14cec89
2009-12-21 19:12:59 +01:00
Tim-Philipp Müller
cd95215ba9 amrwbdec: give decoder a rank so decodebin/playbin will use it 2009-12-18 16:05:09 +00:00
Thiago Santos
ea7a9e550a mp3parse: return false when we can't seek
When upstream can't seek, we return false as well
2009-12-08 19:01:50 -03:00
Thiago Santos
82ab87032d lame: Avoid crash when seeking before negotiating
lame's 'lgv' variable is only initialized when the caps
is negotiated, whenever a seek happens before that, it would
attempt to call a function on an empty pointer, causing the crash.

Fixes #603515
2009-12-02 11:34:34 -03:00
Tim-Philipp Müller
21177487d9 Automatic update of common submodule
From 87bf428 to 47cb23a
2009-12-01 15:08:07 +00:00
Sebastian Dröge
d3942da482 Automatic update of common submodule
From da4c75c to 87bf428
2009-12-01 14:17:50 +01:00
Edward Hervey
945ed4c654 Automatic update of common submodule
From 53a2485 to da4c75c
2009-11-27 18:56:13 +01:00
Mark Nauwelaerts
9fe72b5da3 mp3parse: fix non-flushing seek
Specifically, in addition to clearing lots of variables/offsets
when receiving newsegment, also clear leftover data to match.
2009-11-26 15:58:57 +01:00
Olivier Crête
b7f37f9afb x264enc: Make upstream GstForceKeyUnit thread-safe
Also send the GstForceKeyUnit event downstream when an upstream on is received,
allowing muxers or payloaders to take appropriate actions.

https://bugzilla.gnome.org/show_bug.cgi?id=602556
2009-11-20 22:15:22 -05:00
Tim-Philipp Müller
53e9bb50d0 Automatic update of common submodule
From a3e3ce4 to 53a2485
2009-11-19 10:31:25 +00:00
Benjamin Gaignard
26290a698c asfdemux: Don't call strlen() on NULL pointers
Fixes bug #602280.
2009-11-18 09:58:39 +01:00
Thiago Santos
b4007d3c76 asfdemux: Remove old pads when new ones are added
The old pads were being removed before adding the new ones,
we should add the new ones first.

Fixes #599718
2009-11-09 15:02:05 -03:00
Thiago Santos
a155733bff asfdemux: Handle chained asfs on pull mode
Adds chained asfs handling to pull mode. It now checks if
there is a new asf header after the last packet (when it
is possible to know how many packets are) or it tries
checking if a processed packet that fails is an header
object.

Fixes #599718
2009-11-09 14:24:13 -03:00
Thiago Santos
dc65baacf6 asfdemux: properly do chained asfs on push mode
To properly do chained asfs work with playbin2, we need to
push eos on the old pads before removing them.

Fixes #599718
2009-11-09 14:23:04 -03:00
Thiago Santos
37e805ef24 asfdemux: add support for chained asfs (push mode)
Adds support for detecting and playing chained asfs
in push mode. asfdemux tries to detect a new asf start
by identifying the header object guid in a input buffer.
When it finds it, it resets its state, removing its pads
and creates new ones for the new file.
2009-11-06 18:59:30 -03:00
Tim-Philipp Müller
9e3e475f36 asfdemux: fix two small leaks 2009-11-05 18:33:09 +00:00
Tim-Philipp Müller
b84bf977b1 asfdemux: prefer WM/TrackNumber over WM/Track, it's more reliable
WM/Track has a 0 base but is often wrongly written as starting from 1,
so not as reliable as WM/TrackNumber which always starts from 1.
2009-11-05 18:19:58 +00:00
Tim-Philipp Müller
1c88985618 asfdemux: WM/Track starts counting from 0, adjust to start from 1 2009-11-05 18:11:55 +00:00
Tim-Philipp Müller
aa52dd1320 asfdemux: map WM/TrackNumber to GST_TAG_TRACK_NUMBER as well
There's both WM/Track and WM/TrackNumber.
2009-11-05 18:11:35 +00:00
Jan Schmidt
0cdfa3dcd2 a52dec: Fix debug statement: Pass pos variable instead of time() function 2009-11-04 15:52:09 +00:00
Jan Schmidt
be7f763882 dvdsubdec: Fix printf format string warning 2009-11-04 15:50:17 +00:00
Jan Schmidt
acd6f70515 asfdemux: Fix bogus variable used uninitialised warnings 2009-11-04 15:46:04 +00:00
Jan Schmidt
777d74390a po: Don't create backup .po files
As well as preventing creation of useless backup files, it works
around a bug in gettext 0.17 on OS/X
2009-11-04 13:56:00 +00:00
Michael Smith
2349f09e6a asfdemux: fix c99-style comments. 2009-10-29 11:39:13 -07:00