mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-04 13:45:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

ladspa: fix unbounded integer properties

Browse source 
Use a double instead of a plain float for intermediary
property values, so we have enough bits to store INT_MAX
and it doesn't get rounded and wrapped to -1 when cast
back to a 32-bit integer.

Fixes criticals like

  g_param_spec_int: assertion 'default_value >= minimum && default_value <= maximum' failed

when loading LADSPA plugins from the Linux Studio Plugins
Project (http://lsp-plug.in) in GStreamer.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1194
This commit is contained in:
Tim-Philipp Müller 2020-02-05 16:03:06 +00:00
parent 352bf28a35
commit ffd3e189de
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/ladspa/gstladspautils.c
View file

@ -346,7 +346,7 @@ gst_ladspa_object_class_get_param_spec (GstLADSPAClass * ladspa_class,
GParamSpec *ret;
gchar *name;
gint hintdesc, perms;
gfloat lower, upper, def;
gdouble lower, upper, def;
name =
gst_ladspa_object_class_get_param_name (ladspa_class, object_class,