mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-02 20:42:30 +00:00
Code Issues 1 Projects Releases Wiki Activity

ladspa: Don't try and load every file as a plugin

Browse source 
When scanning paths for LADSPA plugins, don't try and load
every random file as a module, as g_module_open ends up throwing
errors on Windows.

Use a G_MODULE_SUFFIX and GST_EXTRA_MODULE_SUFFIX suffix check as
we do for GStreamer plugins.

https://bugzilla.gnome.org/show_bug.cgi?id=796450
This commit is contained in:
Jan Schmidt 2018-07-22 09:52:23 +10:00
parent 1b095e9609
commit ff736c730d
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ext/ladspa/gstladspa.c
View file

@ -302,7 +302,19 @@ ladspa_plugin_directory_search (GstPlugin * ladspa_plugin, const char *dir_name)
return FALSE; return FALSE;
while ((entry_name = g_dir_read_name (dir))) { while ((entry_name = g_dir_read_name (dir))) {
/* Only attempt to open files with the module suffixes */
if (!g_str_has_suffix (entry_name, "." G_MODULE_SUFFIX)
#ifdef GST_EXTRA_MODULE_SUFFIX
&& !g_str_has_suffix (entry_name, GST_EXTRA_MODULE_SUFFIX)
#endif
) {
GST_TRACE ("Ignoring file %s as it has the wrong suffix for a plugin",
entry_name);
continue;
}
file_name = g_build_filename (dir_name, entry_name, NULL); file_name = g_build_filename (dir_name, entry_name, NULL);
GST_LOG ("Probing file %s as a LADSPA plugin", file_name);
plugin = plugin =
g_module_open (file_name, G_MODULE_BIND_LAZY | G_MODULE_BIND_LOCAL); g_module_open (file_name, G_MODULE_BIND_LAZY | G_MODULE_BIND_LOCAL);
if (plugin) { if (plugin) {