mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-25 11:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "gstnetclockclient: signal lost sync if remote time resets"

Browse source 
This reverts commit 779e715b6c.

Since the introduced corrupt clock state for when discovering a time
server restart, this resulted in previous similar check as done in
this patch became ignored/jumped over (in case of the corrupt state
has been noticed).

Reference: df41d11a7d
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7664>
This commit is contained in:
Robert Rosengren 2024-10-14 14:46:53 +02:00 committed by GStreamer Marge Bot
parent 3f6bde317e
commit ff6ad49557
1 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
subprojects/gstreamer/libs/gst/net/gstnetclientclock.c
View file

@ -147,7 +147,6 @@ struct _GstNetClientInternalClock
GstClockTime minimum_update_interval;
GstClockTime last_remote_poll_interval;
GstClockTime last_remote_time;
GstClockTime remote_avg_old;
guint skipped_updates;
GstClockTime last_rtts[MEDIAN_PRE_FILTERING_WINDOW];
gint last_rtts_missing;
@ -235,7 +234,6 @@ gst_net_client_internal_clock_init (GstNetClientInternalClock * self)
self->skipped_updates = 0;
self->last_rtts_missing = MEDIAN_PRE_FILTERING_WINDOW;
self->marked_corrupted = FALSE;
self->remote_avg_old = 0;
}
static void
@ -531,20 +529,6 @@ gst_net_client_internal_clock_observe_times (GstNetClientInternalClock * self,
&& GST_CLOCK_DIFF (time_before,
remote_avg) < (GstClockTimeDiff) (max_discont));
/* Check if new remote_avg is less than before to detect if signal lost
* sync due to the remote clock has restarted. Then the new remote time will
* be less than the previous time which should not happen if increased in a
* monotonic way. Also, only perform this check on a synchronized clock to
* avoid startup issues.
*/
if (synched) {
if (remote_avg < self->remote_avg_old) {
gst_clock_set_synced (GST_CLOCK (self), FALSE);
} else {
self->remote_avg_old = remote_avg;
}
}
if (gst_clock_add_observation_unapplied (GST_CLOCK_CAST (self),
local_avg, remote_avg, &r_squared, &internal_time, &external_time,
&rate_num, &rate_den)) {