ext/lame/gstlame.c: Round up not allowed bitrates to the next higher allowed one (Closes: #361140).

Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_set_property):
Round up not allowed bitrates to the next higher allowed one
(Closes: #361140).
This commit is contained in:
Tim-Philipp Müller 2006-10-13 14:45:11 +00:00
parent 4b121d4b0d
commit fef9929a06

View file

@ -625,6 +625,25 @@ gst_lame_init (GstLame * lame)
GST_DEBUG_OBJECT (lame, "done initializing"); GST_DEBUG_OBJECT (lame, "done initializing");
} }
#define CHECK_AND_FIXUP_BITRATE(obj,pspec,rate) \
G_STMT_START { \
gint ___rate = rate; \
if (rate <= 64 && (rate % 8) != 0) { \
___rate = GST_ROUND_UP_8 (rate); \
} else if (rate <= 128 && (rate % 16) != 0) { \
___rate = GST_ROUND_UP_16 (rate); \
} else if (rate <= 256 && (rate % 32) != 0) { \
___rate = GST_ROUND_UP_32 (rate); \
} else if (rate <= 320 && (rate % 64) != 0) { \
___rate = GST_ROUND_UP_64 (rate); \
} \
if (___rate != rate) { \
GST_WARNING_OBJECT (obj, "Bitrate %d not allowed for property '%s', " \
"changing to %d", rate, g_param_spec_get_name (pspec), ___rate); \
rate = ___rate; \
} \
} G_STMT_END
static void static void
gst_lame_set_property (GObject * object, guint prop_id, const GValue * value, gst_lame_set_property (GObject * object, guint prop_id, const GValue * value,
GParamSpec * pspec) GParamSpec * pspec)
@ -636,6 +655,7 @@ gst_lame_set_property (GObject * object, guint prop_id, const GValue * value,
switch (prop_id) { switch (prop_id) {
case ARG_BITRATE: case ARG_BITRATE:
lame->bitrate = g_value_get_int (value); lame->bitrate = g_value_get_int (value);
CHECK_AND_FIXUP_BITRATE (object, pspec, lame->bitrate);
break; break;
case ARG_COMPRESSION_RATIO: case ARG_COMPRESSION_RATIO:
lame->compression_ratio = g_value_get_float (value); lame->compression_ratio = g_value_get_float (value);
@ -684,12 +704,15 @@ gst_lame_set_property (GObject * object, guint prop_id, const GValue * value,
break; break;
case ARG_VBR_MIN_BITRATE: case ARG_VBR_MIN_BITRATE:
lame->vbr_min_bitrate = g_value_get_int (value); lame->vbr_min_bitrate = g_value_get_int (value);
CHECK_AND_FIXUP_BITRATE (object, pspec, lame->vbr_min_bitrate);
break; break;
case ARG_VBR_MAX_BITRATE: case ARG_VBR_MAX_BITRATE:
lame->vbr_max_bitrate = g_value_get_int (value); lame->vbr_max_bitrate = g_value_get_int (value);
CHECK_AND_FIXUP_BITRATE (object, pspec, lame->vbr_max_bitrate);
break; break;
case ARG_VBR_HARD_MIN: case ARG_VBR_HARD_MIN:
lame->vbr_hard_min = g_value_get_int (value); lame->vbr_hard_min = g_value_get_int (value);
CHECK_AND_FIXUP_BITRATE (object, pspec, lame->vbr_hard_min);
break; break;
case ARG_LOWPASS_FREQ: case ARG_LOWPASS_FREQ:
lame->lowpass_freq = g_value_get_int (value); lame->lowpass_freq = g_value_get_int (value);