mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 03:29:50 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtpsession: fix crash when no extension-header present for twcc

Browse source
This commit is contained in:
Håvard Graff 2020-02-24 13:06:27 +00:00 committed by Jan Schmidt
parent ce802f033c
commit fdf002d069
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst/rtpmanager/rtpsession.c
View file

@ -2173,7 +2173,8 @@ packet_info_get_twcc_seqnum (RTPPacketInfo * pinfo, guint8 ext_id)
gpointer data;
guint size;
if (gst_rtp_buffer_get_extension_onebyte_header_from_bytes (pinfo->header_ext,
if (pinfo->header_ext &&
gst_rtp_buffer_get_extension_onebyte_header_from_bytes (pinfo->header_ext,
pinfo->header_ext_bit_pattern, ext_id, 0, &data, &size)) {
if (size == 2)
val = GST_READ_UINT16_BE (data);

15
tests/check/elements/rtpsession.c
View file

@ -3540,6 +3540,20 @@ GST_START_TEST (test_twcc_recv_rtcp_reordered)
GST_END_TEST;
GST_START_TEST (test_twcc_no_exthdr_in_buffer)
{
SessionHarness *h = session_harness_new ();
session_harness_set_twcc_recv_ext_id (h, TEST_TWCC_EXT_ID);
fail_unless_equals_int (GST_FLOW_OK,
session_harness_recv_rtp (h, generate_test_buffer (0, 1234)));
session_harness_free (h);
}
GST_END_TEST;
GST_START_TEST (test_twcc_send_and_recv)
{
SessionHarness *h_send = session_harness_new ();
@ -3667,6 +3681,7 @@ rtpsession_suite (void)
tcase_add_test (tc_chain, test_twcc_double_gap);
tcase_add_test (tc_chain, test_twcc_recv_packets_reordered);
tcase_add_test (tc_chain, test_twcc_recv_rtcp_reordered);
tcase_add_test (tc_chain, test_twcc_no_exthdr_in_buffer);
tcase_add_test (tc_chain, test_twcc_send_and_recv);
return s;