mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-02 20:42:30 +00:00
Code Issues 1 Projects Releases Wiki Activity

autodetect: demote candidate error to warning and plug fake{sink,src}

Browse source 
In the case where we have no suitable candidate we post a warning and plug a
fake-element. Do the same when non of the candidate work.

This is more consistent and plugin the fakesink as a fallback is probably
helpful for running unit tests without requiring hardware src/sink elements.

Fixes #722981
This commit is contained in:
Stefan Sauer 2014-02-22 20:19:49 +01:00
parent 433d4f902d
commit fdb5d460de
1 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
gst/autodetect/gstautodetect.c
View file

@ -313,20 +313,27 @@ gst_auto_detect_find_best (GstAutoDetect * self)
GST_DEBUG_OBJECT (self, "done trying"); GST_DEBUG_OBJECT (self, "done trying");
if (!choice) { if (!choice) {
/* We post a warning and plug a fake-element. This is convenient for running
* tests without requiring hardware src/sinks. */
if (errors) { if (errors) {
/* FIXME: we forward the first error for now; but later on it might make GError *err = NULL;
* sense to actually analyse them */ gchar *dbg = NULL;
message = gst_message_ref (GST_MESSAGE (errors->data));
GST_DEBUG_OBJECT (self, "reposting message %p", message); /* FIXME: we forward the first message for now; but later on it might make
gst_element_post_message (GST_ELEMENT_CAST (self), message); * sense to forward all so that apps can actually analyse them. */
gst_message_parse_error (GST_MESSAGE (errors->data), &err, &dbg);
gst_element_post_message (GST_ELEMENT_CAST (self),
gst_message_new_warning (GST_OBJECT_CAST (self), err, dbg));
g_error_free (err);
g_free (dbg);
} else { } else {
/* send warning message to application and use a fakesrc */ /* send warning message to application and use a fakesrc */
GST_ELEMENT_WARNING (self, RESOURCE, NOT_FOUND, (NULL), GST_ELEMENT_WARNING (self, RESOURCE, NOT_FOUND, (NULL),
("Failed to find a usable %s %s", self->media_klass_lc, ("Failed to find a usable %s %s", self->media_klass_lc,
self->type_klass_lc)); self->type_klass_lc));
choice = gst_auto_detect_create_fake_element (self);
gst_element_set_state (choice, GST_STATE_READY);
} }
choice = gst_auto_detect_create_fake_element (self);
gst_element_set_state (choice, GST_STATE_READY);
} }
gst_object_unref (bus); gst_object_unref (bus);
gst_plugin_feature_list_free (list); gst_plugin_feature_list_free (list);