mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-06 07:28:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

oggmux: use oggstream to decide which BOS packets to place first

Browse source 
Ogg recommends video BOS packets to be first.
Use the "is_video" flag in oggstream to select those, rather than
check for known mime types.

https://bugzilla.gnome.org/show_bug.cgi?id=656775
This commit is contained in:
Vincent Penquerc'h 2011-08-17 18:38:39 +01:00 committed by Sebastian Dröge
parent 5bbf7109ec
commit fd8434fc74
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
ext/ogg/gstoggmux.c
View file

@ -1232,25 +1232,23 @@ gst_ogg_mux_send_headers (GstOggMux * mux)
GST_LOG_OBJECT (mux, "swapped out page with mime type %s", GST_LOG_OBJECT (mux, "swapped out page with mime type %s",
gst_structure_get_name (structure)); gst_structure_get_name (structure));
/* quick hack: put Theora, VP8 and Dirac video pages at the front. /* quick hack: put video pages at the front.
* Ideally, we would have a settable enum for which Ogg * Ideally, we would have a settable enum for which Ogg
* profile we work with, and order based on that. * profile we work with, and order based on that.
* (FIXME: if there is more than one video stream, shouldn't we only put * (FIXME: if there is more than one video stream, shouldn't we only put
* one's BOS into the first page, followed by an audio stream's BOS, and * one's BOS into the first page, followed by an audio stream's BOS, and
* only then followed by the remaining video and audio streams?) */ * only then followed by the remaining video and audio streams?) */
if (gst_structure_has_name (structure, "video/x-theora")) { if (pad->map.is_video) {
GST_DEBUG_OBJECT (thepad, "putting %s page at the front", "Theora"); GST_DEBUG_OBJECT (thepad, "putting %s page at the front",
hbufs = g_list_prepend (hbufs, hbuf); gst_structure_get_name (structure));
} else if (gst_structure_has_name (structure, "video/x-dirac")) {
GST_DEBUG_OBJECT (thepad, "putting %s page at the front", "Dirac");
hbufs = g_list_prepend (hbufs, hbuf);
pad->always_flush_page = TRUE;
} else if (gst_structure_has_name (structure, "video/x-vp8")) {
GST_DEBUG_OBJECT (thepad, "putting %s page at the front", "VP8");
hbufs = g_list_prepend (hbufs, hbuf); hbufs = g_list_prepend (hbufs, hbuf);
} else { } else {
hbufs = g_list_append (hbufs, hbuf); hbufs = g_list_append (hbufs, hbuf);
} }
if (gst_structure_has_name (structure, "video/x-dirac")) {
pad->always_flush_page = TRUE;
}
gst_caps_unref (caps); gst_caps_unref (caps);
} }