mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-12-25 17:50:36 +00:00
tools: deprecate gst-xmllaunch and print fat warning if someone tries to use it
Pipeline serialisation to and from XML is horribly broken for all but the most simple use cases, and will likely never be fixed. Make sure everyone playing around with these tools is aware of this, to avoid frustration. See countless bug reports in bugzilla.
This commit is contained in:
parent
1210e4a006
commit
fd64c4b255
2 changed files with 12 additions and 0 deletions
|
@ -779,6 +779,10 @@ main (int argc, char *argv[])
|
||||||
memcpy (argvn, argv + 1, sizeof (char *) * (argc - 1));
|
memcpy (argvn, argv + 1, sizeof (char *) * (argc - 1));
|
||||||
#ifndef GST_DISABLE_LOADSAVE
|
#ifndef GST_DISABLE_LOADSAVE
|
||||||
if (strstr (argv[0], "gst-xmllaunch")) {
|
if (strstr (argv[0], "gst-xmllaunch")) {
|
||||||
|
/* FIXME 0.11: remove xmllaunch entirely */
|
||||||
|
g_warning ("gst-xmllaunch is deprecated and broken for all but the most "
|
||||||
|
"simple pipelines. It will most likely be removed in future. Don't "
|
||||||
|
"use it.\n");
|
||||||
pipeline = xmllaunch_parse_cmdline ((const gchar **) argvn);
|
pipeline = xmllaunch_parse_cmdline ((const gchar **) argvn);
|
||||||
} else
|
} else
|
||||||
#endif
|
#endif
|
||||||
|
@ -812,6 +816,10 @@ main (int argc, char *argv[])
|
||||||
}
|
}
|
||||||
#ifndef GST_DISABLE_LOADSAVE
|
#ifndef GST_DISABLE_LOADSAVE
|
||||||
if (savefile) {
|
if (savefile) {
|
||||||
|
g_warning ("Pipeline serialization to XML is deprecated and broken for "
|
||||||
|
"all but the most simple pipelines. It will most likely be removed "
|
||||||
|
"in future. Don't use it.\n");
|
||||||
|
|
||||||
gst_xml_write_file (GST_ELEMENT (pipeline), fopen (savefile, "w"));
|
gst_xml_write_file (GST_ELEMENT (pipeline), fopen (savefile, "w"));
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
|
@ -23,6 +23,10 @@ You can pass "-" as the XML\-FILE to read from stdin.
|
||||||
XML\-FILE can be a URI as well, thanks to the wizardry of libxml. I'm not really
|
XML\-FILE can be a URI as well, thanks to the wizardry of libxml. I'm not really
|
||||||
sure what all is supported, it seems http works just fine though.
|
sure what all is supported, it seems http works just fine though.
|
||||||
|
|
||||||
|
.
|
||||||
|
.SH "WARNING"
|
||||||
|
\fIgst\-xmllaunch\fP is deprecated and broken for all but the most simple
|
||||||
|
pipelines. It will most likely be removed in future. Don't use it.
|
||||||
.
|
.
|
||||||
.SH "OPTIONS"
|
.SH "OPTIONS"
|
||||||
.l
|
.l
|
||||||
|
|
Loading…
Reference in a new issue