mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

gdppay: use public API for accessing stream header arrays in caps

Browse source 
Don't rely on core implementation details, which are private and
may change. It's also not needed here, the performance impact is
close to none. Also copy buffer before changing its metadata.
This commit is contained in:
Tim-Philipp Müller 2014-12-26 11:48:56 +00:00
parent ad25461dac
commit fd429d3233
1 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
gst/gdp/gstgdppay.c
View file

@ -289,22 +289,24 @@ gst_gdp_pay_reset_streamheader (GstGDPPay * this)
structure = gst_caps_get_structure (this->caps, 0);
if (gst_structure_has_field (structure, "streamheader")) {
const GValue *sh;
GArray *buffers;
GstBuffer *buffer;
int i;
int i, num;
sh = gst_structure_get_value (structure, "streamheader");
buffers = g_value_peek_pointer (sh);
num = gst_value_array_get_size (sh);
GST_DEBUG_OBJECT (this,
"Need to serialize %d incoming streamheader buffers on ours",
buffers->len);
for (i = 0; i < buffers->len; ++i) {
GValue *bufval;
"Need to serialize %d incoming streamheader buffers on ours", num);
for (i = 0; i < num; ++i) {
const GValue *bufval;
GstBuffer *outbuffer;
bufval = &g_array_index (buffers, GValue, i);
buffer = g_value_peek_pointer (bufval);
bufval = gst_value_array_get_value (sh, i);
buffer = gst_value_get_buffer (bufval);
/* Make copy before modifying buffer metadata */
buffer = gst_buffer_copy (buffer);
/* this buffer is deserialized by gdpdepay as a regular buffer,
it needs HEADER, because it's a streamheader - otherwise it
is mixed with regular data buffers */
@ -314,6 +316,9 @@ gst_gdp_pay_reset_streamheader (GstGDPPay * this)
GST_BUFFER_TIMESTAMP (buffer) = GST_CLOCK_TIME_NONE;
outbuffer = gst_gdp_pay_buffer_from_buffer (this, buffer);
gst_buffer_unref (buffer);
if (!outbuffer) {
g_value_unset (&array);
goto no_buffer;