mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

vulkandisplay: fix use-after-free with removal of window

Browse source 
g_list_delete_link() free()'s the list node so any access after that is
a use-after-free.
This commit is contained in:
Matthew Waters 2019-08-22 14:55:40 +10:00
parent e83df1759d
commit fc9f047885
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst-libs/gst/vulkan/gstvkdisplay.c
View file

@ -363,9 +363,10 @@ gst_vulkan_display_remove_window (GstVulkanDisplay * display,
GST_OBJECT_LOCK (display); GST_OBJECT_LOCK (display);
l = _find_window_list_item (display, window); l = _find_window_list_item (display, window);
if (l) { if (l) {
GWeakRef *ref = l->data;
display->windows = g_list_delete_link (display->windows, l); display->windows = g_list_delete_link (display->windows, l);
g_weak_ref_clear (l->data); g_weak_ref_clear (ref);
g_free (l->data); g_free (ref);
ret = TRUE; ret = TRUE;
} }
GST_OBJECT_UNLOCK (display); GST_OBJECT_UNLOCK (display);