mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-30 20:59:44 +00:00
Code Issues 1 Projects Releases Wiki Activity

formatter: Plug leaks in the can_save_to_uri method

Browse source 
https://bugzilla.gnome.org/show_bug.cgi?id=679941
This commit is contained in:
Thibault Saunier 2013-08-20 08:22:24 -04:00
parent 0c87104955
commit fbe18c9ed1
1 changed files with 18 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
ges/ges-formatter.c
View file

@ -266,6 +266,7 @@ ges_formatter_can_save_uri (const gchar * uri, GError ** error)
{ {
GFile *file = NULL; GFile *file = NULL;
GFile *dir = NULL; GFile *dir = NULL;
gboolean ret = TRUE;
GFileInfo *info = NULL; GFileInfo *info = NULL;
if (!(gst_uri_is_valid (uri))) { if (!(gst_uri_is_valid (uri))) {
@ -282,15 +283,14 @@ ges_formatter_can_save_uri (const gchar * uri, GError ** error)
/* Check if URI or parent directory is writeable */ /* Check if URI or parent directory is writeable */
file = g_file_new_for_uri (uri); file = g_file_new_for_uri (uri);
if (g_file_query_file_type (file, G_FILE_QUERY_INFO_NONE, NULL) if (g_file_query_file_type (file, G_FILE_QUERY_INFO_NONE, NULL)
== G_FILE_TYPE_DIRECTORY) { == G_FILE_TYPE_DIRECTORY) {
dir = file; dir = g_object_ref (file);
} else { } else {
dir = g_file_get_parent (file); dir = g_file_get_parent (file);
if (dir == NULL) if (dir == NULL)
return FALSE; goto error;
} }
info = g_file_query_info (dir, G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE, info = g_file_query_info (dir, G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE,
@ -299,25 +299,34 @@ ges_formatter_can_save_uri (const gchar * uri, GError ** error)
if (error && *error != NULL) { if (error && *error != NULL) {
GST_ERROR ("Unable to write to directory: %s", (*error)->message); GST_ERROR ("Unable to write to directory: %s", (*error)->message);
return FALSE; goto error;
} else { } else {
gboolean writeable = g_file_info_get_attribute_boolean (info, gboolean writeable = g_file_info_get_attribute_boolean (info,
G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE); G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE);
if (!writeable) { if (!writeable) {
GST_ERROR ("Unable to write to directory"); GST_ERROR ("Unable to write to directory");
return FALSE; goto error;
} }
} }
g_object_unref (file); done:
g_object_unref (dir); if (file)
g_object_unref (info); g_object_unref (file);
if (dir)
g_object_unref (dir);
if (info)
g_object_unref (info);
/* TODO: implement file format registry */ /* TODO: implement file format registry */
/* TODO: search through the registry and chose a GESFormatter class that can /* TODO: search through the registry and chose a GESFormatter class that can
* handle the URI.*/ * handle the URI.*/
return TRUE; return ret;
error:
ret = FALSE;
goto done;
} }
/** /**