mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-06 07:28:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

goom: the structure is not fully initialized, but the copied.

Browse source 
Set to fully to 0 to avoid creep of uninitialized values.
This commit is contained in:
Stefan Kost 2009-03-31 16:42:15 +03:00
parent ef7bcf7bd1
commit fa8e2d9bfe
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst/goom/plugin_info.c
View file

@ -109,7 +109,7 @@ void
plugin_info_init (PluginInfo * pp, int nbVisuals) plugin_info_init (PluginInfo * pp, int nbVisuals)
{ {
PluginInfo p; PluginInfo p = { 0, };
int i; int i;
p.sound.speedvar = p.sound.accelvar = p.sound.totalgoom = 0; p.sound.speedvar = p.sound.accelvar = p.sound.totalgoom = 0;
@ -147,6 +147,7 @@ plugin_info_init (PluginInfo * pp, int nbVisuals)
p.nbVisuals = nbVisuals; p.nbVisuals = nbVisuals;
p.visuals = (VisualFX **) malloc (sizeof (VisualFX *) * nbVisuals); p.visuals = (VisualFX **) malloc (sizeof (VisualFX *) * nbVisuals);
/* huh, we're setting a local variable and now copying it over? */
*pp = p; *pp = p;
pp->sound.params.params[0] = &pp->sound.biggoom_speed_limit_p; pp->sound.params.params[0] = &pp->sound.biggoom_speed_limit_p;
pp->sound.params.params[1] = &pp->sound.biggoom_factor_p; pp->sound.params.params[1] = &pp->sound.biggoom_factor_p;