formatter: Duplicate const gchar* for metadatas

This commit is contained in:
Thibault Saunier 2019-03-11 19:25:23 -03:00
parent d7b0e50b07
commit fa7a5db1fc
2 changed files with 20 additions and 15 deletions

View file

@ -100,6 +100,11 @@ _register_metas (GESExtractableInterface * iface, GObjectClass * class,
ges_meta_container_register_meta_string (container, GES_META_READ_WRITE, ges_meta_container_register_meta_string (container, GES_META_READ_WRITE,
GES_META_FORMAT_VERSION, NULL); GES_META_FORMAT_VERSION, NULL);
g_clear_pointer (&fclass->name, g_free);
g_clear_pointer (&fclass->description, g_free);
g_clear_pointer (&fclass->extension, g_free);
g_clear_pointer (&fclass->mimetype, g_free);
return TRUE; return TRUE;
} }
@ -124,11 +129,11 @@ ges_formatter_class_init (GESFormatterClass * klass)
klass->save_to_uri = NULL; klass->save_to_uri = NULL;
/* We set dummy metas */ /* We set dummy metas */
klass->name = "base-formatter"; klass->name = g_strdup ("base-formatter");
klass->extension = "noextension"; klass->extension = g_strdup ("noextension");
klass->description = "Formatter base class, you should give" klass->description = g_strdup ("Formatter base class, you should give"
" a name to your formatter"; " a name to your formatter");
klass->mimetype = "No mimetype"; klass->mimetype = g_strdup ("No mimetype");
klass->version = 0.0; klass->version = 0.0;
klass->rank = GST_RANK_NONE; klass->rank = GST_RANK_NONE;
} }
@ -440,13 +445,13 @@ ges_formatter_get_default (void)
void void
ges_formatter_class_register_metas (GESFormatterClass * class, ges_formatter_class_register_metas (GESFormatterClass * class,
const gchar * name, const gchar * description, const gchar * extension, const gchar * name, const gchar * description, const gchar * extensions,
const gchar * mimetype, gdouble version, GstRank rank) const gchar * mimetype, gdouble version, GstRank rank)
{ {
class->name = name; class->name = g_strdup (name);
class->description = description; class->description = g_strdup (description);
class->extension = extension; class->extension = g_strdup (extensions);
class->mimetype = mimetype; class->mimetype = g_strdup (mimetype);
class->version = version; class->version = version;
class->rank = rank; class->rank = rank;

View file

@ -130,10 +130,10 @@ struct _GESFormatterClass {
GESFormatterSaveToURIMethod save_to_uri; GESFormatterSaveToURIMethod save_to_uri;
/* < private > */ /* < private > */
const gchar *name; gchar *name;
const gchar *description; gchar *description;
const gchar *extension; gchar *extension;
const gchar *mimetype; gchar *mimetype;
gdouble version; gdouble version;
GstRank rank; GstRank rank;
@ -149,7 +149,7 @@ GES_API
void ges_formatter_class_register_metas (GESFormatterClass * klass, void ges_formatter_class_register_metas (GESFormatterClass * klass,
const gchar *name, const gchar *name,
const gchar *description, const gchar *description,
const gchar *extension, const gchar *extensions,
const gchar *mimetype, const gchar *mimetype,
gdouble version, gdouble version,
GstRank rank); GstRank rank);