mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 11:41:09 +00:00
Code Issues 1 Projects Releases Wiki Activity

parsebin: avoid bogus processing

Browse source 
If a parsebin pad is already exposed, don't try to rename it or cause extra
processing which isn't needed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2784>
This commit is contained in:
Edward Hervey 2022-11-09 10:33:22 +01:00 committed by GStreamer Marge Bot
parent 5e2606cacd
commit fa4a70d7fe
1 changed files with 10 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
subprojects/gst-plugins-base/gst/playback/gstparsebin.c
View file

@ -3634,8 +3634,10 @@ retry:
GstParsePad *parsepad = (GstParsePad *) tmp->data;
gchar *padname;
//if (!parsepad->blocked)
//continue;
if (parsepad->exposed) {
GST_DEBUG_OBJECT (parsepad, "Pad is already exposed, not doing anything");
continue;
}
/* 1. rewrite name */
padname = g_strdup_printf ("src_%u", parsebin->nbpads);
@ -3649,20 +3651,12 @@ retry:
parsepad);
/* 2. activate and add */
if (!parsepad->exposed) {
parsepad->exposed = TRUE;
if (!gst_element_add_pad (GST_ELEMENT (parsebin),
GST_PAD_CAST (parsepad))) {
/* not really fatal, we can try to add the other pads */
g_warning ("error adding pad to ParseBin");
parsepad->exposed = FALSE;
continue;
}
#if 0
/* HACK: Send an empty gap event to push sticky events */
gst_pad_push_event (GST_PAD (parsepad),
gst_event_new_gap (0, GST_CLOCK_TIME_NONE));
#endif
parsepad->exposed = TRUE;
if (!gst_element_add_pad (GST_ELEMENT (parsebin), GST_PAD_CAST (parsepad))) {
/* not really fatal, we can try to add the other pads */
g_warning ("error adding pad to ParseBin");
parsepad->exposed = FALSE;
continue;
}
GST_INFO_OBJECT (parsepad, "added new parsed pad");