mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-04 01:32:42 +00:00
Code Issues 1 Projects Releases Wiki Activity

stream: Fix leaked joined_bin

Browse source 
There is no need to keep a strong ref on it, and _leave_bin() was
setting it to NULL before calling g_clear_object() so it was leaked.

https://bugzilla.gnome.org/show_bug.cgi?id=766612
This commit is contained in:
Xavier Claessens 2016-09-07 10:12:18 -04:00 committed by Sebastian Dröge
parent d33eca6156
commit f90ab92547
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
common

@ -1 +1 @@
Subproject commit f49c55ecd35a7436194d28297f6d6f20eb6a66fa
Subproject commit 6f2d2093e84cc0eb99b634fa281822ebb9507285

3
gst/rtsp-server/rtsp-stream.c
View file

@ -2768,7 +2768,7 @@ gst_rtsp_stream_join_bin (GstRTSPStream * stream, GstBin * bin,
(GCallback) caps_notify, stream);
}
priv->joined_bin = gst_object_ref (bin);
priv->joined_bin = bin;
g_mutex_unlock (&priv->lock);
return TRUE;
@ -2920,7 +2920,6 @@ gst_rtsp_stream_leave_bin (GstRTSPStream * stream, GstBin * bin,
gst_rtsp_address_free (priv->server_addr_v6);
priv->server_addr_v6 = NULL;
g_clear_object (&priv->joined_bin);
g_mutex_unlock (&priv->lock);
return TRUE;