mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-19 08:11:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

miniobject: free qdata array when the last qdata is removed

Browse source 
In cases with many long-lived buffers that have qdata only very
briefly, the memory overhead of keeping an array of 16 GstQData
structs for each buffer can be significant. We free the array when
the last qdata is removed, like it was done in 1.14.

Fixes #436
This commit is contained in:
David Svensson Fors 2019-09-03 10:38:13 +02:00
parent 80a76a4b4d
commit f8d70b475c
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/gstminiobject.c
View file

@ -506,7 +506,12 @@ remove_notify (GstMiniObject * object, gint index)
/* remove item */ /* remove item */
priv_data->n_qdata--; priv_data->n_qdata--;
if (index != priv_data->n_qdata) { if (priv_data->n_qdata == 0) {
/* we don't shrink but free when everything is gone */
g_free (priv_data->qdata);
priv_data->qdata = NULL;
priv_data->n_qdata_len = 0;
} else if (index != priv_data->n_qdata) {
QDATA (priv_data, index) = QDATA (priv_data, priv_data->n_qdata); QDATA (priv_data, index) = QDATA (priv_data, priv_data->n_qdata);
} }
} }