mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-10 00:12:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Fix pointer dereference before null check

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3133>
This commit is contained in:
Sangchul Lee 2022-09-22 22:39:31 +09:00 committed by GStreamer Marge Bot
parent 3b6234829a
commit f8b248cb1a
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
View file

@ -5762,6 +5762,12 @@ _set_description_task (GstWebRTCBin * webrtc, struct set_description *sd)
continue; continue;
} }
if (!pad->trans) {
GST_LOG_OBJECT (pad, "doesn't have a transceiver");
tmp = tmp->next;
continue;
}
if (pad->trans->mline >= gst_sdp_message_medias_len (sd->sdp->sdp)) { if (pad->trans->mline >= gst_sdp_message_medias_len (sd->sdp->sdp)) {
GST_DEBUG_OBJECT (pad, "not mentioned in this description. Skipping"); GST_DEBUG_OBJECT (pad, "not mentioned in this description. Skipping");
tmp = tmp->next; tmp = tmp->next;
@ -5778,12 +5784,6 @@ _set_description_task (GstWebRTCBin * webrtc, struct set_description *sd)
continue; continue;
} }
if (!pad->trans) {
GST_LOG_OBJECT (pad, "doesn't have a transceiver");
tmp = tmp->next;
continue;
}
new_dir = pad->trans->direction; new_dir = pad->trans->direction;
if (new_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_SENDONLY && if (new_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_SENDONLY &&
new_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_SENDRECV) { new_dir != GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_SENDRECV) {