mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

avdemux: reset to 0 negative pts

Browse source 
for us pts are unsigned so reset to 0 negative pts returned from libav.
This is better than outputs completly wrong timestamps

https://bugzilla.gnome.org/show_bug.cgi?id=787795
This commit is contained in:
Nicola Murino 2017-09-23 17:14:03 +02:00 committed by Nicolas Dufresne
parent e6773f6932
commit f86dfde0a4
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ext/libav/gstavdemux.c
View file

@ -1394,6 +1394,7 @@ gst_ffmpegdemux_loop (GstFFMpegDemux * demux)
gint outsize; gint outsize;
gboolean rawvideo; gboolean rawvideo;
GstFlowReturn stream_last_flow; GstFlowReturn stream_last_flow;
gint64 pts;
/* open file if we didn't so already */ /* open file if we didn't so already */
if (!demux->opened) if (!demux->opened)
@ -1421,7 +1422,21 @@ gst_ffmpegdemux_loop (GstFFMpegDemux * demux)
/* do timestamps, we do this first so that we can know when we /* do timestamps, we do this first so that we can know when we
* stepped over the segment stop position. */ * stepped over the segment stop position. */
timestamp = gst_ffmpeg_time_ff_to_gst (pkt.pts, avstream->time_base); pts = pkt.pts;
if (G_UNLIKELY (pts < 0)) {
/* some streams have pts such this:
* 0
* -2
* -1
* 1
*
* we reset pts to 0 since for us timestamp are unsigned
*/
GST_WARNING_OBJECT (demux,
"negative pts detected: %" G_GINT64_FORMAT " resetting to 0", pts);
pts = 0;
}
timestamp = gst_ffmpeg_time_ff_to_gst (pts, avstream->time_base);
if (GST_CLOCK_TIME_IS_VALID (timestamp)) { if (GST_CLOCK_TIME_IS_VALID (timestamp)) {
stream->last_ts = timestamp; stream->last_ts = timestamp;
} }