mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-18 13:25:56 +00:00
Code Issues 1 Projects Releases Wiki Activity

uridecodebin3: Refuse sub uri in gapless mode

Browse source 
This is too problematic to handle properly right now.

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2550 and
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2605

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4958>
This commit is contained in:
Edward Hervey 2023-07-03 16:02:40 +02:00 committed by Edward Hervey
parent dbdbf2d256
commit f825b7aba3
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
subprojects/gst-plugins-base/gst/playback/gsturidecodebin3.c
View file

@ -1949,9 +1949,16 @@ gst_uri_decode_bin3_set_suburi (GstURIDecodeBin3 * dec, const gchar * uri)
/* FIXME : Handle instant-uri-change. Should we just apply it automatically to
* the current input item ? */
if (dec->input_item->posted_about_to_finish) {
/* WARNING : Setting sub-uri in gapless mode is unreliable */
GST_ELEMENT_WARNING (dec, CORE, NOT_IMPLEMENTED,
("Setting sub-uri in gapless mode is not handled"),
("Setting sub-uri in gapless mode is not implemented"));
} else {
item = next_inactive_play_item (dec);
play_item_set_suburi (item, uri);
}
}
/* Sync source handlers for the given play item. Might require creating/removing some
* and/or configure the handlers accordingly */