mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-08 00:59:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtmp2: Check for missing GstRtmpMeta

Browse source 
The message buffers are created using `gst_rtmp_message_new` and thus
always contain a GstRtmpMeta. Add checks to appease Coverity's static
analysis.

CID 1455596
CID 1455384
This commit is contained in:
Jan Alexander Steffens (heftig) 2019-11-12 11:46:21 +01:00
parent 8d7489a734
commit f730f4a694
No known key found for this signature in database
GPG key ID: DE5E0C5F25941CA5
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gst/rtmp2/rtmp/rtmpchunkstream.c
View file

@ -195,6 +195,7 @@ select_chunk_type (GstRtmpChunkStream * cstream, GstBuffer * buffer)
}
old_meta = gst_buffer_get_rtmp_meta (old_buffer);
g_return_val_if_fail (old_meta, -1);
if (old_meta->mstream != meta->mstream) {
GST_TRACE ("Picking header 0: stream mismatch; "

5
gst/rtmp2/rtmp/rtmpconnection.c
View file

@ -734,11 +734,14 @@ is_command_response (const gchar * command_name)
static void
gst_rtmp_connection_handle_cm (GstRtmpConnection * sc, GstBuffer * buffer)
{
GstRtmpMeta *meta = gst_buffer_get_rtmp_meta (buffer);
GstRtmpMeta *meta;
gchar *command_name;
gdouble transaction_id;
GPtrArray *args;
meta = gst_buffer_get_rtmp_meta (buffer);
g_return_if_fail (meta);
{
GstMapInfo map;
gst_buffer_map (buffer, &map, GST_MAP_READ);