mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

v4l2object: Don't open the device in get property

Browse source 
This is both racy and inefficient. This function is still missing some
locking which will be address in later patch.

https://bugzilla.gnome.org/show_bug.cgi?id=796185
This commit is contained in:
Nicolas Dufresne 2018-05-16 20:16:44 -04:00
parent 48dd93662d
commit f72c7131ae
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
sys/v4l2/gstv4l2object.c
View file

@ -720,15 +720,12 @@ gst_v4l2_object_get_property_helper (GstV4l2Object * v4l2object,
break; break;
case PROP_DEVICE_NAME: case PROP_DEVICE_NAME:
{ {
const guchar *new = NULL; const guchar *name = NULL;
if (GST_V4L2_IS_OPEN (v4l2object)) { if (GST_V4L2_IS_OPEN (v4l2object))
new = v4l2object->vcap.card; name = v4l2object->vcap.card;
} else if (gst_v4l2_open (v4l2object)) {
new = v4l2object->vcap.card; g_value_set_string (value, (gchar *) name);
gst_v4l2_close (v4l2object);
}
g_value_set_string (value, (gchar *) new);
break; break;
} }
case PROP_DEVICE_FD: case PROP_DEVICE_FD: