mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-20 07:16:55 +00:00
Code Issues 1 Projects Releases Wiki Activity

videofilter: Unref buffers before calling the transform_frame functions

Browse source 
GstVideoFrame has another reference, so the buffer looks unwriteable,
meaning that we can't attach any metas or anything to it

https://bugzilla.gnome.org/show_bug.cgi?id=736118
This commit is contained in:
Sebastian Dröge 2014-09-12 14:27:44 +03:00
parent 47e303269d
commit f711288c7c
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
gst-libs/gst/video/gstvideofilter.c
View file

@ -267,7 +267,16 @@ gst_video_filter_transform (GstBaseTransform * trans, GstBuffer * inbuf,
GST_MAP_WRITE))
goto invalid_buffer;
/* GstVideoFrame has another reference, so the buffer looks unwriteable,
* meaning that we can't attach any metas or anything to it. Other
* map() functions like gst_buffer_map() don't get another reference
* of the buffer and expect the buffer reference to be kept until
* the buffer is unmapped again. */
gst_buffer_unref (inbuf);
gst_buffer_unref (outbuf);
res = fclass->transform_frame (filter, &in_frame, &out_frame);
gst_buffer_ref (inbuf);
gst_buffer_ref (outbuf);
gst_video_frame_unmap (&out_frame);
gst_video_frame_unmap (&in_frame);
@ -316,7 +325,14 @@ gst_video_filter_transform_ip (GstBaseTransform * trans, GstBuffer * buf)
if (!gst_video_frame_map (&frame, &filter->in_info, buf, flags))
goto invalid_buffer;
/* GstVideoFrame has another reference, so the buffer looks unwriteable,
* meaning that we can't attach any metas or anything to it. Other
* map() functions like gst_buffer_map() don't get another reference
* of the buffer and expect the buffer reference to be kept until
* the buffer is unmapped again. */
gst_buffer_unref (buf);
res = fclass->transform_frame_ip (filter, &frame);
gst_buffer_ref (buf);
gst_video_frame_unmap (&frame);
} else {