validate:scenario: Move the check about whether we are still seeking upper in the function

Avoiding to try to get position and do operations on a pipeline that is seeking
This commit is contained in:
Thibault Saunier 2014-06-19 12:56:34 +02:00
parent 4dc3f5171e
commit f708156ff6

View file

@ -664,6 +664,12 @@ get_position (GstValidateScenario * scenario)
return TRUE; return TRUE;
} }
/* TODO what about non flushing seeks? */
if (priv->last_seek) {
GST_INFO_OBJECT (scenario, "Still seeking -- not executing action");
return TRUE;
}
query = gst_query_new_segment (GST_FORMAT_DEFAULT); query = gst_query_new_segment (GST_FORMAT_DEFAULT);
if (gst_element_query (GST_ELEMENT (scenario->pipeline), query)) if (gst_element_query (GST_ELEMENT (scenario->pipeline), query))
gst_query_parse_segment (query, &rate, NULL, NULL, NULL); gst_query_parse_segment (query, &rate, NULL, NULL, NULL);
@ -716,13 +722,6 @@ get_position (GstValidateScenario * scenario)
(rate < 0 && (GstClockTime) position <= act->playback_time))) { (rate < 0 && (GstClockTime) position <= act->playback_time))) {
GstValidateActionType *type; GstValidateActionType *type;
/* TODO what about non flushing seeks? */
/* TODO why is this inside the action time if ? */
if (priv->last_seek) {
GST_INFO_OBJECT (scenario, "Still seeking -- not executing action");
return TRUE;
}
type = g_hash_table_lookup (action_types_table, act->type); type = g_hash_table_lookup (action_types_table, act->type);
if (act->repeat == -1 && if (act->repeat == -1 &&