mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 17:20:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

level: disable passthrough when audio-level-meta is enabled

Browse source 
Ensure we receive a writable buffer to add the meta.

Fix #878

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/962>
This commit is contained in:
Guillaume Desmottes 2021-04-22 14:11:09 +02:00
parent c0d68d03a6
commit f61bd6239a
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
gst/level/gstlevel.c
View file

@ -200,7 +200,15 @@ gst_level_class_init (GstLevelClass * klass)
trans_class->start = GST_DEBUG_FUNCPTR (gst_level_start); trans_class->start = GST_DEBUG_FUNCPTR (gst_level_start);
trans_class->transform_ip = GST_DEBUG_FUNCPTR (gst_level_transform_ip); trans_class->transform_ip = GST_DEBUG_FUNCPTR (gst_level_transform_ip);
trans_class->sink_event = GST_DEBUG_FUNCPTR (gst_level_sink_event); trans_class->sink_event = GST_DEBUG_FUNCPTR (gst_level_sink_event);
trans_class->passthrough_on_same_caps = TRUE; }
static void
configure_passthrough (GstLevel * self)
{
/* can't use passthrough if audio-level-meta is enabled as we need a
* writable buffer to add the meta. */
gst_base_transform_set_passthrough (GST_BASE_TRANSFORM (self),
!self->audio_level_meta);
} }
static void static void
@ -224,6 +232,7 @@ gst_level_init (GstLevel * filter)
filter->process = NULL; filter->process = NULL;
gst_base_transform_set_gap_aware (GST_BASE_TRANSFORM (filter), TRUE); gst_base_transform_set_gap_aware (GST_BASE_TRANSFORM (filter), TRUE);
configure_passthrough (filter);
} }
static void static void
@ -277,6 +286,7 @@ gst_level_set_property (GObject * object, guint prop_id,
break; break;
case PROP_AUDIO_LEVEL_META: case PROP_AUDIO_LEVEL_META:
filter->audio_level_meta = g_value_get_boolean (value); filter->audio_level_meta = g_value_get_boolean (value);
configure_passthrough (filter);
break; break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);