mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-12-24 01:00:37 +00:00
matroskamux: create streamable output if downstream is not seekable
Ignore the "streamable" property setting and create streamable output if downstream is known not to be seekable (as queried via a SEEKABLE query). Fixes pipelines like webmmux ! appsink creating seemingly corrupted output if streamable has not been set to true.
This commit is contained in:
parent
f9207722ca
commit
f4afccff5c
1 changed files with 23 additions and 0 deletions
|
@ -2355,6 +2355,29 @@ gst_matroska_mux_start (GstMatroskaMux * mux)
|
|||
guint32 segment_uid[4];
|
||||
GTimeVal time = { 0, 0 };
|
||||
|
||||
/* if not streaming, check if downstream is seekable */
|
||||
if (!mux->streamable) {
|
||||
gboolean seekable;
|
||||
GstQuery *query;
|
||||
|
||||
query = gst_query_new_seeking (GST_FORMAT_BYTES);
|
||||
if (gst_pad_peer_query (mux->srcpad, query)) {
|
||||
gst_query_parse_seeking (query, NULL, &seekable, NULL, NULL);
|
||||
GST_INFO_OBJECT (mux, "downstream is %sseekable", seekable ? "" : "not ");
|
||||
if (!seekable) {
|
||||
mux->streamable = TRUE;
|
||||
g_object_notify (G_OBJECT (mux), "streamable");
|
||||
GST_WARNING_OBJECT (mux, "downstream is not seekable, but "
|
||||
"streamable=false. Will ignore that and create streamable output "
|
||||
"instead");
|
||||
}
|
||||
} else {
|
||||
/* have to assume seeking is supported if query not handled downstream */
|
||||
/* FIXME 0.11: change to query not handled => seeking not supported */
|
||||
GST_WARNING_OBJECT (mux, "downstream did not handle seeking query");
|
||||
}
|
||||
}
|
||||
|
||||
if (!strcmp (mux->doctype, GST_MATROSKA_DOCTYPE_WEBM)) {
|
||||
ebml->caps = gst_caps_new_simple ("video/webm", NULL);
|
||||
} else {
|
||||
|
|
Loading…
Reference in a new issue