mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-10 00:25:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

Fix segfault when using invalid encoding profile

Browse source 
Trying to use gst_encoding_profile_get_file_extension on a
GstEncodingProfile with a cap containing a typo would result in strcmp
being called with NULL. Instead use g_strcmp0 that handles this case.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/929>
This commit is contained in:
David Keijser 2020-11-10 23:26:39 +01:00
parent b3fe2d3623
commit f3dc83d285
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst-libs/gst/pbutils/encoding-profile.c
View file

@ -1383,7 +1383,7 @@ gst_encoding_profile_get_file_extension (GstEncodingProfile * profile)
has_video = gst_encoding_container_profile_has_video (cprofile);
/* Ogg */
if (strcmp (ext, "ogg") == 0) {
if (g_strcmp0 (ext, "ogg") == 0) {
/* ogg with video => .ogv */
if (has_video) {
ext = "ogv";
@ -1404,7 +1404,7 @@ gst_encoding_profile_get_file_extension (GstEncodingProfile * profile)
}
/* Matroska */
if (has_video && strcmp (ext, "mka") == 0) {
if (has_video && g_strcmp0 (ext, "mka") == 0) {
ext = "mkv";
goto done;
}