revtv: Clean up revtv element

This commit is contained in:
Sebastian Dröge 2009-06-15 20:21:58 +02:00
parent 006caab053
commit f3dc59d010

View file

@ -44,12 +44,13 @@
#include "config.h" #include "config.h"
#endif #endif
#include <gst/video/gstvideofilter.h>
#include <math.h> #include <math.h>
#include <string.h> #include <string.h>
#include <gst/gst.h>
#include <gst/video/video.h> #include <gst/video/video.h>
#include <gst/video/gstvideofilter.h>
#define GST_TYPE_REVTV \ #define GST_TYPE_REVTV \
(gst_revtv_get_type()) (gst_revtv_get_type())
@ -85,19 +86,13 @@ struct _GstRevTVClass
enum enum
{ {
ARG_0, PROP_0,
ARG_DELAY, PROP_DELAY,
ARG_LINESPACE, PROP_LINESPACE,
ARG_GAIN PROP_GAIN
}; };
GType gst_revtv_get_type (void); GST_BOILERPLATE (GstRevTV, gst_revtv, GstVideoFilter, GST_TYPE_VIDEO_FILTER);
static const GstElementDetails gst_revtv_details =
GST_ELEMENT_DETAILS ("RevTV effect",
"Filter/Effect/Video",
"A video waveform monitor for each line of video processed",
"Wim Taymans <wim.taymans@chello.be>");
static GstStaticPadTemplate gst_revtv_src_template = static GstStaticPadTemplate gst_revtv_src_template =
GST_STATIC_PAD_TEMPLATE ("src", GST_STATIC_PAD_TEMPLATE ("src",
@ -113,8 +108,6 @@ GST_STATIC_PAD_TEMPLATE ("sink",
GST_STATIC_CAPS (GST_VIDEO_CAPS_BGRx) GST_STATIC_CAPS (GST_VIDEO_CAPS_BGRx)
); );
static GstVideoFilterClass *parent_class = NULL;
static gboolean static gboolean
gst_revtv_set_caps (GstBaseTransform * btrans, GstCaps * incaps, gst_revtv_set_caps (GstBaseTransform * btrans, GstCaps * incaps,
GstCaps * outcaps) GstCaps * outcaps)
@ -137,13 +130,11 @@ static gboolean
gst_revtv_get_unit_size (GstBaseTransform * btrans, GstCaps * caps, gst_revtv_get_unit_size (GstBaseTransform * btrans, GstCaps * caps,
guint * size) guint * size)
{ {
GstRevTV *filter; GstRevTV *filter = GST_REVTV (btrans);
GstStructure *structure; GstStructure *structure;
gboolean ret = FALSE; gboolean ret = FALSE;
gint width, height; gint width, height;
filter = GST_REVTV (btrans);
structure = gst_caps_get_structure (caps, 0); structure = gst_caps_get_structure (caps, 0);
if (gst_structure_get_int (structure, "width", &width) && if (gst_structure_get_int (structure, "width", &width) &&
@ -160,17 +151,13 @@ gst_revtv_get_unit_size (GstBaseTransform * btrans, GstCaps * caps,
static GstFlowReturn static GstFlowReturn
gst_revtv_transform (GstBaseTransform * trans, GstBuffer * in, GstBuffer * out) gst_revtv_transform (GstBaseTransform * trans, GstBuffer * in, GstBuffer * out)
{ {
GstRevTV *filter; GstRevTV *filter = GST_REVTV (trans);
guint32 *src, *dest; guint32 *src, *dest;
gint width, height; gint width, height;
guint32 *nsrc; guint32 *nsrc;
gint y, x, R, G, B, yval; gint y, x, R, G, B, yval;
GstFlowReturn ret = GST_FLOW_OK; GstFlowReturn ret = GST_FLOW_OK;
filter = GST_REVTV (trans);
gst_buffer_copy_metadata (out, in, GST_BUFFER_COPY_TIMESTAMPS);
src = (guint32 *) GST_BUFFER_DATA (in); src = (guint32 *) GST_BUFFER_DATA (in);
dest = (guint32 *) GST_BUFFER_DATA (out); dest = (guint32 *) GST_BUFFER_DATA (out);
@ -180,12 +167,12 @@ gst_revtv_transform (GstBaseTransform * trans, GstBuffer * in, GstBuffer * out)
/* Clear everything to black */ /* Clear everything to black */
memset (dest, 0, width * height * sizeof (guint32)); memset (dest, 0, width * height * sizeof (guint32));
// draw the offset lines /* draw the offset lines */
for (y = 0; y < height; y += filter->linespace) { for (y = 0; y < height; y += filter->linespace) {
for (x = 0; x <= width; x++) { for (x = 0; x <= width; x++) {
nsrc = src + (y * width) + x; nsrc = src + (y * width) + x;
// Calc Y Value for curpix /* Calc Y Value for curpix */
R = ((*nsrc) & 0xff0000) >> (16 - 1); R = ((*nsrc) & 0xff0000) >> (16 - 1);
G = ((*nsrc) & 0xff00) >> (8 - 2); G = ((*nsrc) & 0xff00) >> (8 - 2);
B = (*nsrc) & 0xff; B = (*nsrc) & 0xff;
@ -205,20 +192,16 @@ static void
gst_revtv_set_property (GObject * object, guint prop_id, const GValue * value, gst_revtv_set_property (GObject * object, guint prop_id, const GValue * value,
GParamSpec * pspec) GParamSpec * pspec)
{ {
GstRevTV *filter; GstRevTV *filter = GST_REVTV (object);
g_return_if_fail (GST_IS_REVTV (object));
filter = GST_REVTV (object);
switch (prop_id) { switch (prop_id) {
case ARG_DELAY: case PROP_DELAY:
filter->vgrabtime = g_value_get_int (value); filter->vgrabtime = g_value_get_int (value);
break; break;
case ARG_LINESPACE: case PROP_LINESPACE:
filter->linespace = g_value_get_int (value); filter->linespace = g_value_get_int (value);
break; break;
case ARG_GAIN: case PROP_GAIN:
filter->vscale = g_value_get_int (value); filter->vscale = g_value_get_int (value);
break; break;
default: default:
@ -230,20 +213,16 @@ static void
gst_revtv_get_property (GObject * object, guint prop_id, GValue * value, gst_revtv_get_property (GObject * object, guint prop_id, GValue * value,
GParamSpec * pspec) GParamSpec * pspec)
{ {
GstRevTV *filter; GstRevTV *filter = GST_REVTV (object);
g_return_if_fail (GST_IS_REVTV (object));
filter = GST_REVTV (object);
switch (prop_id) { switch (prop_id) {
case ARG_DELAY: case PROP_DELAY:
g_value_set_int (value, filter->vgrabtime); g_value_set_int (value, filter->vgrabtime);
break; break;
case ARG_LINESPACE: case PROP_LINESPACE:
g_value_set_int (value, filter->linespace); g_value_set_int (value, filter->linespace);
break; break;
case ARG_GAIN: case PROP_GAIN:
g_value_set_int (value, filter->vscale); g_value_set_int (value, filter->vscale);
break; break;
default: default:
@ -257,7 +236,10 @@ gst_revtv_base_init (gpointer g_class)
{ {
GstElementClass *element_class = GST_ELEMENT_CLASS (g_class); GstElementClass *element_class = GST_ELEMENT_CLASS (g_class);
gst_element_class_set_details (element_class, &gst_revtv_details); gst_element_class_set_details_simple (element_class, "RevTV effect",
"Filter/Effect/Video",
"A video waveform monitor for each line of video processed",
"Wim Taymans <wim.taymans@chello.be>");
gst_element_class_add_pad_template (element_class, gst_element_class_add_pad_template (element_class,
gst_static_pad_template_get (&gst_revtv_sink_template)); gst_static_pad_template_get (&gst_revtv_sink_template));
@ -266,28 +248,23 @@ gst_revtv_base_init (gpointer g_class)
} }
static void static void
gst_revtv_class_init (gpointer klass, gpointer class_data) gst_revtv_class_init (GstRevTVClass * klass)
{ {
GObjectClass *gobject_class; GObjectClass *gobject_class = (GObjectClass *) klass;
GstBaseTransformClass *trans_class; GstBaseTransformClass *trans_class = (GstBaseTransformClass *) klass;
gobject_class = (GObjectClass *) klass;
trans_class = (GstBaseTransformClass *) klass;
parent_class = g_type_class_peek_parent (klass);
gobject_class->set_property = gst_revtv_set_property; gobject_class->set_property = gst_revtv_set_property;
gobject_class->get_property = gst_revtv_get_property; gobject_class->get_property = gst_revtv_get_property;
g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_DELAY, g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_DELAY,
g_param_spec_int ("delay", "Delay", "Delay in frames between updates", g_param_spec_int ("delay", "Delay", "Delay in frames between updates",
1, 100, 1, G_PARAM_READWRITE)); 1, 100, 1, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_LINESPACE, g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_LINESPACE,
g_param_spec_int ("linespace", "Linespace", "Control line spacing", g_param_spec_int ("linespace", "Linespace", "Control line spacing",
1, 100, 6, G_PARAM_READWRITE)); 1, 100, 6, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_GAIN, g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_GAIN,
g_param_spec_int ("gain", "Gain", "Control gain", g_param_spec_int ("gain", "Gain", "Control gain",
1, 200, 50, G_PARAM_READWRITE)); 1, 200, 50, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
trans_class->set_caps = GST_DEBUG_FUNCPTR (gst_revtv_set_caps); trans_class->set_caps = GST_DEBUG_FUNCPTR (gst_revtv_set_caps);
trans_class->get_unit_size = GST_DEBUG_FUNCPTR (gst_revtv_get_unit_size); trans_class->get_unit_size = GST_DEBUG_FUNCPTR (gst_revtv_get_unit_size);
@ -295,37 +272,10 @@ gst_revtv_class_init (gpointer klass, gpointer class_data)
} }
static void static void
gst_revtv_init (GTypeInstance * instance, gpointer g_class) gst_revtv_init (GstRevTV * restv, GstRevTVClass * klass)
{ {
GstRevTV *restv = GST_REVTV (instance);
restv->vgrabtime = 1; restv->vgrabtime = 1;
restv->vgrab = 0; restv->vgrab = 0;
restv->linespace = 6; restv->linespace = 6;
restv->vscale = 50; restv->vscale = 50;
} }
GType
gst_revtv_get_type (void)
{
static GType revtv_type = 0;
if (!revtv_type) {
static const GTypeInfo revtv_info = {
sizeof (GstRevTVClass),
gst_revtv_base_init,
NULL,
(GClassInitFunc) gst_revtv_class_init,
NULL,
NULL,
sizeof (GstRevTV),
0,
(GInstanceInitFunc) gst_revtv_init,
};
revtv_type =
g_type_register_static (GST_TYPE_VIDEO_FILTER, "GstRevTV", &revtv_info,
0);
}
return revtv_type;
}