mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

sys: fix some bufferpool leaks

Browse source
This commit is contained in:
Wim Taymans 2012-06-18 12:17:12 +02:00
parent c003efcc63
commit f35f0b6548
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sys/ximage/ximagesink.c
View file

@ -1459,12 +1459,12 @@ gst_ximagesink_propose_allocation (GstBaseSink * bsink, GstQuery * query)
if (pool == NULL && need_pool) { if (pool == NULL && need_pool) {
GstVideoInfo info; GstVideoInfo info;
GST_DEBUG_OBJECT (ximagesink, "create new pool");
pool = gst_ximage_buffer_pool_new (ximagesink);
if (!gst_video_info_from_caps (&info, caps)) if (!gst_video_info_from_caps (&info, caps))
goto invalid_caps; goto invalid_caps;
GST_DEBUG_OBJECT (ximagesink, "create new pool");
pool = gst_ximage_buffer_pool_new (ximagesink);
/* the normal size of a frame */ /* the normal size of a frame */
size = info.size; size = info.size;
@ -1499,6 +1499,7 @@ invalid_caps:
config_failed: config_failed:
{ {
GST_DEBUG_OBJECT (bsink, "failed setting config"); GST_DEBUG_OBJECT (bsink, "failed setting config");
gst_object_unref (pool);
return FALSE; return FALSE;
} }
} }

7
sys/xvimage/xvimagesink.c
View file

@ -1970,12 +1970,12 @@ gst_xvimagesink_propose_allocation (GstBaseSink * bsink, GstQuery * query)
if (pool == NULL && need_pool) { if (pool == NULL && need_pool) {
GstVideoInfo info; GstVideoInfo info;
GST_DEBUG_OBJECT (xvimagesink, "create new pool");
pool = gst_xvimage_buffer_pool_new (xvimagesink);
if (!gst_video_info_from_caps (&info, caps)) if (!gst_video_info_from_caps (&info, caps))
goto invalid_caps; goto invalid_caps;
GST_DEBUG_OBJECT (xvimagesink, "create new pool");
pool = gst_xvimage_buffer_pool_new (xvimagesink);
/* the normal size of a frame */ /* the normal size of a frame */
size = info.size; size = info.size;
@ -2010,6 +2010,7 @@ invalid_caps:
config_failed: config_failed:
{ {
GST_DEBUG_OBJECT (bsink, "failed setting config"); GST_DEBUG_OBJECT (bsink, "failed setting config");
gst_object_unref (pool);
return FALSE; return FALSE;
} }
} }