cerbero ci: Don't expand the ssh private key

Because of set -x we were printing the key into the CI logs:
https://gitlab.freedesktop.org/gstreamer/cerbero/-/jobs/4572836#L797

Don't ever expand the variable in shell.
This commit is contained in:
Nirbheek Chauhan 2020-09-17 21:51:49 +05:30
parent bdbec90a49
commit f24e7b721a

View file

@ -107,7 +107,10 @@ cerbero_deps_script() {
rsync -aH "${CERBERO_OVERRIDDEN_DIST_DIR}/" "${CERBERO_HOME}/dist/${ARCH}"
fi
if [[ -n ${CERBERO_PRIVATE_SSH_KEY} ]]; then
# Check that the env var is set. Don't expand this protected variable by
# doing something silly like [[ -n ${CERBERO_...} ]] because it will get
# printed in the CI logs due to set -x
if env | grep -q -e CERBERO_PRIVATE_SSH_KEY; then
$CERBERO $CERBERO_ARGS gen-cache --branch "${GST_UPSTREAM_BRANCH}"
$CERBERO $CERBERO_ARGS upload-cache --branch "${GST_UPSTREAM_BRANCH}"
fi