mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-03 21:12:26 +00:00
Code Issues 1 Projects Releases Wiki Activity

use _object_ref_sink() when we can

Browse source
This commit is contained in:
Wim Taymans 2010-12-07 11:31:30 +01:00
parent f355419679
commit f22687bacc
3 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ext/ogg/gstoggdemux.c
View file

@ -1159,8 +1159,7 @@ gst_ogg_chain_new_stream (GstOggChain * chain, glong serialno)
ret = g_object_new (GST_TYPE_OGG_PAD, NULL); ret = g_object_new (GST_TYPE_OGG_PAD, NULL);
/* we own this one */ /* we own this one */
gst_object_ref (ret); gst_object_ref_sink (ret);
gst_object_sink (ret);
GST_PAD_DIRECTION (ret) = GST_PAD_SRC; GST_PAD_DIRECTION (ret) = GST_PAD_SRC;
gst_ogg_pad_mark_discont (ret); gst_ogg_pad_mark_discont (ret);

3
gst/playback/gstdecodebin2.c
View file

@ -3294,8 +3294,7 @@ gst_decode_pad_init (GstDecodePad * pad)
pad->blocked = FALSE; pad->blocked = FALSE;
pad->exposed = FALSE; pad->exposed = FALSE;
pad->drained = FALSE; pad->drained = FALSE;
gst_object_ref (pad); gst_object_ref_sink (pad);
gst_object_sink (pad);
} }
static void static void

9
gst/playback/gstplaybin.c
View file

@ -638,8 +638,7 @@ gst_play_bin_set_property (GObject * object, guint prop_id,
} }
play_bin->video_sink = g_value_get_object (value); play_bin->video_sink = g_value_get_object (value);
if (play_bin->video_sink != NULL) { if (play_bin->video_sink != NULL) {
gst_object_ref (play_bin->video_sink); gst_object_ref_sink (play_bin->video_sink);
gst_object_sink (GST_OBJECT_CAST (play_bin->video_sink));
} }
/* when changing the videosink, we just remove the /* when changing the videosink, we just remove the
* video pipeline from the cache so that it will be * video pipeline from the cache so that it will be
@ -656,8 +655,7 @@ gst_play_bin_set_property (GObject * object, guint prop_id,
} }
play_bin->audio_sink = g_value_get_object (value); play_bin->audio_sink = g_value_get_object (value);
if (play_bin->audio_sink != NULL) { if (play_bin->audio_sink != NULL) {
gst_object_ref (play_bin->audio_sink); gst_object_ref_sink (play_bin->audio_sink);
gst_object_sink (GST_OBJECT_CAST (play_bin->audio_sink));
} }
g_hash_table_remove (play_bin->cache, "abin"); g_hash_table_remove (play_bin->cache, "abin");
break; break;
@ -668,8 +666,7 @@ gst_play_bin_set_property (GObject * object, guint prop_id,
/* Take ownership */ /* Take ownership */
if (pending_visualisation) { if (pending_visualisation) {
gst_object_ref (pending_visualisation); gst_object_ref_sink (pending_visualisation);
gst_object_sink (pending_visualisation);
} }
/* Do we already have a visualisation change pending ? */ /* Do we already have a visualisation change pending ? */