mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 08:46:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

tsmux: Adjust byte counter when adjusting bitrate

Browse source 
When configured in constant bitrate mode, the muxer computes timing information
using the configured bitrate and the byte counter (now = bytes sent / byterate).

When an application changes the bitrate in CBR mode during playback, the
relationship between bytes sent and bitrate is no longer valid so new timing
values will be off by the ratio of the old bitrate to the new bitrate.
Furthermore, it will upset the way that padding is generated.

pad_stream() works by trying to fit the byte counter to now * byterate.
The result is that when decreasing bitrate, the muxer stalls, waiting until the
byte counter is in agreement with now * byterate. Also, when increasing
bitrate, the padding will spike in volume until the byte counter fits with
now * byterate.

If the byte counter is scaled by the ratio of new bitrate / old bitrate when
adjusting bitrate, then padding is generated in a way that applications would
more likely expect.

One detail this change doesn't yet address is whether the next PCR will match up
optimally with the previous PCR right after the byte counter is scaled. In that
case, some correction may be necessary. Also, perhaps the user should be
prevented from changing from bitrate=0 to bitrate=nonzero during playback since
it's not straightforward how to scale the byte counter in that case.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7158>
This commit is contained in:
Jordan Yelloz 2024-07-08 16:42:58 -06:00 committed by GStreamer Marge Bot
parent 96a2408147
commit f11735c97b
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
subprojects/gst-plugins-bad/gst/mpegtsmux/tsmux/tsmux.c
View file

@ -1929,5 +1929,13 @@ tsmux_write_scte_null (TsMux * mux, TsMuxProgram * program)
void
tsmux_set_bitrate (TsMux * mux, guint64 bitrate)
{
if (bitrate != 0 && mux->bitrate != 0 && mux->n_bytes != 0) {
guint64 new_byte_counter =
gst_util_uint64_scale (mux->n_bytes, bitrate, mux->bitrate);
GST_LOG ("bitrate transition %" G_GUINT64_FORMAT " => %" G_GUINT64_FORMAT
", adjusting byte counter %" G_GUINT64_FORMAT " => %" G_GUINT64_FORMAT,
mux->bitrate, bitrate, mux->n_bytes, new_byte_counter);
mux->n_bytes = new_byte_counter;
}
mux->bitrate = bitrate;
}