gdb: Fix python style

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5986>
This commit is contained in:
Thibault Saunier 2023-08-31 18:52:58 -04:00 committed by GStreamer Marge Bot
parent 6258ee56d2
commit f1070b4380
2 changed files with 67 additions and 59 deletions

View file

@ -8,6 +8,8 @@ if sys.version_info[0] >= 3:
long = int long = int
# This is not quite right, as local vars may override symname # This is not quite right, as local vars may override symname
def read_global_var(symname): def read_global_var(symname):
return gdb.selected_frame().read_var(symname) return gdb.selected_frame().read_var(symname)
@ -43,9 +45,10 @@ def g_quark_to_string(quark):
return None return None
## ##
## imported from glib: gobject/gobject_gdb.py # imported from glib: gobject/gobject_gdb.py
## ##
def g_type_to_typenode(gtype): def g_type_to_typenode(gtype):
def lookup_fundamental_type(typenode): def lookup_fundamental_type(typenode):
if typenode == 0: if typenode == 0:
@ -63,12 +66,14 @@ def g_type_to_typenode (gtype):
typenode = lookup_fundamental_type(typenode) typenode = lookup_fundamental_type(typenode)
return typenode return typenode
def g_type_to_name(gtype): def g_type_to_name(gtype):
typenode = g_type_to_typenode(gtype) typenode = g_type_to_typenode(gtype)
if typenode != None: if typenode:
return g_quark_to_string(typenode["qname"]) return g_quark_to_string(typenode["qname"])
return None return None
def g_type_name_from_instance(instance): def g_type_name_from_instance(instance):
if long(instance) != 0: if long(instance) != 0:
try: try:

View file

@ -92,8 +92,8 @@ class GstObjectPrettyPrinter:
GST_SECOND = 1000000000 GST_SECOND = 1000000000
GST_CLOCK_TIME_NONE = 2**64-1 GST_CLOCK_TIME_NONE = (2 ** 64) - 1
GST_CLOCK_STIME_NONE = -2**63 GST_CLOCK_STIME_NONE = -(2 ** 63)
def format_time(n, signed=False): def format_time(n, signed=False):
@ -446,9 +446,9 @@ class GdbGValue:
gdb_type = gdb.lookup_type("GArray").pointer() gdb_type = gdb.lookup_type("GArray").pointer()
value = value[0]["v_pointer"].cast(gdb_type) value = value[0]["v_pointer"].cast(gdb_type)
v = "<" v = "<"
for l in _g_array_iter(value, gvalue_type): for array_val in _g_array_iter(value, gvalue_type):
v += " " if v == "<" else ", " v += " " if v == "<" else ", "
v += str(GdbGValue(l)) v += str(GdbGValue(array_val))
v += " >" v += " >"
elif tname in ("GEnum"): elif tname in ("GEnum"):
v = "%s(%s)" % ( v = "%s(%s)" % (
@ -647,8 +647,8 @@ class GdbGstBuffer:
_gdb_write(indent, "%s:" % meta_type_name) _gdb_write(indent, "%s:" % meta_type_name)
indent += 1 indent += 1
meta_info = str(meta.cast(gdb.lookup_type(meta_type_name))) meta_info = str(meta.cast(gdb.lookup_type(meta_type_name)))
for l in meta_info.split('\n'): for info in meta_info.split('\n'):
_gdb_write(indent, l) _gdb_write(indent, info)
indent -= 1 indent -= 1
meta_item = meta_item['next'] meta_item = meta_item['next']
else: else:
@ -1097,6 +1097,7 @@ GST_DEBUG_BIN_TO_DOT_FILE. This command will find the top-level parent
for the given gstreamer object and create the dot for that element. for the given gstreamer object and create the dot for that element.
Usage: gst-dot <gst-object> <file-name>""" Usage: gst-dot <gst-object> <file-name>"""
def __init__(self): def __init__(self):
super(GstDot, self).__init__("gst-dot", gdb.COMMAND_DATA) super(GstDot, self).__init__("gst-dot", gdb.COMMAND_DATA)
@ -1130,6 +1131,7 @@ class GstPrint(gdb.Command):
Print high-level information for GStreamer objects Print high-level information for GStreamer objects
Usage gst-print <gstreamer-object>""" Usage gst-print <gstreamer-object>"""
def __init__(self): def __init__(self):
super(GstPrint, self).__init__("gst-print", gdb.COMMAND_DATA, super(GstPrint, self).__init__("gst-print", gdb.COMMAND_DATA,
gdb.COMPLETE_SYMBOL) gdb.COMPLETE_SYMBOL)
@ -1165,6 +1167,7 @@ Usage gst-print <gstreamer-object>"""
class GstPipelineTree(gdb.Command): class GstPipelineTree(gdb.Command):
"""\ """\
Usage: gst-pipeline-tree <gst-object>""" Usage: gst-pipeline-tree <gst-object>"""
def __init__(self): def __init__(self):
super(GstPipelineTree, self).__init__("gst-pipeline-tree", super(GstPipelineTree, self).__init__("gst-pipeline-tree",
gdb.COMPLETE_SYMBOL) gdb.COMPLETE_SYMBOL)