mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-20 23:36:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

Don't unref input buffer from handle_frame(), it's owned by the baseclass

Browse source
This commit is contained in:
Sebastian Dröge 2012-09-14 14:42:36 +02:00
parent 3c40a9ca56
commit efac01d096
1 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sys/androidmedia/gstamcaudiodec.c
View file

@ -956,15 +956,11 @@ gst_amc_audio_dec_handle_frame (GstAudioDecoder * decoder, GstBuffer * inbuf)
if (!self->started) { if (!self->started) {
GST_ERROR_OBJECT (self, "Codec not started yet"); GST_ERROR_OBJECT (self, "Codec not started yet");
if (inbuf)
gst_buffer_unref (inbuf);
return GST_FLOW_NOT_NEGOTIATED; return GST_FLOW_NOT_NEGOTIATED;
} }
if (self->eos) { if (self->eos) {
GST_WARNING_OBJECT (self, "Got frame after EOS"); GST_WARNING_OBJECT (self, "Got frame after EOS");
if (inbuf)
gst_buffer_unref (inbuf);
return GST_FLOW_UNEXPECTED; return GST_FLOW_UNEXPECTED;
} }
@ -1060,42 +1056,35 @@ gst_amc_audio_dec_handle_frame (GstAudioDecoder * decoder, GstBuffer * inbuf)
goto queue_error; goto queue_error;
} }
gst_buffer_unref (inbuf);
return self->downstream_flow_ret; return self->downstream_flow_ret;
downstream_error: downstream_error:
{ {
GST_ERROR_OBJECT (self, "Downstream returned %s", GST_ERROR_OBJECT (self, "Downstream returned %s",
gst_flow_get_name (self->downstream_flow_ret)); gst_flow_get_name (self->downstream_flow_ret));
gst_buffer_unref (inbuf);
return self->downstream_flow_ret; return self->downstream_flow_ret;
} }
invalid_buffer_index: invalid_buffer_index:
{ {
GST_ELEMENT_ERROR (self, LIBRARY, FAILED, (NULL), GST_ELEMENT_ERROR (self, LIBRARY, FAILED, (NULL),
("Invalid input buffer index %d of %d", idx, self->n_input_buffers)); ("Invalid input buffer index %d of %d", idx, self->n_input_buffers));
gst_buffer_unref (inbuf);
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
dequeue_error: dequeue_error:
{ {
GST_ELEMENT_ERROR (self, LIBRARY, FAILED, (NULL), GST_ELEMENT_ERROR (self, LIBRARY, FAILED, (NULL),
("Failed to dequeue input buffer")); ("Failed to dequeue input buffer"));
gst_buffer_unref (inbuf);
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
queue_error: queue_error:
{ {
GST_ELEMENT_ERROR (self, LIBRARY, FAILED, (NULL), GST_ELEMENT_ERROR (self, LIBRARY, FAILED, (NULL),
("Failed to queue input buffer")); ("Failed to queue input buffer"));
gst_buffer_unref (inbuf);
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
flushing: flushing:
{ {
GST_DEBUG_OBJECT (self, "Flushing -- returning WRONG_STATE"); GST_DEBUG_OBJECT (self, "Flushing -- returning WRONG_STATE");
gst_buffer_unref (inbuf);
return GST_FLOW_WRONG_STATE; return GST_FLOW_WRONG_STATE;
} }
} }