mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-16 20:36:06 +00:00
Code Issues 1 Projects Releases Wiki Activity

avcodecmap: Don't allocate dummy codec data anymore, it causes crashes nowadays

Browse source 
Multithreaded encoders are going to free this dummy codec data twice, e.g.
with this pipeline
  gst-launch-1.0 videotestsrc num-buffers=40 ! \
    videoconvert ! avenc_mjpeg ! fakesink
This commit is contained in:
Sebastian Dröge 2015-10-03 18:25:35 +01:00
parent e5e78379ad
commit eedefc9f6b
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ext/libav/gstavcodecmap.c
View file

@ -2967,12 +2967,8 @@ gst_ffmpeg_caps_with_codecid (enum AVCodecID codec_id,
GST_DEBUG ("have codec data of size %" G_GSIZE_FORMAT, map.size); GST_DEBUG ("have codec data of size %" G_GSIZE_FORMAT, map.size);
gst_buffer_unmap (buf, &map); gst_buffer_unmap (buf, &map);
} else if (context->extradata == NULL && codec_id != AV_CODEC_ID_AAC_LATM && } else {
codec_id != AV_CODEC_ID_FLAC) { context->extradata = NULL;
/* no extradata, alloc dummy with 0 sized, some codecs insist on reading
* extradata anyway which makes then segfault. */
context->extradata =
av_mallocz (GST_ROUND_UP_16 (FF_INPUT_BUFFER_PADDING_SIZE));
context->extradata_size = 0; context->extradata_size = 0;
GST_DEBUG ("no codec data"); GST_DEBUG ("no codec data");
} }