mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-20 21:16:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

dashdemux2: Fix a couple leaks and a use-after-move

Browse source 
The tags and caps were leaked for unknown streams, I'm not sure they'd be valid
in that case, but better safe than sorry.

The tags ownership is transfered when calling `gst_adaptive_demux_track_new()`
so unreffing those afterwards was a mistake.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5714>
This commit is contained in:
Philippe Normand 2023-11-24 15:43:15 +00:00
parent ce661c3b99
commit ee1b905ff3
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
subprojects/gst-plugins-good/ext/adaptivedemux2/dash/gstdashdemux.c
View file

@ -970,12 +970,15 @@ gst_dash_demux_stream_create_tracks (GstAdaptiveDemux2Stream * stream)
gst_stream_collection_get_stream (stream->stream_collection, i);
GstStreamType stream_type = gst_stream_get_stream_type (gst_stream);
GstAdaptiveDemuxTrack *track;
GstTagList *tags = gst_stream_get_tags (gst_stream);
GstCaps *caps = gst_stream_get_caps (gst_stream);
GstTagList *tags;
GstCaps *caps;
if (stream_type == GST_STREAM_TYPE_UNKNOWN)
continue;
caps = gst_stream_get_caps (gst_stream);
tags = gst_stream_get_tags (gst_stream);
GST_DEBUG_OBJECT (stream, "create track type %d of the stream",
stream_type);
stream->stream_type |= stream_type;
@ -990,9 +993,6 @@ gst_dash_demux_stream_create_tracks (GstAdaptiveDemux2Stream * stream)
g_strdup (gst_stream_get_stream_id (gst_stream));
gst_adaptive_demux2_stream_add_track (stream, track);
gst_adaptive_demux_track_unref (track);
if (tags)
gst_tag_list_unref (tags);
}
}