mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-12-18 22:36:33 +00:00
playbin: Properly destroy and set to NULL sinks that don't work
This commit is contained in:
parent
f174c450c9
commit
edecd7eec3
1 changed files with 3 additions and 0 deletions
|
@ -4233,6 +4233,7 @@ autoplug_select_cb (GstElement * decodebin, GstPad * pad,
|
||||||
} else {
|
} else {
|
||||||
if (!activate_sink (playbin, *sinkp, NULL)) {
|
if (!activate_sink (playbin, *sinkp, NULL)) {
|
||||||
gst_object_unref (*sinkp);
|
gst_object_unref (*sinkp);
|
||||||
|
*sinkp = NULL;
|
||||||
GST_WARNING_OBJECT (playbin,
|
GST_WARNING_OBJECT (playbin,
|
||||||
"Could not activate sink %s",
|
"Could not activate sink %s",
|
||||||
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (ave->sink)));
|
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (ave->sink)));
|
||||||
|
@ -4381,6 +4382,8 @@ autoplug_select_cb (GstElement * decodebin, GstPad * pad,
|
||||||
if (!activate_sink (playbin, element, NULL)) {
|
if (!activate_sink (playbin, element, NULL)) {
|
||||||
GST_WARNING_OBJECT (playbin, "Could not activate sink %s",
|
GST_WARNING_OBJECT (playbin, "Could not activate sink %s",
|
||||||
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (factory)));
|
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (factory)));
|
||||||
|
*sinkp = NULL;
|
||||||
|
gst_object_unref (element);
|
||||||
GST_SOURCE_GROUP_UNLOCK (group);
|
GST_SOURCE_GROUP_UNLOCK (group);
|
||||||
return GST_AUTOPLUG_SELECT_SKIP;
|
return GST_AUTOPLUG_SELECT_SKIP;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue